pg.ddx.io  pgsql-testers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Denis de Bernardy <ddebernardy@yahoo.com>
To: Jeff Davis <pgsql@j-davis.com>
To: oleg@sai.msu.su <oleg@sai.msu.su>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Cc: pgsql-bugs@postgresql.org <pgsql-bugs@postgresql.org>
Subject: Re: PG regression with row comparison when btree_gist is enabled (BUG)
Date: Mon, 20 Jun 2011 00:23:45 -0700 (PDT)
Message-ID: <636928.87301.qm@web112417.mail.gq1.yahoo.com> (raw)
In-Reply-To: <1308504190.2597.71.camel@jdavis>
References: <4DF81BA0.3000601@archidevsys.co.nz>
	<743036.48052.qm@web112401.mail.gq1.yahoo.com>
	<366790.65150.qm@web112414.mail.gq1.yahoo.com>
	<BANLkTikm9Q_z1aYCB9U_Pc0tPTO+LzG57Q@mail.gmail.com>
	<1308428403.2597.66.camel@jdavis>
	<1308504190.2597.71.camel@jdavis>

I only did some cursory tests, but the patch (applied to Macport's beta2 distribution) seems to be working on my dev box (OSX / Snow Leopard).

I'll report back if I run into oddities further down the road.

Thanks a lot!
Denis





>________________________________
>From: Jeff Davis <pgsql@j-davis.com>
>To: oleg@sai.msu.su
>Cc: Denis de Bernardy <ddebernardy@yahoo.com>; Teodor Sigaev <teodor@sigaev.ru>; pgsql-bugs@postgresql.org
>Sent: Sunday, June 19, 2011 7:23 PM
>Subject: Re: PG regression with row comparison when btree_gist is enabled (BUG)
>
>On Sat, 2011-06-18 at 13:20 -0700, Jeff Davis wrote:
>> Interesting problem... the bug is in get_op_btree_interpretation() which
>> has code like this:
>> 
>>   /*                                                                                                
>>    * If we can't find any opfamily containing the op, perhaps it is a
>> <>                            
>>    * operator.  See if it has a negator that is in an
>> opfamily.                                      
>>    */
>>   op_negated = false;
>>   if (catlist->n_members == 0)
>> 
>> 
>> However, that's a bogus test, because btree_gist puts <> into an
>> opfamily. Thus, catlist->n_members == 1 even though we really do need to
>> look for the negator. Really, we need to unconditionally search for the
>> operator as well as unconditionally searching for the negator.
>
>Patch attached.
>
>Regards,
>    Jeff Davis
>
>
>

view thread (10+ messages)  latest in thread

Message-ID: <636928.87301.qm@web112417.mail.gq1.yahoo.com>
Permalink:  ../636928.87301.qm@web112417.mail.gq1.yahoo.com/
Also on:    postgresql.org/message-id/636928.87301.qm@web112417.mail.gq1.yahoo.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-testers@postgresql.org
  Cc: ddebernardy@yahoo.com, pgsql@j-davis.com, oleg@sai.msu.su, teodor@sigaev.ru, pgsql-bugs@postgresql.org
  Subject: Re: PG regression with row comparison when btree_gist is enabled (BUG)
  In-Reply-To: <636928.87301.qm@web112417.mail.gq1.yahoo.com>
  References: <4DF81BA0.3000601@archidevsys.co.nz> <743036.48052.qm@web112401.mail.gq1.yahoo.com> <366790.65150.qm@web112414.mail.gq1.yahoo.com> <BANLkTikm9Q_z1aYCB9U_Pc0tPTO+LzG57Q@mail.gmail.com> <1308428403.2597.66.camel@jdavis> <1308504190.2597.71.camel@jdavis> <636928.87301.qm@web112417.mail.gq1.yahoo.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox