From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Cc: pgsql-translators@lists.postgresql.org
Subject: Re: more message fixes
Date: Wed, 15 May 2019 17:48:01 -0400
Message-ID: <17813.1557956881@sss.pgh.pa.us> (raw)
In-Reply-To: <20190515183005.GA26486@alvherre.pgsql>
References: <20190515183005.GA26486@alvherre.pgsql>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Here's a bunch of message fixes in the postgres.po module. Please
> comment if anything seems amiss.
These sorts of changes trouble me a bit from a translatability standpoint:
- errmsg("connect = false and enabled = true are mutually exclusive options")));
+ errmsg("%s and %s are mutually exclusive options",
+ "connect = false", "enabled = true")));
- (errmsg("CREATE_REPLICATION_SLOT ... USE_SNAPSHOT "
- "must not be called in a subtransaction")));
+ (errmsg("%s must not be called in a subtransaction",
+ "CREATE_REPLICATION_SLOT ... USE_SNAPSHOT")));
A translator might expect the %s's to represent single words.
I think at least you'd want a translator: comment to warn about
what the insertion will be.
+ /* XXX is it okay to use %d for BlockNumber everywhere? */
BlockNumber should be %u, no?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-translators@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, pgsql-hackers@lists.postgresql.org, pgsql-translators@lists.postgresql.org
Subject: Re: more message fixes
In-Reply-To: <17813.1557956881@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox