From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Cc: pgsql-translators@lists.postgresql.org
Subject: Re: more message fixes
Date: Wed, 15 May 2019 18:25:28 -0400
Message-ID: <20190515222528.GA23894@alvherre.pgsql> (raw)
In-Reply-To: <17813.1557956881@sss.pgh.pa.us>
On 2019-May-15, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Here's a bunch of message fixes in the postgres.po module. Please
> > comment if anything seems amiss.
>
> These sorts of changes trouble me a bit from a translatability standpoint:
>
> - errmsg("connect = false and enabled = true are mutually exclusive options")));
> + errmsg("%s and %s are mutually exclusive options",
> + "connect = false", "enabled = true")));
>
> - (errmsg("CREATE_REPLICATION_SLOT ... USE_SNAPSHOT "
> - "must not be called in a subtransaction")));
> + (errmsg("%s must not be called in a subtransaction",
> + "CREATE_REPLICATION_SLOT ... USE_SNAPSHOT")));
>
> A translator might expect the %s's to represent single words.
> I think at least you'd want a translator: comment to warn about
> what the insertion will be.
Fair point, I can add that. (As a translator, I know I have to
reference the source files more often than I would like.) :-(
> + /* XXX is it okay to use %d for BlockNumber everywhere? */
>
> BlockNumber should be %u, no?
Yeah. It's %d in basebackup.c, hence the comment. I think technically
it's okay most of the time, because it's only used to reference to block
numbers in a *file*, not a relation; however, I fear it might still
break in cases of a very large --with-segsize option.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-translators@postgresql.org
Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, pgsql-translators@lists.postgresql.org
Subject: Re: more message fixes
In-Reply-To: <20190515222528.GA23894@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox