pg.ddx.io  pgsql-translators@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: kerbrose khaled <kerbrose@hotmail.com>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: updating unaccent.rules for Arabic letters
Date: Sun, 03 Nov 2019 11:12:15 -0500
Message-ID: <5527.1572797535@sss.pgh.pa.us> (raw)
In-Reply-To: <VI1PR06MB5760293A34B4E091DE682021DA7C0@VI1PR06MB5760.eurprd06.prod.outlook.com>
References: <VI1PR06MB5760C7B160B3613739817C2ADA7C0@VI1PR06MB5760.eurprd06.prod.outlook.com>
	<VI1PR06MB5760293A34B4E091DE682021DA7C0@VI1PR06MB5760.eurprd06.prod.outlook.com>

kerbrose khaled <kerbrose@hotmail.com> writes:
> I would like to update unaccent.rules file to support Arabic letters. so could someone help me or tell me how could I add such contribution. I attached the file including the modifications, only the last 4 lines.

Hi!  I've got no objection to including Arabic in the set of covered
languages, but handing us a new unaccent.rules file isn't the way to
do it, because that's a generated file.  The adjacent script
generate_unaccent_rules.py generates it from the official Unicode
source data (see comments in that script).  What we need, ultimately,
is a patch to that script so it will emit these additional translations.
Past commits that might be useful sources of inspiration include

https://git.postgresql.org/gitweb/?p=postgresql.git&a=commitdiff&h=456e3718e7b72efe4d2639437...
https://git.postgresql.org/gitweb/?p=postgresql.git&a=commitdiff&h=5e8d670c313531c0dca245943...
https://git.postgresql.org/gitweb/?p=postgresql.git&a=commitdiff&h=ec0a69e49bf41a37b5c2d6f6b...

If you're not good with Python, maybe you could just explain to us
how to recognize these characters from Unicode character properties.

			regards, tom lane





view thread (4+ messages)  latest in thread

Message-ID: <5527.1572797535@sss.pgh.pa.us>
Permalink:  ../5527.1572797535@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/5527.1572797535@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-translators@postgresql.org
  Cc: tgl@sss.pgh.pa.us, kerbrose@hotmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: updating unaccent.rules for Arabic letters
  In-Reply-To: <5527.1572797535@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox