public inbox for [email protected]
help / color / mirror / Atom feedPatch for text.css
21+ messages / 8 participants
[nested] [flat]
* Patch for text.css
@ 2007-01-05 20:04 Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
0 siblings, 1 reply; 21+ messages in thread
From: Matt Perry @ 2007-01-05 20:04 UTC (permalink / raw)
To: pgsql-www
Hi,
Could someone please look into applying this patch? The current style in
http://www.postgresql.org/layout/css/blue/text.css sets the visited and
non-visited link colors to be the same. This patch fixes them to be
different so this navigation aid is restored.
Matt
--- text.css.orig 2007-01-05 11:56:37.295915200 -0800
+++ text.css 2007-01-05 11:57:27.347886400 -0800
@@ -129,7 +129,7 @@
/* Link Styles */
a:link { color:#0085B0; text-decoration:
underline; }
-a:visited { color:#0085B0; text-decoration:
underline; }
+a:visited { color:#004E66; text-decoration:
underline; }
a:active { color:#0085B0; text-decoration:
underline; }
a:hover { color:#000000; text-decoration:
underline; }
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
@ 2007-01-06 17:34 ` Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
0 siblings, 1 reply; 21+ messages in thread
From: Magnus Hagander @ 2007-01-06 17:34 UTC (permalink / raw)
To: [email protected]; +Cc: pgsql-www
in principle i like it, but there was a reason it was there. anyond know why? Objections to changing it1?
/Magnus
------- Original message -------
From: Matt Perry <[email protected]>
Sent: 1-5-'07, 12:04
> Hi,
>
> Could someone please look into applying this patch? The current style in http://www.postgresql.org/layout/css/blue/text.css sets the visited and non-visited
link colors to be the same. This patch fixes them to be different so this navigation aid is restored.
>
> Matt
>
> --- text.css.orig 2007-01-05 11:56:37.295915200 -0800
> +++ text.css 2007-01-05 11:57:27.347886400 -0800
> @@ -129,7 +129,7 @@
> /* Link Styles */
>
> a:link { color:#0085B0; text-decoration: underline; }
> -a:visited { color:#0085B0; text-decoration: underline; }
> +a:visited { color:#004E66; text-decoration: underline; }
> a:active { color:#0085B0; text-decoration: underline; }
> a:hover { color:#000000; text-decoration: underline; }
>
>
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
@ 2007-01-06 17:48 ` Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
0 siblings, 1 reply; 21+ messages in thread
From: Tom Lane @ 2007-01-06 17:48 UTC (permalink / raw)
To: Magnus Hagander <[email protected]>; +Cc: [email protected]; pgsql-www
"Magnus Hagander" <[email protected]> writes:
> in principle i like it, but there was a reason it was there. anyond know why? Objections to changing it1?
Surely it was just a typo --- I can't believe anyone would intentionally
hide the difference between visited and unvisited links. The question
though is what two colors we want to use.
regards, tom lane
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
@ 2007-01-07 03:37 ` Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
0 siblings, 1 reply; 21+ messages in thread
From: Robert Treat @ 2007-01-07 03:37 UTC (permalink / raw)
To: pgsql-www; +Cc: Tom Lane <[email protected]>; Magnus Hagander <[email protected]>; [email protected]
On Saturday 06 January 2007 12:48, Tom Lane wrote:
> "Magnus Hagander" <[email protected]> writes:
> > in principle i like it, but there was a reason it was there. anyond know
> > why? Objections to changing it1?
>
> Surely it was just a typo --- I can't believe anyone would intentionally
> hide the difference between visited and unvisited links. The question
> though is what two colors we want to use.
>
I'd be more surprised if it wasn't done intentionally; web designers use this
technique all the time, claiming it adds a more consitent color scheme / look
to the website. Usability analysts will tell you that anything you think you
gain in asthetics is lost in breaking the standard color conventions people
are used to. The above patch sets visited links as a darker/paler blue; if we
are going to change it I'd suggest going with the standard purple color (or
something very similar).
--
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
@ 2007-01-07 17:26 ` Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
0 siblings, 1 reply; 21+ messages in thread
From: Magnus Hagander @ 2007-01-07 17:26 UTC (permalink / raw)
To: Robert Treat <[email protected]>; +Cc: pgsql-www; Tom Lane <[email protected]>; [email protected]
Robert Treat wrote:
> On Saturday 06 January 2007 12:48, Tom Lane wrote:
>> "Magnus Hagander" <[email protected]> writes:
>>> in principle i like it, but there was a reason it was there. anyond know
>>> why? Objections to changing it1?
>> Surely it was just a typo --- I can't believe anyone would intentionally
>> hide the difference between visited and unvisited links. The question
>> though is what two colors we want to use.
>>
>
> I'd be more surprised if it wasn't done intentionally; web designers use this
> technique all the time, claiming it adds a more consitent color scheme / look
> to the website. Usability analysts will tell you that anything you think you
> gain in asthetics is lost in breaking the standard color conventions people
> are used to. The above patch sets visited links as a darker/paler blue; if we
> are going to change it I'd suggest going with the standard purple color (or
> something very similar).
Or should we perhaps just stop setting a color at all on it? That would
let the browser choose color? I don't know how common it is for people
to change the colors of the links, but I'm sure some do... And then we'd
just go with whatever the browser had?
//Magnus
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
@ 2007-01-08 01:53 ` Tom Lane <[email protected]>
2007-01-08 16:20 ` Re: Patch for text.css Magnus Hagander <[email protected]>
0 siblings, 1 reply; 21+ messages in thread
From: Tom Lane @ 2007-01-08 01:53 UTC (permalink / raw)
To: Magnus Hagander <[email protected]>; +Cc: Robert Treat <[email protected]>; pgsql-www; [email protected]
Magnus Hagander <[email protected]> writes:
> Or should we perhaps just stop setting a color at all on it? That would
> let the browser choose color?
I wouldn't vote for that; the odds are good that the browser's defaults
would look ugly, or maybe even be nearly invisible against our
backgrounds. We *should* set the link colors ... just not to the same
thing.
regards, tom lane
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
@ 2007-01-08 16:20 ` Magnus Hagander <[email protected]>
2007-01-08 16:29 ` Re: Patch for text.css Dave Page <[email protected]>
2007-01-09 04:58 ` Re: Patch for text.css Robert Treat <[email protected]>
0 siblings, 2 replies; 21+ messages in thread
From: Magnus Hagander @ 2007-01-08 16:20 UTC (permalink / raw)
To: Tom Lane <[email protected]>; +Cc: Robert Treat <[email protected]>; pgsql-www; [email protected]
On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
> Magnus Hagander <[email protected]> writes:
> > Or should we perhaps just stop setting a color at all on it? That would
> > let the browser choose color?
>
> I wouldn't vote for that; the odds are good that the browser's defaults
> would look ugly, or maybe even be nearly invisible against our
> backgrounds. We *should* set the link colors ... just not to the same
> thing.
I've applied the patch to http://magnus-master.pgadmin.org with the
color as suggested, for review.
Thoughts? Different color? Suggestions?
//Magnus
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-08 16:20 ` Re: Patch for text.css Magnus Hagander <[email protected]>
@ 2007-01-08 16:29 ` Dave Page <[email protected]>
1 sibling, 0 replies; 21+ messages in thread
From: Dave Page @ 2007-01-08 16:29 UTC (permalink / raw)
To: Magnus Hagander <[email protected]>; +Cc: Tom Lane <[email protected]>; Robert Treat <[email protected]>; pgsql-www; [email protected]
Magnus Hagander wrote:
> On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
>> Magnus Hagander <[email protected]> writes:
>>> Or should we perhaps just stop setting a color at all on it? That would
>>> let the browser choose color?
>> I wouldn't vote for that; the odds are good that the browser's defaults
>> would look ugly, or maybe even be nearly invisible against our
>> backgrounds. We *should* set the link colors ... just not to the same
>> thing.
>
> I've applied the patch to http://magnus-master.pgadmin.org with the
> color as suggested, for review.
>
> Thoughts? Different color? Suggestions?
Looks fine to me.
/D
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-08 16:20 ` Re: Patch for text.css Magnus Hagander <[email protected]>
@ 2007-01-09 04:58 ` Robert Treat <[email protected]>
2007-01-09 05:26 ` Re: Patch for text.css Dan Langille <[email protected]>
2007-01-09 20:17 ` Re: Patch for text.css Magnus Hagander <[email protected]>
1 sibling, 2 replies; 21+ messages in thread
From: Robert Treat @ 2007-01-09 04:58 UTC (permalink / raw)
To: Magnus Hagander <[email protected]>; +Cc: Tom Lane <[email protected]>; pgsql-www; [email protected]
On Monday 08 January 2007 11:20, Magnus Hagander wrote:
> On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
> > Magnus Hagander <[email protected]> writes:
> > > Or should we perhaps just stop setting a color at all on it? That would
> > > let the browser choose color?
> >
> > I wouldn't vote for that; the odds are good that the browser's defaults
> > would look ugly, or maybe even be nearly invisible against our
> > backgrounds. We *should* set the link colors ... just not to the same
> > thing.
>
> I've applied the patch to http://magnus-master.pgadmin.org with the
> color as suggested, for review.
>
> Thoughts? Different color? Suggestions?
>
I had a hard time differentiating it last night, so I changed it to use the
standard color on http://xzilla.postgresql.org just to get a different look.
Anyone interested in comparing can check it out.
--
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-08 16:20 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-09 04:58 ` Re: Patch for text.css Robert Treat <[email protected]>
@ 2007-01-09 05:26 ` Dan Langille <[email protected]>
1 sibling, 0 replies; 21+ messages in thread
From: Dan Langille @ 2007-01-09 05:26 UTC (permalink / raw)
To: Magnus Hagander <[email protected]>; Robert Treat <[email protected]>; +Cc: Tom Lane <[email protected]>; pgsql-www; [email protected]
On 8 Jan 2007 at 23:58, Robert Treat wrote:
> On Monday 08 January 2007 11:20, Magnus Hagander wrote:
> > On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
> > > Magnus Hagander <[email protected]> writes:
> > > > Or should we perhaps just stop setting a color at all on it? That would
> > > > let the browser choose color?
> > >
> > > I wouldn't vote for that; the odds are good that the browser's defaults
> > > would look ugly, or maybe even be nearly invisible against our
> > > backgrounds. We *should* set the link colors ... just not to the same
> > > thing.
> >
> > I've applied the patch to http://magnus-master.pgadmin.org with the
> > color as suggested, for review.
> >
> > Thoughts? Different color? Suggestions?
> >
>
> I had a hard time differentiating it last night, so I changed it to use the
> standard color on http://xzilla.postgresql.org just to get a different look.
> Anyone interested in comparing can check it out.
FWIW, I'm slightly colour blind. I see the differences in the first
one better.
--
Dan Langille : Software Developer looking for work
my resume: http://www.freebsddiary.org/dan_langille.php
PGCon - The PostgreSQL Conference - http://www.pgcon.org/
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-08 16:20 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-09 04:58 ` Re: Patch for text.css Robert Treat <[email protected]>
@ 2007-01-09 20:17 ` Magnus Hagander <[email protected]>
2007-01-09 20:19 ` Re: Patch for text.css Joshua D. Drake <[email protected]>
2007-01-20 22:13 ` Re: Patch for text.css Bruce Momjian <[email protected]>
1 sibling, 2 replies; 21+ messages in thread
From: Magnus Hagander @ 2007-01-09 20:17 UTC (permalink / raw)
To: Robert Treat <[email protected]>; +Cc: Tom Lane <[email protected]>; pgsql-www; [email protected]
Robert Treat wrote:
> On Monday 08 January 2007 11:20, Magnus Hagander wrote:
>> On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
>>> Magnus Hagander <[email protected]> writes:
>>>> Or should we perhaps just stop setting a color at all on it? That would
>>>> let the browser choose color?
>>> I wouldn't vote for that; the odds are good that the browser's defaults
>>> would look ugly, or maybe even be nearly invisible against our
>>> backgrounds. We *should* set the link colors ... just not to the same
>>> thing.
>> I've applied the patch to http://magnus-master.pgadmin.org with the
>> color as suggested, for review.
>>
>> Thoughts? Different color? Suggestions?
>>
>
> I had a hard time differentiating it last night, so I changed it to use the
> standard color on http://xzilla.postgresql.org just to get a different look.
> Anyone interested in comparing can check it out.
I personally think yours is clearer, but I'm a bit concerned on the
third opinion ;-) Anybody else care to chime in?
//Magnus
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-08 16:20 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-09 04:58 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-09 20:17 ` Re: Patch for text.css Magnus Hagander <[email protected]>
@ 2007-01-09 20:19 ` Joshua D. Drake <[email protected]>
1 sibling, 0 replies; 21+ messages in thread
From: Joshua D. Drake @ 2007-01-09 20:19 UTC (permalink / raw)
To: Magnus Hagander <[email protected]>; +Cc: Robert Treat <[email protected]>; Tom Lane <[email protected]>; pgsql-www; [email protected]
> > I had a hard time differentiating it last night, so I changed it to use the
> > standard color on http://xzilla.postgresql.org just to get a different look.
> > Anyone interested in comparing can check it out.
>
> I personally think yours is clearer, but I'm a bit concerned on the
> third opinion ;-) Anybody else care to chime in?
None you have any clue ;)
Joshua D. Drake
P.S. You can now ignore the third opinion and move forward :)
>
> //Magnus
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
> choose an index scan if your joining column's datatypes do not
> match
>
--
=== The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240
Providing the most comprehensive PostgreSQL solutions since 1997
http://www.commandprompt.com/
Donate to the PostgreSQL Project: http://www.postgresql.org/about/donate
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-08 16:20 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-09 04:58 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-09 20:17 ` Re: Patch for text.css Magnus Hagander <[email protected]>
@ 2007-01-20 22:13 ` Bruce Momjian <[email protected]>
2007-01-20 22:46 ` Re: Patch for text.css Magnus Hagander <[email protected]>
1 sibling, 1 reply; 21+ messages in thread
From: Bruce Momjian @ 2007-01-20 22:13 UTC (permalink / raw)
To: Magnus Hagander <[email protected]>; +Cc: Robert Treat <[email protected]>; Tom Lane <[email protected]>; pgsql-www; [email protected]
Are we going to apply this?
---------------------------------------------------------------------------
Magnus Hagander wrote:
> Robert Treat wrote:
> > On Monday 08 January 2007 11:20, Magnus Hagander wrote:
> >> On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
> >>> Magnus Hagander <[email protected]> writes:
> >>>> Or should we perhaps just stop setting a color at all on it? That would
> >>>> let the browser choose color?
> >>> I wouldn't vote for that; the odds are good that the browser's defaults
> >>> would look ugly, or maybe even be nearly invisible against our
> >>> backgrounds. We *should* set the link colors ... just not to the same
> >>> thing.
> >> I've applied the patch to http://magnus-master.pgadmin.org with the
> >> color as suggested, for review.
> >>
> >> Thoughts? Different color? Suggestions?
> >>
> >
> > I had a hard time differentiating it last night, so I changed it to use the
> > standard color on http://xzilla.postgresql.org just to get a different look.
> > Anyone interested in comparing can check it out.
>
> I personally think yours is clearer, but I'm a bit concerned on the
> third opinion ;-) Anybody else care to chime in?
>
> //Magnus
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
> choose an index scan if your joining column's datatypes do not
> match
--
Bruce Momjian [email protected]
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-08 16:20 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-09 04:58 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-09 20:17 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-20 22:13 ` Re: Patch for text.css Bruce Momjian <[email protected]>
@ 2007-01-20 22:46 ` Magnus Hagander <[email protected]>
2007-01-20 23:02 ` Re: Patch for text.css Bruce Momjian <[email protected]>
0 siblings, 1 reply; 21+ messages in thread
From: Magnus Hagander @ 2007-01-20 22:46 UTC (permalink / raw)
To: Bruce Momjian <[email protected]>; +Cc: Robert Treat <[email protected]>; Tom Lane <[email protected]>; pgsql-www; [email protected]
I was hoping someone else would comment on which one of the two they
preferred before we committed it. And then I promptly forgot about it ;-)
So, which one do people prefer?
//Magnus
Bruce Momjian wrote:
> Are we going to apply this?
>
> ---------------------------------------------------------------------------
>
> Magnus Hagander wrote:
>> Robert Treat wrote:
>>> On Monday 08 January 2007 11:20, Magnus Hagander wrote:
>>>> On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
>>>>> Magnus Hagander <[email protected]> writes:
>>>>>> Or should we perhaps just stop setting a color at all on it? That would
>>>>>> let the browser choose color?
>>>>> I wouldn't vote for that; the odds are good that the browser's defaults
>>>>> would look ugly, or maybe even be nearly invisible against our
>>>>> backgrounds. We *should* set the link colors ... just not to the same
>>>>> thing.
>>>> I've applied the patch to http://magnus-master.pgadmin.org with the
>>>> color as suggested, for review.
>>>>
>>>> Thoughts? Different color? Suggestions?
>>>>
>>> I had a hard time differentiating it last night, so I changed it to use the
>>> standard color on http://xzilla.postgresql.org just to get a different look.
>>> Anyone interested in comparing can check it out.
>> I personally think yours is clearer, but I'm a bit concerned on the
>> third opinion ;-) Anybody else care to chime in?
>>
>> //Magnus
>>
>> ---------------------------(end of broadcast)---------------------------
>> TIP 9: In versions below 8.0, the planner will ignore your desire to
>> choose an index scan if your joining column's datatypes do not
>> match
>
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-08 16:20 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-09 04:58 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-09 20:17 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-20 22:13 ` Re: Patch for text.css Bruce Momjian <[email protected]>
2007-01-20 22:46 ` Re: Patch for text.css Magnus Hagander <[email protected]>
@ 2007-01-20 23:02 ` Bruce Momjian <[email protected]>
2007-01-31 19:15 ` Re: Patch for text.css Matt Perry <[email protected]>
0 siblings, 1 reply; 21+ messages in thread
From: Bruce Momjian @ 2007-01-20 23:02 UTC (permalink / raw)
To: Magnus Hagander <[email protected]>; +Cc: Robert Treat <[email protected]>; Tom Lane <[email protected]>; pgsql-www; [email protected]
I think the feedback was that using the standard colors was too likely
to look bad on the web site. Perhaps you should just increase the
different between the blues on your version and commit it, and then ask
for more feedback.
---------------------------------------------------------------------------
Magnus Hagander wrote:
> I was hoping someone else would comment on which one of the two they
> preferred before we committed it. And then I promptly forgot about it ;-)
>
> So, which one do people prefer?
>
> //Magnus
>
>
> Bruce Momjian wrote:
> > Are we going to apply this?
> >
> > ---------------------------------------------------------------------------
> >
> > Magnus Hagander wrote:
> >> Robert Treat wrote:
> >>> On Monday 08 January 2007 11:20, Magnus Hagander wrote:
> >>>> On Sun, Jan 07, 2007 at 08:53:30PM -0500, Tom Lane wrote:
> >>>>> Magnus Hagander <[email protected]> writes:
> >>>>>> Or should we perhaps just stop setting a color at all on it? That would
> >>>>>> let the browser choose color?
> >>>>> I wouldn't vote for that; the odds are good that the browser's defaults
> >>>>> would look ugly, or maybe even be nearly invisible against our
> >>>>> backgrounds. We *should* set the link colors ... just not to the same
> >>>>> thing.
> >>>> I've applied the patch to http://magnus-master.pgadmin.org with the
> >>>> color as suggested, for review.
> >>>>
> >>>> Thoughts? Different color? Suggestions?
> >>>>
> >>> I had a hard time differentiating it last night, so I changed it to use the
> >>> standard color on http://xzilla.postgresql.org just to get a different look.
> >>> Anyone interested in comparing can check it out.
> >> I personally think yours is clearer, but I'm a bit concerned on the
> >> third opinion ;-) Anybody else care to chime in?
> >>
> >> //Magnus
> >>
> >> ---------------------------(end of broadcast)---------------------------
> >> TIP 9: In versions below 8.0, the planner will ignore your desire to
> >> choose an index scan if your joining column's datatypes do not
> >> match
> >
--
Bruce Momjian [email protected]
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-08 16:20 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-09 04:58 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-09 20:17 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-20 22:13 ` Re: Patch for text.css Bruce Momjian <[email protected]>
2007-01-20 22:46 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-20 23:02 ` Re: Patch for text.css Bruce Momjian <[email protected]>
@ 2007-01-31 19:15 ` Matt Perry <[email protected]>
2007-02-02 02:44 ` Re: Patch for text.css Robert Treat <[email protected]>
0 siblings, 1 reply; 21+ messages in thread
From: Matt Perry @ 2007-01-31 19:15 UTC (permalink / raw)
To: pgsql-www
On 1/20/07, Bruce Momjian <[email protected]> wrote:
>
> Perhaps you should just increase the
> different between the blues on your version and commit it, and then ask
> for more feedback.
Is there any chance that this could be deployed soon?
Matt
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-08 16:20 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-09 04:58 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-09 20:17 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-20 22:13 ` Re: Patch for text.css Bruce Momjian <[email protected]>
2007-01-20 22:46 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-20 23:02 ` Re: Patch for text.css Bruce Momjian <[email protected]>
2007-01-31 19:15 ` Re: Patch for text.css Matt Perry <[email protected]>
@ 2007-02-02 02:44 ` Robert Treat <[email protected]>
2007-02-02 03:26 ` Re: Patch for text.css Bruce Momjian <[email protected]>
2007-02-06 18:59 ` Re: Patch for text.css Bruce Momjian <[email protected]>
0 siblings, 2 replies; 21+ messages in thread
From: Robert Treat @ 2007-02-02 02:44 UTC (permalink / raw)
To: pgsql-www; +Cc: Matt Perry <[email protected]>
On Wednesday 31 January 2007 14:15, Matt Perry wrote:
> On 1/20/07, Bruce Momjian <[email protected]> wrote:
> > Perhaps you should just increase the
> > different between the blues on your version and commit it, and then ask
> > for more feedback.
>
> Is there any chance that this could be deployed soon?
>
Did you have an opinion on the quasi-blue vs standard colors? I'm inclined to
commit the stand colors unless you speak up.
--
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-08 16:20 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-09 04:58 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-09 20:17 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-20 22:13 ` Re: Patch for text.css Bruce Momjian <[email protected]>
2007-01-20 22:46 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-20 23:02 ` Re: Patch for text.css Bruce Momjian <[email protected]>
2007-01-31 19:15 ` Re: Patch for text.css Matt Perry <[email protected]>
2007-02-02 02:44 ` Re: Patch for text.css Robert Treat <[email protected]>
@ 2007-02-02 03:26 ` Bruce Momjian <[email protected]>
1 sibling, 0 replies; 21+ messages in thread
From: Bruce Momjian @ 2007-02-02 03:26 UTC (permalink / raw)
To: Robert Treat <[email protected]>; +Cc: pgsql-www; Matt Perry <[email protected]>
Robert Treat wrote:
> On Wednesday 31 January 2007 14:15, Matt Perry wrote:
> > On 1/20/07, Bruce Momjian <[email protected]> wrote:
> > > Perhaps you should just increase the
> > > different between the blues on your version and commit it, and then ask
> > > for more feedback.
> >
> > Is there any chance that this could be deployed soon?
> >
>
> Did you have an opinion on the quasi-blue vs standard colors? I'm inclined to
> commit the stand colors unless you speak up.
I think the consensus was that the quasi-blue was better than using
standard because the standard might not look good on our site.
--
Bruce Momjian [email protected]
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-08 16:20 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-09 04:58 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-09 20:17 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-20 22:13 ` Re: Patch for text.css Bruce Momjian <[email protected]>
2007-01-20 22:46 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-20 23:02 ` Re: Patch for text.css Bruce Momjian <[email protected]>
2007-01-31 19:15 ` Re: Patch for text.css Matt Perry <[email protected]>
2007-02-02 02:44 ` Re: Patch for text.css Robert Treat <[email protected]>
@ 2007-02-06 18:59 ` Bruce Momjian <[email protected]>
2007-02-06 20:11 ` Re: Patch for text.css Robert Treat <[email protected]>
1 sibling, 1 reply; 21+ messages in thread
From: Bruce Momjian @ 2007-02-06 18:59 UTC (permalink / raw)
To: Robert Treat <[email protected]>; +Cc: pgsql-www; Matt Perry <[email protected]>
Robert Treat wrote:
> On Wednesday 31 January 2007 14:15, Matt Perry wrote:
> > On 1/20/07, Bruce Momjian <[email protected]> wrote:
> > > Perhaps you should just increase the
> > > different between the blues on your version and commit it, and then ask
> > > for more feedback.
> >
> > Is there any chance that this could be deployed soon?
> >
>
> Did you have an opinion on the quasi-blue vs standard colors? I'm inclined to
> commit the stand colors unless you speak up.
Looks like this has been applied.
--
Bruce Momjian [email protected]
Homepage http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-08 16:20 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-09 04:58 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-09 20:17 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-20 22:13 ` Re: Patch for text.css Bruce Momjian <[email protected]>
2007-01-20 22:46 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-20 23:02 ` Re: Patch for text.css Bruce Momjian <[email protected]>
2007-01-31 19:15 ` Re: Patch for text.css Matt Perry <[email protected]>
2007-02-02 02:44 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-02-06 18:59 ` Re: Patch for text.css Bruce Momjian <[email protected]>
@ 2007-02-06 20:11 ` Robert Treat <[email protected]>
2007-02-06 21:07 ` Re: Patch for text.css Bruce Momjian <[email protected]>
0 siblings, 1 reply; 21+ messages in thread
From: Robert Treat @ 2007-02-06 20:11 UTC (permalink / raw)
To: Bruce Momjian <[email protected]>; +Cc: pgsql-www; Matt Perry <[email protected]>
On Tuesday 06 February 2007 13:59, Bruce Momjian wrote:
> Robert Treat wrote:
> > On Wednesday 31 January 2007 14:15, Matt Perry wrote:
> > > On 1/20/07, Bruce Momjian <[email protected]> wrote:
> > > > Perhaps you should just increase the
> > > > different between the blues on your version and commit it, and then
> > > > ask for more feedback.
> > >
> > > Is there any chance that this could be deployed soon?
> >
> > Did you have an opinion on the quasi-blue vs standard colors? I'm
> > inclined to commit the stand colors unless you speak up.
>
> Looks like this has been applied.
Yep, I applied it a few days ago. :-)
--
Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL
^ permalink raw reply [nested|flat] 21+ messages in thread
* Re: Patch for text.css
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-07 03:37 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-07 17:26 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Re: Patch for text.css Tom Lane <[email protected]>
2007-01-08 16:20 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-09 04:58 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-01-09 20:17 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-20 22:13 ` Re: Patch for text.css Bruce Momjian <[email protected]>
2007-01-20 22:46 ` Re: Patch for text.css Magnus Hagander <[email protected]>
2007-01-20 23:02 ` Re: Patch for text.css Bruce Momjian <[email protected]>
2007-01-31 19:15 ` Re: Patch for text.css Matt Perry <[email protected]>
2007-02-02 02:44 ` Re: Patch for text.css Robert Treat <[email protected]>
2007-02-06 18:59 ` Re: Patch for text.css Bruce Momjian <[email protected]>
2007-02-06 20:11 ` Re: Patch for text.css Robert Treat <[email protected]>
@ 2007-02-06 21:07 ` Bruce Momjian <[email protected]>
0 siblings, 0 replies; 21+ messages in thread
From: Bruce Momjian @ 2007-02-06 21:07 UTC (permalink / raw)
To: Robert Treat <[email protected]>; +Cc: pgsql-www; Matt Perry <[email protected]>
Robert Treat wrote:
> On Tuesday 06 February 2007 13:59, Bruce Momjian wrote:
> > Robert Treat wrote:
> > > On Wednesday 31 January 2007 14:15, Matt Perry wrote:
> > > > On 1/20/07, Bruce Momjian <[email protected]> wrote:
> > > > > Perhaps you should just increase the
> > > > > different between the blues on your version and commit it, and then
> > > > > ask for more feedback.
> > > >
> > > > Is there any chance that this could be deployed soon?
> > >
> > > Did you have an opinion on the quasi-blue vs standard colors? I'm
> > > inclined to commit the stand colors unless you speak up.
> >
> > Looks like this has been applied.
>
> Yep, I applied it a few days ago. :-)
Looks good.
--
Bruce Momjian [email protected]
Homepage http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
^ permalink raw reply [nested|flat] 21+ messages in thread
end of thread, other threads:[~2007-02-06 21:07 UTC | newest]
Thread overview: 21+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2007-01-05 20:04 Patch for text.css Matt Perry <[email protected]>
2007-01-06 17:34 ` Magnus Hagander <[email protected]>
2007-01-06 17:48 ` Tom Lane <[email protected]>
2007-01-07 03:37 ` Robert Treat <[email protected]>
2007-01-07 17:26 ` Magnus Hagander <[email protected]>
2007-01-08 01:53 ` Tom Lane <[email protected]>
2007-01-08 16:20 ` Magnus Hagander <[email protected]>
2007-01-08 16:29 ` Dave Page <[email protected]>
2007-01-09 04:58 ` Robert Treat <[email protected]>
2007-01-09 05:26 ` Dan Langille <[email protected]>
2007-01-09 20:17 ` Magnus Hagander <[email protected]>
2007-01-09 20:19 ` Joshua D. Drake <[email protected]>
2007-01-20 22:13 ` Bruce Momjian <[email protected]>
2007-01-20 22:46 ` Magnus Hagander <[email protected]>
2007-01-20 23:02 ` Bruce Momjian <[email protected]>
2007-01-31 19:15 ` Matt Perry <[email protected]>
2007-02-02 02:44 ` Robert Treat <[email protected]>
2007-02-02 03:26 ` Bruce Momjian <[email protected]>
2007-02-06 18:59 ` Bruce Momjian <[email protected]>
2007-02-06 20:11 ` Robert Treat <[email protected]>
2007-02-06 21:07 ` Bruce Momjian <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox