public inbox for [email protected]  

help / color / mirror / Atom feed

From: Magnus Hagander <[email protected]>
To: Célestin Matte <[email protected]>
Cc: PostgreSQL WWW <[email protected]>
Subject: Re: [PATCH] pglister: Add possibility to override settings.py in settings_local.py
Date: Thu, 4 Nov 2021 11:24:25 +0100
Message-ID: <CABUevExDcZyiHERttpJuWtG3vEKctFbW_V_mod7HL+29cCm6bQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CABUevEx=CB6Ka1hjmidDUrsQP01QCLq=T+sLiJVTSiCDD+RQ3Q@mail.gmail.com>
	<[email protected]>

On Sun, Oct 31, 2021 at 7:02 PM Célestin Matte <[email protected]>
wrote:

> Hello,
>
> >
> > And finally, settings.py already contains:
> > try:
> >     from .local_settings import *
> > except ImportError:
> >     pass
> >
> >
> > Just a couple of lines above where you are adding it back again. Is that
> also for some reason not working?
>
> Right, I missed that. It's just that in pgweb and pgarchives, the file is
> called settings_local.py, whereas pglister calls it local_settings.py. This
> is just a question of naming consistency, then. Do you think it's worth
> patching?
>

If anything, we'd want to move to local_settings.py in that case -- the
reason we switched to doing that in a bunch of the other projects is TBH
something as simple as "then tab completion works better".

In general we've said it's not worth breaking compat for it on the old
repos though. That can obviously be argued. But if we do, we definitely
don't want to do *both*, in that case we should remove them.



> > Second, I'm not sure why we want to exclude local_settings.py from
> pycodestyle in general?
>
> It's ignored in pgweb, I just assumed there was a good reason for that and
> did the same thing for consistency.
>

Oh, I wasn't even aware of that. TBH, I'm not sure that's intentional, that
may be a leak from "it was easiest to do that in the beginning".

I don't really see a reason why we wouldn't want that file to be scanned as
well -- do you?

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/;
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] pglister: Add possibility to override settings.py in settings_local.py
  In-Reply-To: <CABUevExDcZyiHERttpJuWtG3vEKctFbW_V_mod7HL+29cCm6bQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox