public inbox for [email protected]  

help / color / mirror / Atom feed

From: Magnus Hagander <[email protected]>
To: Nils <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Improve portability of pgweb/load_initial_data.sh
Date: Mon, 8 Nov 2021 10:03:50 +0100
Message-ID: <CABUevEz5X8qSCNEveNOU19Gy3FcOXdRgpP=Z33KUbDw=DNs_cA@mail.gmail.com> (raw)
In-Reply-To: <20211107164951.wxcyp7iar2s4mjkn@nixos>
References: <20211107164951.wxcyp7iar2s4mjkn@nixos>

Hi!

Yeah, I think the fact that it says bash is just a "knee-jerk default" and
not that it ever did either. So I have no problem changing that to sh. I'm
a bit curious though, as to in which scenario this actually causes a
problem?

The second change I'm less sure about. There are many different things you
could change to break a script. This is one of them. You could change PATH,
or you could replace "find" or "xargs" with commands that don't work the
same way. CDPATH is not a variable that should, I believe, ever be exported
into non-interactive scripts in the first place.

//Magnus

On Sun, Nov 7, 2021 at 5:49 PM Nils <[email protected]> wrote:

> The shell script doesn't use bash extensions and bash may not be
> available on all systems at that location.
>
> If CDPATH is set, in certain cases, the call to cd can result in
> unwanted behaviour.
> ---
>  pgweb/load_initial_data.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pgweb/load_initial_data.sh b/pgweb/load_initial_data.sh
> index fb16e70c..c419f298 100755
> --- a/pgweb/load_initial_data.sh
> +++ b/pgweb/load_initial_data.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/bin/sh
>
>  # We keep this in a separate script because using initial_data.xxx in
> django will overwrite
>  # critical data in the database when running a 'syncdb'. We'd like to
> keep the ability to
> @@ -8,7 +8,7 @@ echo WARNING: this may overwrite some data in the database
> with an initial set o
>  echo 'Are you sure you want this (answer "yes" to overwrite)'
>  read R
>
> -cd $(dirname $0)
> +CDPATH= cd $(dirname $0)
>
>  if [ "$R" == "yes" ]; then
>     find . -name data.json | xargs ../manage.py loaddata
> --
> 2.31.1
>
>
>
>

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/;
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Improve portability of pgweb/load_initial_data.sh
  In-Reply-To: <CABUevEz5X8qSCNEveNOU19Gy3FcOXdRgpP=Z33KUbDw=DNs_cA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox