public inbox for [email protected]  
help / color / mirror / Atom feed
pglister: don't say "subject is empty" for non-empty subjects
3+ messages / 3 participants
[nested] [flat]

* pglister: don't say "subject is empty" for non-empty subjects
@ 2026-07-03 13:30 Álvaro Herrera <[email protected]>
  2026-07-03 13:43 ` Re: pglister: don't say "subject is empty" for non-empty subjects Dave Page <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Álvaro Herrera @ 2026-07-03 13:30 UTC (permalink / raw)
  To: w^3 <[email protected]>

Hi

We just got a complaint about a moderation message being unclear -- the
moderation interface says that the subject is empty when it isn't.  I
propose to reword the message.  Also, the constant name was already
wrong, but now it is even more obvious how wrong it is, so update it.

Proposed patch attached.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"La fuerza no está en los medios físicos
sino que reside en una voluntad indomable" (Gandhi)


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: pglister: don't say "subject is empty" for non-empty subjects
  2026-07-03 13:30 pglister: don't say "subject is empty" for non-empty subjects Álvaro Herrera <[email protected]>
@ 2026-07-03 13:43 ` Dave Page <[email protected]>
  2026-07-08 09:45   ` Re: pglister: don't say "subject is empty" for non-empty subjects Magnus Hagander <[email protected]>
  0 siblings, 1 reply; 3+ messages in thread

From: Dave Page @ 2026-07-03 13:43 UTC (permalink / raw)
  To: Álvaro Herrera <[email protected]>; +Cc: w^3 <[email protected]>

On Fri, 3 Jul 2026 at 14:30, Álvaro Herrera <[email protected]> wrote:

> Hi
>
> We just got a complaint about a moderation message being unclear -- the
> moderation interface says that the subject is empty when it isn't.  I
> propose to reword the message.  Also, the constant name was already
> wrong, but now it is even more obvious how wrong it is, so update it.
>
> Proposed patch attached.
>

Looks good to me - thanks!

-- 
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: pglister: don't say "subject is empty" for non-empty subjects
  2026-07-03 13:30 pglister: don't say "subject is empty" for non-empty subjects Álvaro Herrera <[email protected]>
  2026-07-03 13:43 ` Re: pglister: don't say "subject is empty" for non-empty subjects Dave Page <[email protected]>
@ 2026-07-08 09:45   ` Magnus Hagander <[email protected]>
  0 siblings, 0 replies; 3+ messages in thread

From: Magnus Hagander @ 2026-07-08 09:45 UTC (permalink / raw)
  To: Dave Page <[email protected]>; +Cc: Álvaro Herrera <[email protected]>; w^3 <[email protected]>

On Fri, 3 Jul 2026 at 15:43, Dave Page <[email protected]> wrote:

>
>
> On Fri, 3 Jul 2026 at 14:30, Álvaro Herrera <[email protected]> wrote:
>
>> Hi
>>
>> We just got a complaint about a moderation message being unclear -- the
>> moderation interface says that the subject is empty when it isn't.  I
>> propose to reword the message.  Also, the constant name was already
>> wrong, but now it is even more obvious how wrong it is, so update it.
>>
>> Proposed patch attached.
>>
>
> Looks good to me - thanks!
>
>

Looks reasonable. Pushed. Thanks!

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/;
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;


^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2026-07-08 09:45 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-07-03 13:30 pglister: don't say "subject is empty" for non-empty subjects Álvaro Herrera <[email protected]>
2026-07-03 13:43 ` Dave Page <[email protected]>
2026-07-08 09:45   ` Magnus Hagander <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox