agora inbox for pgsql-www@postgresql.org  
help / color / mirror / Atom feed
From: Christoph Berg <myon@debian.org>
To: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-www@lists.postgresql.org, Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: PostgreSQL Contributors <contributors@lists.postgresql.org>
Subject: Re: Introduce contributor badges
Date: Wed, 29 Jul 2026 14:51:36 +0200
Message-ID: <amn3WJa9Z7-ApNx_@msg.df7cb.de> (raw)
In-Reply-To: <afCwxreG0Ad882WL@msg.df7cb.de>
References: <CABUevExk=h0gLboP8D0XQk9kv-HSDkM30tv4zoHZvuhznXfUvg@mail.gmail.com>
	<aW5bm-4Dk6f-CvCT@msg.df7cb.de>
	<7DF542FC-E797-4050-B204-7755AEFDFF4A@yandex-team.ru>
	<aW9w4VAkIlIcmUeb@msg.df7cb.de>
	<aW96qykzafRjYyiu@msg.df7cb.de>
	<aXNKEnrMjM8QRyOX@msg.df7cb.de>
	<aXPGENnZTVhrnPTp@msg.df7cb.de>
	<aeueOZhbzhNtQFZF@msg.df7cb.de>
	<CABUevEzgNKBdKySvuzn9diZMeEyyCNM6EWC9JZpse_AZPgk1hQ@mail.gmail.com>
	<afCwxreG0Ad882WL@msg.df7cb.de>

Re: To Magnus Hagander
> I'm attaching that as a separate commit for better review. It would
> get squashed before committing, of course.
> 
> I believe that addresses the concerns from Brussels, or was there
> anything else?

To finally pick this up again (my fault for slacking): We've talked in
Vancouver and the remaining concern was that the image URLs were
user-configurable free text.

I have now cherry-picked the ImageBinaryField feature from pgeu-system
and image upload is now fully self-contained in the pgweb database.

Attached is v7 of the patch, before squashing:

v7-0001-Cherry-pick-ImageBinaryField-and-related-from-pge.patch
v7-0002-Rewind-uploaded-file-before-reading-in-ImageBinar.patch
  ImageBinaryField and a follow-up fix in there that I'll submit to
  pgeu-system after review

v7-0003-Introduce-contributor-badges.patch
  The original patch
v7-0004-Add-dates-on-badgeholders-so-people-can-be-retire.patch
  The retirement feature
v7-0005-Use-ImageBinaryField-for-the-badges.patch
  The switch to ImageBinaryField

v8 is the same after squashing 0003..0005. (With a better commit
message.)

v7-0001-Cherry-pick-ImageBinaryField-and-related-from-pge.patch
v7-0002-Rewind-uploaded-file-before-reading-in-ImageBinar.patch
v8-0003-Introduce-contributor-badges.patch

Christoph

Attachments:

  [text/x-diff] v7-0001-Cherry-pick-ImageBinaryField-and-related-from-pge.patch (0B, ../amn3WJa9Z7-ApNx_@msg.df7cb.de/2-v7-0001-Cherry-pick-ImageBinaryField-and-related-from-pge.patch)
  download

view thread (21+ messages)  latest in thread

Message-ID: <amn3WJa9Z7-ApNx_@msg.df7cb.de>
Permalink:  ../amn3WJa9Z7-ApNx_@msg.df7cb.de/
Also on:    postgresql.org/message-id/amn3WJa9Z7-ApNx_@msg.df7cb.de

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-www@postgresql.org
  Cc: myon@debian.org, magnus@hagander.net, x4mmm@yandex-team.ru, melanieplageman@gmail.com, contributors@lists.postgresql.org
  Subject: Re: Introduce contributor badges
  In-Reply-To: <amn3WJa9Z7-ApNx_@msg.df7cb.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox