Re: Introduce contributor badges

agora inbox for pgsql-www@postgresql.org  
help / color / mirror / Atom feed

From: Christoph Berg <myon@debian.org>
To: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-www@lists.postgresql.org, Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: PostgreSQL Contributors <contributors@lists.postgresql.org>
Subject: Re: Introduce contributor badges
Date: Fri, 25 Sep 2026 17:46:20 +0200
Message-ID: <araXTIuHpGxWIWHf@msg.df7cb.de> (raw)
In-Reply-To: <amn3WJa9Z7-ApNx_@msg.df7cb.de>
References: <aW5bm-4Dk6f-CvCT@msg.df7cb.de>
	<7DF542FC-E797-4050-B204-7755AEFDFF4A@yandex-team.ru>
	<aW9w4VAkIlIcmUeb@msg.df7cb.de>
	<aW96qykzafRjYyiu@msg.df7cb.de>
	<aXNKEnrMjM8QRyOX@msg.df7cb.de>
	<aXPGENnZTVhrnPTp@msg.df7cb.de>
	<aeueOZhbzhNtQFZF@msg.df7cb.de>
	<CABUevEzgNKBdKySvuzn9diZMeEyyCNM6EWC9JZpse_AZPgk1hQ@mail.gmail.com>
	<afCwxreG0Ad882WL@msg.df7cb.de>
	<amn3WJa9Z7-ApNx_@msg.df7cb.de>

Hi,

thanks Magnus for the in-depth patch review during the Lowlands PGday.

I'm attaching v11.

> I also note that patch 2 doesn't have the changes that went into pgeu. We should probably merge patches 1 and 2 as a single "import frm pgeu-system" and just grab the current head there, since it has progressed since. I can do that when the time comes.

I merged the two patches into 0001, but I don't see any new pgeu
changes that would affect this. What am I missing?

> Is there a reason that OneToOne change to the User model can't be done as a separate thing before this? In the interest of keeping things into easily reviewable pieces?

This is 0002 now.

> nitpick is you can save a bunch of html padding by not adding badges-cell to each cell and instead just use a css rule anchored in badges-grid I think, similar to how you're already doing it for the img just one step higher.
> and since some of these pages can get large quickly...

Done. Please check if I understood that correctly and did the correct
change, though :)

> Patch also contains 73aab7456 which has already been applied... So needs some rebasing.

That should have resolved itself.

> Queries for badges should avoid reading the imagedata in every query that doesn't need it. Using defer — probably by defining a default defer.

Fixed.

> UserModelMultipleChoiceField seems to be a bad name for something that checks Contributors, not Users?

Changed.

> Purging definitely needs to be more specific, we don't want to purge everything including all the images when a contributor is edited.

Also done. Since purges can be limited to specific pages by '...$', I
did not move any URLs around.

> (sprite discussion, will do that one in person )

I took a mental note of the problem - we'll revisit that once we have
too many badges (or better a bit before that).

> For the "list all people" view if we don't want to do pagination at this time can we at least put a temporary ceiling on it so we don't generate an absolutely ginormous page. as in only show the first 500 or something. It'll take time to reach that point, but it will get increasingly painful on the way there.

There's limits now, but I went with 2000. There are 1700 distinct
names mentioned in the release notes since PG10 and I think we would
hit 500 rather quickly.

Christoph

Attachments:

  [application/gzip] v11-0001-Cherry-pick-ImageBinaryField-and-related-from-pg.patch.gz (3.6K, ../araXTIuHpGxWIWHf@msg.df7cb.de/2-v11-0001-Cherry-pick-ImageBinaryField-and-related-from-pg.patch.gz)
  download

  [application/gzip] v11-0002-Turn-Contributor.user-into-a-OneToOneField.patch.gz (1.3K, ../araXTIuHpGxWIWHf@msg.df7cb.de/3-v11-0002-Turn-Contributor.user-into-a-OneToOneField.patch.gz)
  download

  [application/gzip] v11-0003-Introduce-contributor-badges.patch.gz (11.9K, ../araXTIuHpGxWIWHf@msg.df7cb.de/4-v11-0003-Introduce-contributor-badges.patch.gz)
  download

  [application/gzip] v11-0004-Make-contributor-badges-discoverable.patch.gz (1.8K, ../araXTIuHpGxWIWHf@msg.df7cb.de/5-v11-0004-Make-contributor-badges-discoverable.patch.gz)
  download

view thread (21+ messages)

Message-ID: <araXTIuHpGxWIWHf@msg.df7cb.de>
Permalink:  ../araXTIuHpGxWIWHf@msg.df7cb.de/
Also on:    postgresql.org/message-id/araXTIuHpGxWIWHf@msg.df7cb.de

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-www@postgresql.org
  Cc: myon@debian.org, magnus@hagander.net, x4mmm@yandex-team.ru, melanieplageman@gmail.com, contributors@lists.postgresql.org
  Subject: Re: Introduce contributor badges
  In-Reply-To: <araXTIuHpGxWIWHf@msg.df7cb.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox