pg.ddx.io  pgsql-www@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Christoph Berg <myon@debian.org>
To: Dave Page <dpage@pgadmin.org>
To: Magnus Hagander <magnus@hagander.net>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-www@lists.postgresql.org, Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: PostgreSQL Contributors <contributors@lists.postgresql.org>
Subject: Re: Introduce contributor badges: image versioning?
Date: Fri, 16 Oct 2026 18:00:25 +0200
Message-ID: <atJKGa00GdsUheY0@msg.df7cb.de> (raw)
In-Reply-To: <CABUevEygPgYTb+rhWVEV6OdVqzdow6Q3RUPuyfsK=bqRrcZ+uw@mail.gmail.com> <CA+OCxoxgjHHbcpYH8GJD8JurM-b3eeYtzVE-VoVgev4xD1Q=Vw@mail.gmail.com>

Re: Dave Page
> That's fair, but items 1 to 3 still stand; the VCL limits how long the
> stale pages last, though:

Ack, I'll address these separately.

Re: Magnus Hagander
> Agreed, no need for URL versioning.

Thanks.

> > > - `badge_image` fetches the image and computes its MD5 before it checks
> > > `If-None-Match`; storing the hash would avoid both.
> >
> > badge_image is only reached on a Varnish miss, and on a miss we're
> > almost always about to serve the image anyway. Storing the hash only
> > helps the narrow (?) "Django itself receives a conditional request"
> > case.
> 
> No, on the vast majority of misses we'd be serving a 304 Found with no
> content. Every time an image expires in any of the caches it would send a
> conditional request.

Is that enough to warrant storing the MD5 in a separate column? The PG
xx Contributor images I have here are all between 20 and 40kB in size.
(I.e. is that the fix we want?)

> (I have not looked at the rest, so I reserve the right to further review)

There will be patches coming for the other points soon.

Christoph






Message-ID: <atJKGa00GdsUheY0@msg.df7cb.de>
Permalink:  ../atJKGa00GdsUheY0@msg.df7cb.de/
Also on:    postgresql.org/message-id/atJKGa00GdsUheY0@msg.df7cb.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-www@postgresql.org
  Cc: myon@debian.org, dpage@pgadmin.org, magnus@hagander.net, jkatz@postgresql.org, daniel@yesql.se, x4mmm@yandex-team.ru, melanieplageman@gmail.com, contributors@lists.postgresql.org
  Subject: Re: Introduce contributor badges: image versioning?
  In-Reply-To: <atJKGa00GdsUheY0@msg.df7cb.de>
  References: <atJKGa00GdsUheY0@msg.df7cb.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox