agora inbox for pljava-dev@postgresql.org  

help / color / mirror / Atom feed

Subject: [Pljava-dev] Patch for SQLOutput implementation
Date: Fri, 22 Sep 2006 18:07:45 +0200
Message-ID: <45140A51.8030605@logix-tt.com> (raw)
In-Reply-To: <4513F639.3000108@tada.se>
References: <4512F5E4.9060600@logix-tt.com>
	<45139C17.3050006@tada.se>
	<4513A107.4060809@logix-tt.com>
	<4513A3ED.3050401@tada.se>
	<4513E2C0.3050804@logix-tt.com>
	<4513E52B.5080108@tada.se>
	<4513F1A0.8020800@logix-tt.com>
	<4513F639.3000108@tada.se>

Hi,

Here's the patch attempt for the SQLOutput side.

First, it seems that the writeBytes() method was broken, it did write
nothing (not even the length count) for a zero-length array, which lead
to random garbage being read or worse on readBytes().

I also added some handle checks.

As I also adopted your coding style wr/t {}s, so I included the input
side again.

I've to quit now, my schedule is tight his afternoon, but I'll see what
I can do at the weekend and on Monday.

Regards,
Markus

-- 
Markus Schaber | Logical Tracking&Tracing International AG
Dipl. Inf.     | Software Development GIS

Fight against software patents in Europe! www.ffii.org
www.nosoftwarepatents.org
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: SQLIO.diff
URL: <http://lists.pgfoundry.org/pipermail/pljava-dev/attachments/20060922/d8a733ab/attachment.ksh;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
URL: <http://lists.pgfoundry.org/pipermail/pljava-dev/attachments/20060922/d8a733ab/attachment.bin;

view thread (3+ messages)  latest in thread

Message-ID: <45140A51.8030605@logix-tt.com>
Permalink:  ../45140A51.8030605@logix-tt.com/
Also on:    postgresql.org/message-id/45140A51.8030605@logix-tt.com

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pljava-dev@postgresql.org
  Subject: Re: [Pljava-dev] Patch for SQLOutput implementation
  In-Reply-To: <45140A51.8030605@logix-tt.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox