agora inbox for pljava-dev@postgresql.org
help / color / mirror / Atom feed[Pljava-dev] Patch for SQLOutput implementation
3+ messages / 0 participants
[nested] [flat]
* [Pljava-dev] Patch for SQLOutput implementation
@ 2006-09-22 16:07
2006-09-22 20:56 ` [Pljava-dev] Patch for SQLOutput implementation
0 siblings, 1 reply; 3+ messages in thread
From: @ 2006-09-22 16:07 UTC (permalink / raw)
Hi,
Here's the patch attempt for the SQLOutput side.
First, it seems that the writeBytes() method was broken, it did write
nothing (not even the length count) for a zero-length array, which lead
to random garbage being read or worse on readBytes().
I also added some handle checks.
As I also adopted your coding style wr/t {}s, so I included the input
side again.
I've to quit now, my schedule is tight his afternoon, but I'll see what
I can do at the weekend and on Monday.
Regards,
Markus
--
Markus Schaber | Logical Tracking&Tracing International AG
Dipl. Inf. | Software Development GIS
Fight against software patents in Europe! www.ffii.org
www.nosoftwarepatents.org
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: SQLIO.diff
URL: <http://lists.pgfoundry.org/pipermail/pljava-dev/attachments/20060922/d8a733ab/attachment.ksh;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
URL: <http://lists.pgfoundry.org/pipermail/pljava-dev/attachments/20060922/d8a733ab/attachment.bin;
^ permalink raw reply [nested|flat] 3+ messages in thread
* [Pljava-dev] Patch for SQLOutput implementation
2006-09-22 16:07 [Pljava-dev] Patch for SQLOutput implementation
@ 2006-09-22 20:56 `
2006-09-23 10:36 ` [Pljava-dev] Patch for SQLOutput implementation
0 siblings, 1 reply; 3+ messages in thread
From: @ 2006-09-22 20:56 UTC (permalink / raw)
Hi Markus,
I looked at it and it looks fine. If you want to do some more work on
it, then I'll wait until Monday applying it. Are you planning to look at
the C-code as well? You seem to know how to keep your bits in order :-)
Regards,
Thomas Hallgren
Markus Schaber wrote:
> Hi,
>
> Here's the patch attempt for the SQLOutput side.
>
> First, it seems that the writeBytes() method was broken, it did write
> nothing (not even the length count) for a zero-length array, which lead
> to random garbage being read or worse on readBytes().
>
> I also added some handle checks.
>
> As I also adopted your coding style wr/t {}s, so I included the input
> side again.
>
> I've to quit now, my schedule is tight his afternoon, but I'll see what
> I can do at the weekend and on Monday.
>
> Regards,
> Markus
>
>
^ permalink raw reply [nested|flat] 3+ messages in thread
* [Pljava-dev] Patch for SQLOutput implementation
2006-09-22 16:07 [Pljava-dev] Patch for SQLOutput implementation
2006-09-22 20:56 ` [Pljava-dev] Patch for SQLOutput implementation
@ 2006-09-23 10:36 `
0 siblings, 0 replies; 3+ messages in thread
From: @ 2006-09-23 10:36 UTC (permalink / raw)
Hi, Thomas,
Thomas Hallgren wrote:
> I looked at it and it looks fine. If you want to do some more work on
> it, then I'll wait until Monday applying it. Are you planning to look at
> the C-code as well? You seem to know how to keep your bits in order :-)
I'd like to build and test it, if you don't have time to do so. At
least, I want to make sure to not have confused big and little endian,
as I tend to do from time to time. :-)
I'm definitely planning to look into the C code. However, I might need
some time to understand the "inner workings", and there's some higher
priority work on my table, so it might take a few days.
Thanks,
Markus
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2006-09-23 10:36 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2006-09-22 16:07 [Pljava-dev] Patch for SQLOutput implementation
2006-09-22 20:56 `
2006-09-23 10:36 `
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox