public inbox for [email protected]
help / color / mirror / Atom feedFrom: Kartik Ohri <[email protected]>
To: Chapman Flack <[email protected]>
Cc: [email protected]
Subject: Re: PL/Java new build plugin
Date: Wed, 15 Jul 2020 09:00:09 +0530
Message-ID: <CAASLQ4P+zUuWvpXb9U_CDY384P=sSNP0ATYCb0nf1d=sbt5TjA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
<CAASLQ4PEe0_1dE-iOBv27fX1SUH0=ewDm=6w9chHLjWSAkeNgQ@mail.gmail.com>
<[email protected]>
<CAASLQ4MLFd6zhoh+sWWz+iu4d8+H2ML+y=kL990k7H=kk74pvA@mail.gmail.com>
<[email protected]>
<CAASLQ4Ms0QGf-Qh966HrsoaWzwf1SYHZ0WmZHApQePbcyPejCQ@mail.gmail.com>
<CAASLQ4NFHYH1pfGJtCZDfdcxf_ZzLA+X+ko86vpyRDKVYr489Q@mail.gmail.com>
<[email protected]>
<CAASLQ4PDcaAJ8fEwXXFW6XPakc7GCNVgPNGCxA8KYMzPDZw4+w@mail.gmail.com>
<[email protected]>
<CAASLQ4OuFQCiSMeypQtfRaAvj-4H-EAgszLwdAo6Tc1zS9B66g@mail.gmail.com>
<[email protected]>
<CAASLQ4PSizkzBKyyfkp9ccJ1qDPLRLu6g2bo9cN-XuTzGQFGfQ@mail.gmail.com>
<CAASLQ4P9zGxHda=HAGJ2eAa-oMmJtnPm=4a14mj4P-QpfFsYxg@mail.gmail.com>
<[email protected]>
<CAASLQ4NmornyOW8n-qyneLpDVPgV0Js=+=Eys6bw3Y-ZiVbVjA@mail.gmail.com>
<CAASLQ4OYvTQL7ssG4=QyEqhaB71=AM-svBUYj3uRdWXWoQgBPw@mail.gmail.com>
<[email protected]>
>
> Thanks! Looks like I have fixed that with a42c416. Turned out to be
> Windows line endings, and it means I gave you bad advice with regard to
> getPgConfigProperty [1] after all. Even though pg_config explicitly writes
> a single \n character on every platform, Windows (probably the C library
> really) still changes it to \r\n before it arrives on the pipe. So just
> removing one character won't always work. It has to be line.separator
> (that, or an explicit test for Windows). Sorry for leading you astray.
>
Thanks for informing this. I'll check the plugin with this fix to see if
this now works on Windows.
Now the only appveyor "errors" I'm seeing seem to be a result of appveyor
> thinking anything written to stderr is a problem. So running the installer
> jar to install the files produces a wall of red every time, because it
> prints the installed file names to stderr. And then on Java 9 there is
> still one JNI reference warning, but that's being treated as a failure.
>
> The first of those problems can surely be fixed with a 2>&1 on the
> command running the installer jar (or whatever the equivalent Windows
> syntax is for "merge your stderr into stdout").
>
> The second looks a little trickier, as you're probably checking for
> warning output from install_jar(...examples...), which really does
> indicate trouble, but the WARNING: JNI local refs: does not.
There is another error as well on PG 10
https://ci.appveyor.com/project/amCap1712/pljava/builds/34099990/job/bgpqdy5qjkik2ya9,
one of the tests fails. This has been the case since I first added this
configuration.
I don't understand what the PG=9 configuration even is. The PG version
> numbering change happened in 10, so "9" could mean any of seven different
> major versions, and I can't even see from the log which of those the
> run is trying to use. I think that could be the reason it's failing too,
> because it's trying to run "\Program Files\PostgreSQL\9\bin\pg_ctl" and
> there is no such thing with just "9" as the version.
>
I had suspected the same but didn't test it due to some reason I seem to
have forgotten but I will do that now.
view thread (132+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: PL/Java new build plugin
In-Reply-To: <CAASLQ4P+zUuWvpXb9U_CDY384P=sSNP0ATYCb0nf1d=sbt5TjA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox