public inbox for [email protected]  

help / color / mirror / Atom feed
From: Kartik Ohri <[email protected]>
To: Chapman Flack <[email protected]>
Cc: [email protected]
Subject: ScriptingMojo Custom Packaging
Date: Thu, 20 Aug 2020 22:30:04 +0530
Message-ID: <CAASLQ4P-VeZK46t=PvYw0F05AxqG5i80GTwg2LMhCnjC9WzoZA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAASLQ4Mva7dAXiS_c9OLhV4VzNHF=XNKJosuS5gtZTB6b4TW1Q@mail.gmail.com>
	<[email protected]>
	<CAASLQ4O5Wfk1hH6nO_1PDUbRcpUywvTxq7e99aCJ4RPeMmssAw@mail.gmail.com>
	<[email protected]>
	<CAASLQ4M0uvNj0EyMWWNsizT1KtnWx0WFbk89ud9EVHZbu12LMg@mail.gmail.com>
	<[email protected]>
	<CAASLQ4M3pR+ZL+uPvcQ-dAEL2KdH_PGe-_pBhsjvOgN5qvf+aA@mail.gmail.com>
	<[email protected]>
	<CAASLQ4NU9v=nuLDG-LneC68LuqKRXchFckU7mCZT9YQDNKqwvg@mail.gmail.com>
	<[email protected]>
	<CAASLQ4NgH+tXbdUSA8xDh2ct3gAS3xa8V7=E0gcYd+d=m8kujw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAASLQ4PEgo5Nj0EVsOfGoB96dQFXfFYxrrB0rS1wdad7x_E5fA@mail.gmail.com>
	<CAASLQ4OowXOmnbbbT0Wh1ZkB4h=6JQfC61ojmN07EYnO0QCcow@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

>
> I think my inclination would be to supply such a file with the role-hint
> of 'pgxs', and mapping every phase to empty. Then what the plugin does will
> be completely determined by what script <execution>s you configure, and
> what phases you put them in.
>
> Then the packaging type of pljava-so could be pgxs, and you would simply
> specify the <phase> for each <execution> in the pom (as is already done
> for the set-properties execution). So, what the plugin does will be
> completely determined by what script <execution>s you configure, and
> what phases you put them in.
>
> I think I would also change ScriptingMojo to declare COMPILE as its
> default phase. The set-properties execution would still specify
> initialize as its phase, as it does now, but I think the usual
> behavior is if a phase isn't specified, it will be compile.
>

I have made these changes
https://github.com/amCap1712/pljava/commit/14045b10ca1428fc2914440a2220871ac7c9921b
but the build process fails with this error
https://gist.github.com/amCap1712/ad9fe94fd9fb6f4ff4f26913a464c226. I
checked the jar files manually to make sure the file is present in it. The
pgxs jar is also listed in the lists of url classpaths.


view thread (78+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: ScriptingMojo Custom Packaging
  In-Reply-To: <CAASLQ4P-VeZK46t=PvYw0F05AxqG5i80GTwg2LMhCnjC9WzoZA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox