postgresql-interfaces/psqlodbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feed[postgresql-interfaces/psqlodbc] issue #122: 17.00.0005 release showing version number of 17.00.0004
5+ messages / 3 participants
[nested] [flat]
* [postgresql-interfaces/psqlodbc] issue #122: 17.00.0005 release showing version number of 17.00.0004
@ 2025-05-30 10:42 "simon-kempster (@simon-kempster)" <[email protected]>
0 siblings, 0 replies; 5+ messages in thread
From: simon-kempster (@simon-kempster) @ 2025-05-30 10:42 UTC (permalink / raw)
To: postgresql-interfaces/psqlodbc <[email protected]>
For the latest release, in Windows, the Product Version on the DLLs is showing the version number of 17.00.0004, when it should be 17.00.0005.
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [postgresql-interfaces/psqlodbc] issue #122: 17.00.0005 release showing version number of 17.00.0004
@ 2025-06-04 15:15 ` "davecramer (@davecramer)" <[email protected]>
3 siblings, 0 replies; 5+ messages in thread
From: davecramer (@davecramer) @ 2025-06-04 15:15 UTC (permalink / raw)
To: postgresql-interfaces/psqlodbc <[email protected]>
Well, that's not good. Thanks for the report
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [postgresql-interfaces/psqlodbc] issue #122: 17.00.0005 release showing version number of 17.00.0004
@ 2025-06-05 09:36 ` "davecramer (@davecramer)" <[email protected]>
3 siblings, 0 replies; 5+ messages in thread
From: davecramer (@davecramer) @ 2025-06-05 09:36 UTC (permalink / raw)
To: postgresql-interfaces/psqlodbc <[email protected]>
@chrullrich where does the version number of the dll get set in the WIX code ?
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [postgresql-interfaces/psqlodbc] issue #122: 17.00.0005 release showing version number of 17.00.0004
@ 2025-06-05 10:03 ` "chrullrich (@chrullrich)" <[email protected]>
3 siblings, 0 replies; 5+ messages in thread
From: chrullrich (@chrullrich) @ 2025-06-05 10:03 UTC (permalink / raw)
To: postgresql-interfaces/psqlodbc <[email protected]>
It doesn't. The files are passed through unmodified, so the version resources have to be correct in them. WiX extracts the version number for its own purposes, too, but the way the installers work this does not prevent it from replacing the files with the new versions.
The display form of the version number did not update because 151feaa8080181a5ae0f9bc4d2211e5bd69e5539 replaced the macro POSTGRES_RESOURCE_VERSION in psqlodbc.rc with a literal "17.00.0004" in four places.
As to why the internal versions did not change even though psqlodbc.rc includes version.h, I currently have no idea. There may be something in the build procedure that did not get updated; version.h mentions that the versions may be overridden by command line arguments from psqlodbc.vcxproj, and it looks like that file uses the arguments. I have not yet found out where it takes their values from.
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [postgresql-interfaces/psqlodbc] issue #122: 17.00.0005 release showing version number of 17.00.0004
@ 2025-06-05 11:25 ` "chrullrich (@chrullrich)" <[email protected]>
3 siblings, 0 replies; 5+ messages in thread
From: chrullrich (@chrullrich) @ 2025-06-05 11:25 UTC (permalink / raw)
To: postgresql-interfaces/psqlodbc <[email protected]>
> The display form of the version number did not update because [151feaa](https://github.com/postgresql-interfaces/psqlodbc/commit/151feaa8080181a5ae0f9bc4d2211e5bd69e5539) replaced the macro POSTGRES_RESOURCE_VERSION in psqlodbc.rc with a literal "17.00.0004" in four places.
The same happened to PG_DRVFILE_VERSION for the internal version numbers. It was changed to literal 17,0,0,4 in all four places it appears.
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2025-06-05 11:25 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-05-30 10:42 [postgresql-interfaces/psqlodbc] issue #122: 17.00.0005 release showing version number of 17.00.0004 "simon-kempster (@simon-kempster)" <[email protected]>
2025-06-04 15:15 ` "davecramer (@davecramer)" <[email protected]>
2025-06-05 09:36 ` "davecramer (@davecramer)" <[email protected]>
2025-06-05 10:03 ` "chrullrich (@chrullrich)" <[email protected]>
2025-06-05 11:25 ` "chrullrich (@chrullrich)" <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox