postgresql-interfaces/psqlodbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

From: omeuid (@omeuid) <[email protected]>
To: postgresql-interfaces/psqlodbc <[email protected]>
Subject: [postgresql-interfaces/psqlodbc] issue #29: Possible issue in find_default_msbuild_path function from MSProgram-Get.psm1
Date: Thu, 06 Jun 2024 16:35:19 +0000
Message-ID: <[email protected]> (raw)

I understand that the find_default_msbuild_path function from the MSProgram-Get.psm1 script could be wrong.

I would change the condition from the following IF statement:

```
    if ($env:PROCESSOR_ARCHITECTURE -eq "x86" -or $env:PROCESSOR_ARCHITECTURE -eq "ARM64") {
        $pgmfs = "$env:ProgramFiles"
    } else {
        $pgmfs = "${env:ProgramFiles(x86)}"
    }
```

As the objective seems to be the correct selection of the program files directory based on the processor architecture I would change the first line with the following one:
```
if ($env:PROCESSOR_ARCHITECTURE -eq "x64" -or $env:PROCESSOR_ARCHITECTURE -eq "ARM64") {
```

Am I missing something or should that change be done?

Regards,
Carlos

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://postgresql-interfaces/psqlodbc
  Cc: [email protected], [email protected]
  Subject: Re: [postgresql-interfaces/psqlodbc] issue #29: Possible issue in find_default_msbuild_path function from MSProgram-Get.psm1
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox