postgresql-interfaces/psqlodbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

[postgresql-interfaces/psqlodbc] issue #29: Possible issue in find_default_msbuild_path function from MSProgram-Get.psm1
3+ messages / 2 participants
[nested] [flat]

* [postgresql-interfaces/psqlodbc] issue #29: Possible issue in find_default_msbuild_path function from MSProgram-Get.psm1
@ 2024-06-06 16:35  "omeuid (@omeuid)" <[email protected]>
  0 siblings, 0 replies; 3+ messages in thread

From: omeuid (@omeuid) @ 2024-06-06 16:35 UTC (permalink / raw)
  To: postgresql-interfaces/psqlodbc <[email protected]>

I understand that the find_default_msbuild_path function from the MSProgram-Get.psm1 script could be wrong.

I would change the condition from the following IF statement:

```
    if ($env:PROCESSOR_ARCHITECTURE -eq "x86" -or $env:PROCESSOR_ARCHITECTURE -eq "ARM64") {
        $pgmfs = "$env:ProgramFiles"
    } else {
        $pgmfs = "${env:ProgramFiles(x86)}"
    }
```

As the objective seems to be the correct selection of the program files directory based on the processor architecture I would change the first line with the following one:
```
if ($env:PROCESSOR_ARCHITECTURE -eq "x64" -or $env:PROCESSOR_ARCHITECTURE -eq "ARM64") {
```

Am I missing something or should that change be done?

Regards,
Carlos

^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: [postgresql-interfaces/psqlodbc] issue #29: Possible issue in find_default_msbuild_path function from MSProgram-Get.psm1
@ 2024-06-06 23:45  "apgrucza (@apgrucza)" <[email protected]>
  1 sibling, 0 replies; 3+ messages in thread

From: apgrucza (@apgrucza) @ 2024-06-06 23:45 UTC (permalink / raw)
  To: postgresql-interfaces/psqlodbc <[email protected]>

@omeuid the code shown above is out of date. The problem you are experiencing was likely fixed in #9.

^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: [postgresql-interfaces/psqlodbc] issue #29: Possible issue in find_default_msbuild_path function from MSProgram-Get.psm1
@ 2024-06-07 07:47  "omeuid (@omeuid)" <[email protected]>
  1 sibling, 0 replies; 3+ messages in thread

From: omeuid (@omeuid) @ 2024-06-07 07:47 UTC (permalink / raw)
  To: postgresql-interfaces/psqlodbc <[email protected]>

Hi,

Thanks for the quick response. I was building the current release, so I was in tag `REL-16_00_0005` where the problem is reproduced. 

I will close this ticket.



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

end of thread, other threads:[~2024-06-07 07:47 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-06-06 16:35 [postgresql-interfaces/psqlodbc] issue #29: Possible issue in find_default_msbuild_path function from MSProgram-Get.psm1 "omeuid (@omeuid)" <[email protected]>
2024-06-06 23:45 ` "apgrucza (@apgrucza)" <[email protected]>
2024-06-07 07:47 ` "omeuid (@omeuid)" <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox