public inbox for [email protected]
help / color / mirror / Atom feedFrom: Karsten Hilbert <[email protected]>
To: [email protected]
To: [email protected]
Subject: Re: Designing a better connection pool for psycopg3
Date: Mon, 18 Jan 2021 15:44:15 +0100
Message-ID: <YAWevy8n7/[email protected]> (raw)
In-Reply-To: <CABUevEy6iYxAgH6qFJN5OqiPFkv1O1JU90jbHna2xDXqFDLFHg@mail.gmail.com>
References: <CA+mi_8aZQXzB8Kr4V0nps3aMQ74N72uWC=pZF0P1H7AW4GLasA@mail.gmail.com>
<[email protected]>
<CA+mi_8a-0Wx62eziOBwp-=ryBynsqrgx4AcBGW5+pSr3vZXjHg@mail.gmail.com>
<CABUevExMQQB3=xShPie+XR04kctiR8-P_BEUz1BmCyDLhU_yhg@mail.gmail.com>
<CA+mi_8a83=Qy-Ym+_X4tLPcD1YHVVVYF2Ki5jeHU4eDz_etG5w@mail.gmail.com>
<CABUevEy6iYxAgH6qFJN5OqiPFkv1O1JU90jbHna2xDXqFDLFHg@mail.gmail.com>
Am Mon, Jan 18, 2021 at 03:39:20PM +0100 schrieb Magnus Hagander:
> > Anyway I appreciate that the default of terminating a program is
> > probably too aggressive. So I would remove the `terminate()` function
> > and base implementation and leave a `connection_failed()` handler,
> > with a default no-op implementation, which people preferring their
> > program to terminate can subclass (with `sys.exit(1)` or whatever
> > termination strategy they find useful).
>
> That would definitely work. A plugin-point for this would be very useful.
>
> And if you want to avoid the "timeout based error" in the client,
> adding a flag to the pool saying "this pool is currently unhealthy" in
> this case would work, and then whenever someone tries to get a
> connection out of this pool it can throw an exception immediately
> instead of waiting for a timeout to happen.
+1 :-)
Karsten
--
GPG 40BE 5B0E C98E 1713 AFA6 5BC0 3BEA AC80 7D4F C89B
view thread (19+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Designing a better connection pool for psycopg3
In-Reply-To: <YAWevy8n7/[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox