public inbox for [email protected]
help / color / mirror / Atom feedFrom: Federico Di Gregorio <[email protected]>
To: [email protected]
Subject: Re: Integration of Psycopg with XTA
Date: Wed, 10 Oct 2018 23:19:45 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
On 10/10/2018 11:10 PM, Christian Ferrari wrote:
> By the way, PyMySQL/mysqlclient-python project
> <https://github.com/PyMySQL/mysqlclient-python; asked me to rename the
> method from "get_native_conn()" to "_get_native_conn()".
>
> I'm not a "naming addicted person", but from the developer point of
> view, using two different methods would be for sure not appreciated...
>
> xar1 = PostgresqlXaResource(rm1.get_native_connection(), "PostgreSQL",
> "dbname=testdb")
> xar2 = MysqlXaResource(rm2._get_native_connection(), "MySQL",
> "localhost,0,lixa,,lixa")
>
> If you don't mind, I kindly ask you to wait a couple of days: I hope to
> close the pull request
> https://github.com/PyMySQL/mysqlclient-python/pull/269 shortly...
I think that _if_ this should go cross-database a method without the
underscore is better. The underscore usually means private and that's
good as long as it is just that. An informal "standard" method name
should not have the "_" in it.
federico
--
Federico Di Gregorio [email protected]
DNDG srl http://dndg.it
Gli esseri umani, a volte, sono destinati, per il solo fatto di
esistere, a fare del male a qualcuno. -- Haruki Murakami
view thread (22+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Integration of Psycopg with XTA
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox