pg.ddx.io pgadmin-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedPatch to support SSL certificate connections
20+ messages / 4 participants
[nested] [flat]
* Patch to support SSL certificate connections
@ 2011-01-18 23:35 Guillaume Lelarge <guillaume@lelarge.info>
0 siblings, 1 reply; 20+ messages in thread
From: Guillaume Lelarge @ 2011-01-18 23:35 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
This patch adds support to specify SSL certificate files and to connect
according to those.
It's pretty straightforward: four file pickers to handle on dlgServer,
and changes in the connection code to add those parameters in the
connection string.
Comments?
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
Attachments:
0001-Support-for-SSL-certificate-files.patch (text/x-diff, 0B) download
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-20 22:08 Guillaume Lelarge <guillaume@lelarge.info>
parent: Guillaume Lelarge <guillaume@lelarge.info>
0 siblings, 2 replies; 20+ messages in thread
From: Guillaume Lelarge @ 2011-01-20 22:08 UTC (permalink / raw)
To: pgadmin-hackers
Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
> Hi,
>
> This patch adds support to specify SSL certificate files and to connect
> according to those.
>
> It's pretty straightforward: four file pickers to handle on dlgServer,
> and changes in the connection code to add those parameters in the
> connection string.
>
A screenshot attached so that you can see the UI without building pgAdmin :)
Comments?
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
Attachments:
sslinfo.png (image/png, 37.2K) download
view image
* Re: Patch to support SSL certificate connections
@ 2011-01-21 09:15 Dave Page <dpage@pgadmin.org>
parent: Guillaume Lelarge <guillaume@lelarge.info>
1 sibling, 1 reply; 20+ messages in thread
From: Dave Page @ 2011-01-21 09:15 UTC (permalink / raw)
To: Guillaume Lelarge <guillaume@lelarge.info>; +Cc: pgadmin-hackers
On Thu, Jan 20, 2011 at 10:08 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
>> Hi,
>>
>> This patch adds support to specify SSL certificate files and to connect
>> according to those.
>>
>> It's pretty straightforward: four file pickers to handle on dlgServer,
>> and changes in the connection code to add those parameters in the
>> connection string.
>>
>
> A screenshot attached so that you can see the UI without building pgAdmin :)
I think the SSL tab should come before Advanced (I think Advanced
should always be last, except where there's a SQL tab).
Also, what's with the inconsistent text/artwork on the buttons?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-21 09:17 Magnus Hagander <magnus@hagander.net>
parent: Guillaume Lelarge <guillaume@lelarge.info>
1 sibling, 1 reply; 20+ messages in thread
From: Magnus Hagander @ 2011-01-21 09:17 UTC (permalink / raw)
To: Guillaume Lelarge <guillaume@lelarge.info>; +Cc: pgadmin-hackers
On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge <guillaume@lelarge.info> wrote:
> Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
>> Hi,
>>
>> This patch adds support to specify SSL certificate files and to connect
>> according to those.
>>
>> It's pretty straightforward: four file pickers to handle on dlgServer,
>> and changes in the connection code to add those parameters in the
>> connection string.
>>
>
> A screenshot attached so that you can see the UI without building pgAdmin :)
>
> Comments?
I would move root cert up before the others. Also CRL.
Root cert and CRL are about validating the *server* certificate. Key
and cert file are about SSL authentication of the *client* (thus
*client* certificates). They should definitely be in that order -
perhaps even grouped with a headline?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-22 00:33 Guillaume Lelarge <guillaume@lelarge.info>
parent: Dave Page <dpage@pgadmin.org>
0 siblings, 1 reply; 20+ messages in thread
From: Guillaume Lelarge @ 2011-01-22 00:33 UTC (permalink / raw)
To: Dave Page <dpage@pgadmin.org>; +Cc: pgadmin-hackers
Le 21/01/2011 10:15, Dave Page a écrit :
> On Thu, Jan 20, 2011 at 10:08 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
>>> Hi,
>>>
>>> This patch adds support to specify SSL certificate files and to connect
>>> according to those.
>>>
>>> It's pretty straightforward: four file pickers to handle on dlgServer,
>>> and changes in the connection code to add those parameters in the
>>> connection string.
>>>
>>
>> A screenshot attached so that you can see the UI without building pgAdmin :)
>
> I think the SSL tab should come before Advanced (I think Advanced
> should always be last, except where there's a SQL tab).
>
Done.
> Also, what's with the inconsistent text/artwork on the buttons?
>
What do you mean?
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-22 00:34 Guillaume Lelarge <guillaume@lelarge.info>
parent: Magnus Hagander <magnus@hagander.net>
0 siblings, 1 reply; 20+ messages in thread
From: Guillaume Lelarge @ 2011-01-22 00:34 UTC (permalink / raw)
To: Magnus Hagander <magnus@hagander.net>; +Cc: pgadmin-hackers
Le 21/01/2011 10:17, Magnus Hagander a écrit :
> On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>> Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
>>> Hi,
>>>
>>> This patch adds support to specify SSL certificate files and to connect
>>> according to those.
>>>
>>> It's pretty straightforward: four file pickers to handle on dlgServer,
>>> and changes in the connection code to add those parameters in the
>>> connection string.
>>>
>>
>> A screenshot attached so that you can see the UI without building pgAdmin :)
>>
>> Comments?
>
> I would move root cert up before the others. Also CRL.
>
> Root cert and CRL are about validating the *server* certificate. Key
> and cert file are about SSL authentication of the *client* (thus
> *client* certificates). They should definitely be in that order -
> perhaps even grouped with a headline?
>
Done for moving widgets. Not sure grouped widgets could make sense here.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-22 08:00 Dave Page <dpage@pgadmin.org>
parent: Guillaume Lelarge <guillaume@lelarge.info>
0 siblings, 1 reply; 20+ messages in thread
From: Dave Page @ 2011-01-22 08:00 UTC (permalink / raw)
To: Guillaume Lelarge <guillaume@lelarge.info>; +Cc: pgadmin-hackers
On Sat, Jan 22, 2011 at 12:33 AM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Le 21/01/2011 10:15, Dave Page a écrit :
> Done.
>
>> Also, what's with the inconsistent text/artwork on the buttons?
>>
The first browse button has no leading icon, and the text:
(No...
The second has an icon, and:
ro...
The third has an icon and:
...
The fourth has no icon, and:
(No...
It's ugly, inconsistent and, well, useless.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-27 21:55 Guillaume Lelarge <guillaume@lelarge.info>
parent: Dave Page <dpage@pgadmin.org>
0 siblings, 0 replies; 20+ messages in thread
From: Guillaume Lelarge @ 2011-01-27 21:55 UTC (permalink / raw)
To: Dave Page <dpage@pgadmin.org>; +Cc: pgadmin-hackers
Le 22/01/2011 09:00, Dave Page a écrit :
> On Sat, Jan 22, 2011 at 12:33 AM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> Le 21/01/2011 10:15, Dave Page a écrit :
>> Done.
>>
>>> Also, what's with the inconsistent text/artwork on the buttons?
>>>
>
> The first browse button has no leading icon, and the text:
>
> (No...
>
> The second has an icon, and:
>
> ro...
>
> The third has an icon and:
>
> ...
>
> The fourth has no icon, and:
>
> (No...
>
> It's ugly, inconsistent and, well, useless.
>
Yeah, this is fixed. See my next mail to answer Magnus' question.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-27 21:56 Guillaume Lelarge <guillaume@lelarge.info>
parent: Guillaume Lelarge <guillaume@lelarge.info>
0 siblings, 2 replies; 20+ messages in thread
From: Guillaume Lelarge @ 2011-01-27 21:56 UTC (permalink / raw)
To: Magnus Hagander <magnus@hagander.net>; +Cc: pgadmin-hackers
Le 22/01/2011 01:34, Guillaume Lelarge a écrit :
> Le 21/01/2011 10:17, Magnus Hagander a écrit :
>> On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>>> Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
>>>> Hi,
>>>>
>>>> This patch adds support to specify SSL certificate files and to connect
>>>> according to those.
>>>>
>>>> It's pretty straightforward: four file pickers to handle on dlgServer,
>>>> and changes in the connection code to add those parameters in the
>>>> connection string.
>>>>
>>>
>>> A screenshot attached so that you can see the UI without building pgAdmin :)
>>>
>>> Comments?
>>
>> I would move root cert up before the others. Also CRL.
>>
>> Root cert and CRL are about validating the *server* certificate. Key
>> and cert file are about SSL authentication of the *client* (thus
>> *client* certificates). They should definitely be in that order -
>> perhaps even grouped with a headline?
>>
>
> Done for moving widgets. Not sure grouped widgets could make sense here.
>
Here is what I finally managed to do. Comments?
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
Attachments:
sslserver.png (image/png, 37.1K) download
view image
* Re: Patch to support SSL certificate connections
@ 2011-01-28 01:11 Dave Page <dpage@pgadmin.org>
parent: Guillaume Lelarge <guillaume@lelarge.info>
1 sibling, 1 reply; 20+ messages in thread
From: Dave Page @ 2011-01-28 01:11 UTC (permalink / raw)
To: Guillaume Lelarge <guillaume@lelarge.info>; +Cc: Magnus Hagander <magnus@hagander.net>; pgadmin-hackers
On Thu, Jan 27, 2011 at 9:56 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Le 22/01/2011 01:34, Guillaume Lelarge a écrit :
>> Le 21/01/2011 10:17, Magnus Hagander a écrit :
>>> On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>>>> Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
>>>>> Hi,
>>>>>
>>>>> This patch adds support to specify SSL certificate files and to connect
>>>>> according to those.
>>>>>
>>>>> It's pretty straightforward: four file pickers to handle on dlgServer,
>>>>> and changes in the connection code to add those parameters in the
>>>>> connection string.
>>>>>
>>>>
>>>> A screenshot attached so that you can see the UI without building pgAdmin :)
>>>>
>>>> Comments?
>>>
>>> I would move root cert up before the others. Also CRL.
>>>
>>> Root cert and CRL are about validating the *server* certificate. Key
>>> and cert file are about SSL authentication of the *client* (thus
>>> *client* certificates). They should definitely be in that order -
>>> perhaps even grouped with a headline?
>>>
>>
>> Done for moving widgets. Not sure grouped widgets could make sense here.
>>
>
> Here is what I finally managed to do. Comments?
Why the change from the standard layout used everywhere else?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-28 03:58 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
parent: Guillaume Lelarge <guillaume@lelarge.info>
1 sibling, 1 reply; 20+ messages in thread
From: Ashesh Vashi @ 2011-01-28 03:58 UTC (permalink / raw)
To: Guillaume Lelarge <guillaume@lelarge.info>; +Cc: Magnus Hagander <magnus@hagander.net>; pgadmin-hackers
Hi Guillaume,
I think - you've used wxStaticBox here.
If I am not wrong, please consider this patch for testing on osx.
I've faced an issue in recent past with the wxStaticBox related to mouse &
keyboard events pass to the components the components under it on osx.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com;
*http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi;
On Fri, Jan 28, 2011 at 3:26 AM, Guillaume Lelarge
<guillaume@lelarge.info>wrote:
> Le 22/01/2011 01:34, Guillaume Lelarge a écrit :
> > Le 21/01/2011 10:17, Magnus Hagander a écrit :
> >> On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge <
> guillaume@lelarge.info> wrote:
> >>> Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
> >>>> Hi,
> >>>>
> >>>> This patch adds support to specify SSL certificate files and to
> connect
> >>>> according to those.
> >>>>
> >>>> It's pretty straightforward: four file pickers to handle on dlgServer,
> >>>> and changes in the connection code to add those parameters in the
> >>>> connection string.
> >>>>
> >>>
> >>> A screenshot attached so that you can see the UI without building
> pgAdmin :)
> >>>
> >>> Comments?
> >>
> >> I would move root cert up before the others. Also CRL.
> >>
> >> Root cert and CRL are about validating the *server* certificate. Key
> >> and cert file are about SSL authentication of the *client* (thus
> >> *client* certificates). They should definitely be in that order -
> >> perhaps even grouped with a headline?
> >>
> >
> > Done for moving widgets. Not sure grouped widgets could make sense here.
> >
>
> Here is what I finally managed to do. Comments?
>
>
> --
> Guillaume
> http://www.postgresql.fr
> http://dalibo.com
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-28 07:25 Guillaume Lelarge <guillaume@lelarge.info>
parent: Dave Page <dpage@pgadmin.org>
0 siblings, 1 reply; 20+ messages in thread
From: Guillaume Lelarge @ 2011-01-28 07:25 UTC (permalink / raw)
To: Dave Page <dpage@pgadmin.org>; +Cc: Magnus Hagander <magnus@hagander.net>; pgadmin-hackers
Le 28/01/2011 02:11, Dave Page a écrit :
> On Thu, Jan 27, 2011 at 9:56 PM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> Le 22/01/2011 01:34, Guillaume Lelarge a écrit :
>>> Le 21/01/2011 10:17, Magnus Hagander a écrit :
>>>> On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>>>>> Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
>>>>>> Hi,
>>>>>>
>>>>>> This patch adds support to specify SSL certificate files and to connect
>>>>>> according to those.
>>>>>>
>>>>>> It's pretty straightforward: four file pickers to handle on dlgServer,
>>>>>> and changes in the connection code to add those parameters in the
>>>>>> connection string.
>>>>>>
>>>>>
>>>>> A screenshot attached so that you can see the UI without building pgAdmin :)
>>>>>
>>>>> Comments?
>>>>
>>>> I would move root cert up before the others. Also CRL.
>>>>
>>>> Root cert and CRL are about validating the *server* certificate. Key
>>>> and cert file are about SSL authentication of the *client* (thus
>>>> *client* certificates). They should definitely be in that order -
>>>> perhaps even grouped with a headline?
>>>>
>>>
>>> Done for moving widgets. Not sure grouped widgets could make sense here.
>>>
>>
>> Here is what I finally managed to do. Comments?
>
> Why the change from the standard layout used everywhere else?
>
Because Magnus asked for that kind of design? (grouped with a headline)
I actually also tried with a wxStaticLine but it seems to need a fixed size.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-28 07:27 Guillaume Lelarge <guillaume@lelarge.info>
parent: Ashesh Vashi <ashesh.vashi@enterprisedb.com>
0 siblings, 1 reply; 20+ messages in thread
From: Guillaume Lelarge @ 2011-01-28 07:27 UTC (permalink / raw)
To: Ashesh Vashi <ashesh.vashi@enterprisedb.com>; +Cc: Magnus Hagander <magnus@hagander.net>; pgadmin-hackers
Hi Ashesh,
Le 28/01/2011 04:58, Ashesh Vashi a écrit :
> [...]
> I think - you've used wxStaticBox here.
Actually, it's a wxStaticBoxSizer. Not sure if it matters.
> If I am not wrong, please consider this patch for testing on osx.
> I've faced an issue in recent past with the wxStaticBox related to mouse &
> keyboard events pass to the components the components under it on osx.
>
Will be hard. I still cannot have a good build on osx.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-28 07:30 Ashesh Vashi <ashesh.vashi@enterprisedb.com>
parent: Guillaume Lelarge <guillaume@lelarge.info>
0 siblings, 0 replies; 20+ messages in thread
From: Ashesh Vashi @ 2011-01-28 07:30 UTC (permalink / raw)
To: Guillaume Lelarge <guillaume@lelarge.info>; +Cc: Magnus Hagander <magnus@hagander.net>; pgadmin-hackers
Hi Guillaume,
On Fri, Jan 28, 2011 at 12:57 PM, Guillaume Lelarge
<guillaume@lelarge.info>wrote:
> Hi Ashesh,
>
> Le 28/01/2011 04:58, Ashesh Vashi a écrit :
> > [...]
> > I think - you've used wxStaticBox here.
>
> Actually, it's a wxStaticBoxSizer. Not sure if it matters.
>
It does.
I was using the wxStaticBoxSizer only and that uses wxStaticBox.
It won't work. :-(
> > If I am not wrong, please consider this patch for testing on osx.
> > I've faced an issue in recent past with the wxStaticBox related to mouse
> &
> > keyboard events pass to the components the components under it on osx.
> >
>
> Will be hard. I still cannot have a good build on osx.
>
Send me the patch.
I will spend some time on weekends.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company<http://www.enterprisedb.com/;
*http://www.linkedin.com/in/asheshvashi*<http://www.linkedin.com/in/asheshvashi;
>
>
> --
> Guillaume
> http://www.postgresql.fr
> http://dalibo.com
>
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-28 08:21 Dave Page <dpage@pgadmin.org>
parent: Guillaume Lelarge <guillaume@lelarge.info>
0 siblings, 1 reply; 20+ messages in thread
From: Dave Page @ 2011-01-28 08:21 UTC (permalink / raw)
To: Guillaume Lelarge <guillaume@lelarge.info>; +Cc: Magnus Hagander <magnus@hagander.net>; pgadmin-hackers
On Fri, Jan 28, 2011 at 7:25 AM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Le 28/01/2011 02:11, Dave Page a écrit :
>> On Thu, Jan 27, 2011 at 9:56 PM, Guillaume Lelarge
>> <guillaume@lelarge.info> wrote:
>>> Le 22/01/2011 01:34, Guillaume Lelarge a écrit :
>>>> Le 21/01/2011 10:17, Magnus Hagander a écrit :
>>>>> On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>>>>>> Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
>>>>>>> Hi,
>>>>>>>
>>>>>>> This patch adds support to specify SSL certificate files and to connect
>>>>>>> according to those.
>>>>>>>
>>>>>>> It's pretty straightforward: four file pickers to handle on dlgServer,
>>>>>>> and changes in the connection code to add those parameters in the
>>>>>>> connection string.
>>>>>>>
>>>>>>
>>>>>> A screenshot attached so that you can see the UI without building pgAdmin :)
>>>>>>
>>>>>> Comments?
>>>>>
>>>>> I would move root cert up before the others. Also CRL.
>>>>>
>>>>> Root cert and CRL are about validating the *server* certificate. Key
>>>>> and cert file are about SSL authentication of the *client* (thus
>>>>> *client* certificates). They should definitely be in that order -
>>>>> perhaps even grouped with a headline?
>>>>>
>>>>
>>>> Done for moving widgets. Not sure grouped widgets could make sense here.
>>>>
>>>
>>> Here is what I finally managed to do. Comments?
>>
>> Why the change from the standard layout used everywhere else?
>>
>
> Because Magnus asked for that kind of design? (grouped with a headline)
He suggested it, but that doesn't mean it has to be done. If we're
going to break the property dialog design guidelines and start laying
things out in new formats we need to be *really* careful to avoid
getting in an inconsistent mess.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-28 08:37 Guillaume Lelarge <guillaume@lelarge.info>
parent: Dave Page <dpage@pgadmin.org>
0 siblings, 1 reply; 20+ messages in thread
From: Guillaume Lelarge @ 2011-01-28 08:37 UTC (permalink / raw)
To: Dave Page <dpage@pgadmin.org>; +Cc: Magnus Hagander <magnus@hagander.net>; pgadmin-hackers
Le 28/01/2011 09:21, Dave Page a écrit :
> On Fri, Jan 28, 2011 at 7:25 AM, Guillaume Lelarge
> <guillaume@lelarge.info> wrote:
>> Le 28/01/2011 02:11, Dave Page a écrit :
>>> On Thu, Jan 27, 2011 at 9:56 PM, Guillaume Lelarge
>>> <guillaume@lelarge.info> wrote:
>>>> Le 22/01/2011 01:34, Guillaume Lelarge a écrit :
>>>>> Le 21/01/2011 10:17, Magnus Hagander a écrit :
>>>>>> On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>>>>>>> Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> This patch adds support to specify SSL certificate files and to connect
>>>>>>>> according to those.
>>>>>>>>
>>>>>>>> It's pretty straightforward: four file pickers to handle on dlgServer,
>>>>>>>> and changes in the connection code to add those parameters in the
>>>>>>>> connection string.
>>>>>>>>
>>>>>>>
>>>>>>> A screenshot attached so that you can see the UI without building pgAdmin :)
>>>>>>>
>>>>>>> Comments?
>>>>>>
>>>>>> I would move root cert up before the others. Also CRL.
>>>>>>
>>>>>> Root cert and CRL are about validating the *server* certificate. Key
>>>>>> and cert file are about SSL authentication of the *client* (thus
>>>>>> *client* certificates). They should definitely be in that order -
>>>>>> perhaps even grouped with a headline?
>>>>>>
>>>>>
>>>>> Done for moving widgets. Not sure grouped widgets could make sense here.
>>>>>
>>>>
>>>> Here is what I finally managed to do. Comments?
>>>
>>> Why the change from the standard layout used everywhere else?
>>>
>>
>> Because Magnus asked for that kind of design? (grouped with a headline)
>
> He suggested it, but that doesn't mean it has to be done. If we're
> going to break the property dialog design guidelines and start laying
> things out in new formats we need to be *really* careful to avoid
> getting in an inconsistent mess.
>
Yeah, I know. And "grouped with a headline" doesn't mean we have to use
a wxStaticBoxSizer. Anyway, reading your comments and Ashesh's comments,
I will drop the wxStaticBoxSizer and everyone will be happy:
* no strange issue on MacOSX for Ashesh
* no weird design for you
* but still first server certificate and then client certificate for Magnus.
Will try to work on this today.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-28 18:24 Guillaume Lelarge <guillaume@lelarge.info>
parent: Guillaume Lelarge <guillaume@lelarge.info>
0 siblings, 1 reply; 20+ messages in thread
From: Guillaume Lelarge @ 2011-01-28 18:24 UTC (permalink / raw)
To: Dave Page <dpage@pgadmin.org>; +Cc: Magnus Hagander <magnus@hagander.net>; pgadmin-hackers
Le 28/01/2011 09:37, Guillaume Lelarge a écrit :
> Le 28/01/2011 09:21, Dave Page a écrit :
>> On Fri, Jan 28, 2011 at 7:25 AM, Guillaume Lelarge
>> <guillaume@lelarge.info> wrote:
>>> Le 28/01/2011 02:11, Dave Page a écrit :
>>>> On Thu, Jan 27, 2011 at 9:56 PM, Guillaume Lelarge
>>>> <guillaume@lelarge.info> wrote:
>>>>> Le 22/01/2011 01:34, Guillaume Lelarge a écrit :
>>>>>> Le 21/01/2011 10:17, Magnus Hagander a écrit :
>>>>>>> On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>>>>>>>> Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> This patch adds support to specify SSL certificate files and to connect
>>>>>>>>> according to those.
>>>>>>>>>
>>>>>>>>> It's pretty straightforward: four file pickers to handle on dlgServer,
>>>>>>>>> and changes in the connection code to add those parameters in the
>>>>>>>>> connection string.
>>>>>>>>>
>>>>>>>>
>>>>>>>> A screenshot attached so that you can see the UI without building pgAdmin :)
>>>>>>>>
>>>>>>>> Comments?
>>>>>>>
>>>>>>> I would move root cert up before the others. Also CRL.
>>>>>>>
>>>>>>> Root cert and CRL are about validating the *server* certificate. Key
>>>>>>> and cert file are about SSL authentication of the *client* (thus
>>>>>>> *client* certificates). They should definitely be in that order -
>>>>>>> perhaps even grouped with a headline?
>>>>>>>
>>>>>>
>>>>>> Done for moving widgets. Not sure grouped widgets could make sense here.
>>>>>>
>>>>>
>>>>> Here is what I finally managed to do. Comments?
>>>>
>>>> Why the change from the standard layout used everywhere else?
>>>>
>>>
>>> Because Magnus asked for that kind of design? (grouped with a headline)
>>
>> He suggested it, but that doesn't mean it has to be done. If we're
>> going to break the property dialog design guidelines and start laying
>> things out in new formats we need to be *really* careful to avoid
>> getting in an inconsistent mess.
>>
>
> Yeah, I know. And "grouped with a headline" doesn't mean we have to use
> a wxStaticBoxSizer. Anyway, reading your comments and Ashesh's comments,
> I will drop the wxStaticBoxSizer and everyone will be happy:
>
> * no strange issue on MacOSX for Ashesh
> * no weird design for you
> * but still first server certificate and then client certificate for Magnus.
>
> Will try to work on this today.
>
What about this one?
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
Attachments:
sslfiles_v3.png (image/png, 33.6K) download
view image
* Re: Patch to support SSL certificate connections
@ 2011-01-28 18:39 Dave Page <dpage@pgadmin.org>
parent: Guillaume Lelarge <guillaume@lelarge.info>
0 siblings, 1 reply; 20+ messages in thread
From: Dave Page @ 2011-01-28 18:39 UTC (permalink / raw)
To: Guillaume Lelarge <guillaume@lelarge.info>; +Cc: Magnus Hagander <magnus@hagander.net>; pgadmin-hackers
That's better.
Fyi, the other design did look OK - i just think we need to plan such
changes properly and implement in batches rather than piecemeal.
On 1/28/11, Guillaume Lelarge <guillaume@lelarge.info> wrote:
> Le 28/01/2011 09:37, Guillaume Lelarge a écrit :
>> Le 28/01/2011 09:21, Dave Page a écrit :
>>> On Fri, Jan 28, 2011 at 7:25 AM, Guillaume Lelarge
>>> <guillaume@lelarge.info> wrote:
>>>> Le 28/01/2011 02:11, Dave Page a écrit :
>>>>> On Thu, Jan 27, 2011 at 9:56 PM, Guillaume Lelarge
>>>>> <guillaume@lelarge.info> wrote:
>>>>>> Le 22/01/2011 01:34, Guillaume Lelarge a écrit :
>>>>>>> Le 21/01/2011 10:17, Magnus Hagander a écrit :
>>>>>>>> On Thu, Jan 20, 2011 at 23:08, Guillaume Lelarge
>>>>>>>> <guillaume@lelarge.info> wrote:
>>>>>>>>> Le 19/01/2011 00:35, Guillaume Lelarge a écrit :
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> This patch adds support to specify SSL certificate files and to
>>>>>>>>>> connect
>>>>>>>>>> according to those.
>>>>>>>>>>
>>>>>>>>>> It's pretty straightforward: four file pickers to handle on
>>>>>>>>>> dlgServer,
>>>>>>>>>> and changes in the connection code to add those parameters in the
>>>>>>>>>> connection string.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> A screenshot attached so that you can see the UI without building
>>>>>>>>> pgAdmin :)
>>>>>>>>>
>>>>>>>>> Comments?
>>>>>>>>
>>>>>>>> I would move root cert up before the others. Also CRL.
>>>>>>>>
>>>>>>>> Root cert and CRL are about validating the *server* certificate. Key
>>>>>>>> and cert file are about SSL authentication of the *client* (thus
>>>>>>>> *client* certificates). They should definitely be in that order -
>>>>>>>> perhaps even grouped with a headline?
>>>>>>>>
>>>>>>>
>>>>>>> Done for moving widgets. Not sure grouped widgets could make sense
>>>>>>> here.
>>>>>>>
>>>>>>
>>>>>> Here is what I finally managed to do. Comments?
>>>>>
>>>>> Why the change from the standard layout used everywhere else?
>>>>>
>>>>
>>>> Because Magnus asked for that kind of design? (grouped with a headline)
>>>
>>> He suggested it, but that doesn't mean it has to be done. If we're
>>> going to break the property dialog design guidelines and start laying
>>> things out in new formats we need to be *really* careful to avoid
>>> getting in an inconsistent mess.
>>>
>>
>> Yeah, I know. And "grouped with a headline" doesn't mean we have to use
>> a wxStaticBoxSizer. Anyway, reading your comments and Ashesh's comments,
>> I will drop the wxStaticBoxSizer and everyone will be happy:
>>
>> * no strange issue on MacOSX for Ashesh
>> * no weird design for you
>> * but still first server certificate and then client certificate for
>> Magnus.
>>
>> Will try to work on this today.
>>
>
> What about this one?
>
>
> --
> Guillaume
> http://www.postgresql.fr
> http://dalibo.com
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-28 19:44 Guillaume Lelarge <guillaume@lelarge.info>
parent: Dave Page <dpage@pgadmin.org>
0 siblings, 1 reply; 20+ messages in thread
From: Guillaume Lelarge @ 2011-01-28 19:44 UTC (permalink / raw)
To: Dave Page <dpage@pgadmin.org>; +Cc: Magnus Hagander <magnus@hagander.net>; pgadmin-hackers
Le 28/01/2011 19:39, Dave Page a écrit :
> That's better.
>
> Fyi, the other design did look OK - i just think we need to plan such
> changes properly and implement in batches rather than piecemeal.
>
My issue with my last design is that the two first buttons and the two
last buttons were not properly aligned. It didn't feel right with the
rest of the widgets.
I think that, with the new labels, it should be enough.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
^ permalink raw reply [nested|flat] 20+ messages in thread
* Re: Patch to support SSL certificate connections
@ 2011-01-30 15:56 Guillaume Lelarge <guillaume@lelarge.info>
parent: Guillaume Lelarge <guillaume@lelarge.info>
0 siblings, 0 replies; 20+ messages in thread
From: Guillaume Lelarge @ 2011-01-30 15:56 UTC (permalink / raw)
To: Dave Page <dpage@pgadmin.org>; +Cc: Magnus Hagander <magnus@hagander.net>; pgadmin-hackers
Le 28/01/2011 20:44, Guillaume Lelarge a écrit :
> Le 28/01/2011 19:39, Dave Page a écrit :
>> That's better.
>>
>> Fyi, the other design did look OK - i just think we need to plan such
>> changes properly and implement in batches rather than piecemeal.
>>
>
> My issue with my last design is that the two first buttons and the two
> last buttons were not properly aligned. It didn't feel right with the
> rest of the widgets.
>
> I think that, with the new labels, it should be enough.
>
Commited.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
^ permalink raw reply [nested|flat] 20+ messages in thread
end of thread, other threads:[~2011-01-30 15:56 UTC | newest]
Thread overview: 20+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2011-01-18 23:35 Patch to support SSL certificate connections Guillaume Lelarge <guillaume@lelarge.info>
2011-01-20 22:08 ` Guillaume Lelarge <guillaume@lelarge.info>
2011-01-21 09:15 ` Dave Page <dpage@pgadmin.org>
2011-01-22 00:33 ` Guillaume Lelarge <guillaume@lelarge.info>
2011-01-22 08:00 ` Dave Page <dpage@pgadmin.org>
2011-01-27 21:55 ` Guillaume Lelarge <guillaume@lelarge.info>
2011-01-21 09:17 ` Magnus Hagander <magnus@hagander.net>
2011-01-22 00:34 ` Guillaume Lelarge <guillaume@lelarge.info>
2011-01-27 21:56 ` Guillaume Lelarge <guillaume@lelarge.info>
2011-01-28 01:11 ` Dave Page <dpage@pgadmin.org>
2011-01-28 07:25 ` Guillaume Lelarge <guillaume@lelarge.info>
2011-01-28 08:21 ` Dave Page <dpage@pgadmin.org>
2011-01-28 08:37 ` Guillaume Lelarge <guillaume@lelarge.info>
2011-01-28 18:24 ` Guillaume Lelarge <guillaume@lelarge.info>
2011-01-28 18:39 ` Dave Page <dpage@pgadmin.org>
2011-01-28 19:44 ` Guillaume Lelarge <guillaume@lelarge.info>
2011-01-30 15:56 ` Guillaume Lelarge <guillaume@lelarge.info>
2011-01-28 03:58 ` Ashesh Vashi <ashesh.vashi@enterprisedb.com>
2011-01-28 07:27 ` Guillaume Lelarge <guillaume@lelarge.info>
2011-01-28 07:30 ` Ashesh Vashi <ashesh.vashi@enterprisedb.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox