public inbox for [email protected]help / color / mirror / Atom feed
Adding storage parameters on index 3+ messages / 3 participants [nested] [flat]
* Adding storage parameters on index @ 2023-06-23 08:58 Pravesh Sharma <[email protected]> 2023-06-26 05:49 ` Re: Adding storage parameters on index Akshay Joshi <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Pravesh Sharma @ 2023-06-23 08:58 UTC (permalink / raw) To: pgadmin-hackers Hi All, I am working on feature #6374 <https://github.com/pgadmin-org/pgadmin4/issues/6374; which is adding storage parameters while creating an index. I have made changes in the definition tab of create index to have all the required parameters. Attached is the new design, please review it. I also have a few points which require suggestions. 1. Storage parameters are different for different access methods. If an access method does not support a parameter we can either disable it or hide it (I am thinking of hiding it based on the access method). 2. There is a storage parameter named *buffering *which is by default auto and takes on/off value. What type of control should I use for it? Should it be a switch or a drop down with three options on, off and auto, if we have a switch user won't be able to move to auto. 3. There is a parameter *vacuum_cleanup_index_scale_factor *that was added on PostgreSQL 11 but was removed on PostgreSQL 13, should we add this too? Thanks Pravesh Sharma -- <http://www.enterprisedb.com; Pravesh Sharma Software Engineer +91 9406461406 www.enterprisedb.com Power to Postgres <https://www.linkedin.com/company/edbpostgres; <https://twitter.com/edbpostgres?lang=en; <https://www.facebook.com/EDBpostgres; <https://www.instagram.com/EDBpostgres/; Attachments: [image/png] Screenshot 2023-06-23 at 1.40.07 PM.png (202.7K, 3-Screenshot%202023-06-23%20at%201.40.07%20PM.png) download | view image ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Adding storage parameters on index 2023-06-23 08:58 Adding storage parameters on index Pravesh Sharma <[email protected]> @ 2023-06-26 05:49 ` Akshay Joshi <[email protected]> 2023-06-26 05:53 ` Re: Adding storage parameters on index Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Akshay Joshi @ 2023-06-26 05:49 UTC (permalink / raw) To: Pravesh Sharma <[email protected]>; +Cc: pgadmin-hackers Hi Pravesh On Fri, Jun 23, 2023 at 2:28 PM Pravesh Sharma < [email protected]> wrote: > Hi All, > > I am working on feature #6374 > <https://github.com/pgadmin-org/pgadmin4/issues/6374; which is > adding storage parameters while creating an index. I have made changes in > the definition tab of create index to have all the required parameters. > Attached is the new design, please review it. > > I also have a few points which require suggestions. > > 1. Storage parameters are different for different access methods. If > an access method does not support a parameter we can either disable it or > hide it (I am thinking of hiding it based on the access method). > > Disable the controls. > > 1. There is a storage parameter named *buffering *which is by > default auto and takes on/off value. What type of control should I use for > it? Should it be a switch or a drop down with three options on, off and > auto, if we have a switch user won't be able to move to auto. > > It should be a drop-down with all three options. > > 1. There is a parameter *vacuum_cleanup_index_scale_factor *that was > added on PostgreSQL 11 but was removed on PostgreSQL 13, should we add this > too? > > No need to add the above parameter. > > > Thanks > Pravesh Sharma > > -- > > <http://www.enterprisedb.com; > > Pravesh Sharma > > Software Engineer > > +91 9406461406 > > www.enterprisedb.com > > Power to Postgres > > <https://www.linkedin.com/company/edbpostgres; > <https://twitter.com/edbpostgres?lang=en; > <https://www.facebook.com/EDBpostgres; > <https://www.instagram.com/EDBpostgres/; > ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Adding storage parameters on index 2023-06-23 08:58 Adding storage parameters on index Pravesh Sharma <[email protected]> 2023-06-26 05:49 ` Re: Adding storage parameters on index Akshay Joshi <[email protected]> @ 2023-06-26 05:53 ` Aditya Toshniwal <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Aditya Toshniwal @ 2023-06-26 05:53 UTC (permalink / raw) To: Akshay Joshi <[email protected]>; +Cc: Pravesh Sharma <[email protected]>; pgadmin-hackers Hi, I would also suggest moving Columns and Include Columns to a separate tab - Columns. On Mon, Jun 26, 2023 at 11:19 AM Akshay Joshi <[email protected]> wrote: > Hi Pravesh > > On Fri, Jun 23, 2023 at 2:28 PM Pravesh Sharma < > [email protected]> wrote: > >> Hi All, >> >> I am working on feature #6374 >> <https://github.com/pgadmin-org/pgadmin4/issues/6374; which is >> adding storage parameters while creating an index. I have made changes in >> the definition tab of create index to have all the required parameters. >> Attached is the new design, please review it. >> >> I also have a few points which require suggestions. >> >> 1. Storage parameters are different for different access methods. If >> an access method does not support a parameter we can either disable it or >> hide it (I am thinking of hiding it based on the access method). >> >> Disable the controls. > >> >> 1. There is a storage parameter named *buffering *which is by >> default auto and takes on/off value. What type of control should I use for >> it? Should it be a switch or a drop down with three options on, off and >> auto, if we have a switch user won't be able to move to auto. >> >> It should be a drop-down with all three options. > >> >> 1. There is a parameter *vacuum_cleanup_index_scale_factor *that was >> added on PostgreSQL 11 but was removed on PostgreSQL 13, should we add this >> too? >> >> No need to add the above parameter. > >> >> >> Thanks >> Pravesh Sharma >> >> -- >> >> <http://www.enterprisedb.com; >> >> Pravesh Sharma >> >> Software Engineer >> >> +91 9406461406 >> >> www.enterprisedb.com >> >> Power to Postgres >> >> <https://www.linkedin.com/company/edbpostgres; >> <https://twitter.com/edbpostgres?lang=en; >> <https://www.facebook.com/EDBpostgres; >> <https://www.instagram.com/EDBpostgres/; >> > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/; "Don't Complain about Heat, Plant a TREE" ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2023-06-26 05:53 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-06-23 08:58 Adding storage parameters on index Pravesh Sharma <[email protected]> 2023-06-26 05:49 ` Akshay Joshi <[email protected]> 2023-06-26 05:53 ` Aditya Toshniwal <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox