public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: RE-SQL tests for Roles & Resource Group nodes
Date: Tue, 2 Jul 2019 13:22:42 +0100
Message-ID: <CA+OCxoyEVimkOdA4rsFzjagsCseZMbpHCk3Uub_MEuhk4+mM8A@mail.gmail.com> (raw)
In-Reply-To: <CAKKotZRJ+cSMwZQPSRmjocxx-VKcmS7aFUTo18i=ZbGYkCuw=A@mail.gmail.com>
References: <CAKKotZTXDruJsXhnNCR=uCeWKPkg6DKk1EAEXrUcMFFpaf0CAg@mail.gmail.com>
<CA+OCxoyk3RfY=mDZ_ebb4stY6SgjzHsG5dimY0D=CuvwOtsoLQ@mail.gmail.com>
<CAKKotZQiNF7QhQ+GiHHuqLyHLZkF99JS718xiSb9cNooPcwC6Q@mail.gmail.com>
<CAKKotZRJ+cSMwZQPSRmjocxx-VKcmS7aFUTo18i=ZbGYkCuw=A@mail.gmail.com>
Hi
On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala <
[email protected]> wrote:
> ++ Attaching patch
>
> On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> Please find the updated patch,
>>
>> - Added a mechanism to check for supported minimum/maximum version and a
>> server type in the framework.
>>
>
There's still a problem with this I'm afraid - it says in the summary that
the re_sql test cases were all skipped, which is not the case. I think we
should just skip the irrelevant tests in the re_sql module, but not mark
the entire module as being skipped:
=============Running the test cases for 'Regression - PG 11'=============
runTest (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases)
Reverse Engineered SQL Test Cases
Create IMPLICIT Cast
Alter IMPLICIT Cast
Drop IMPLICIT Cast
Create EXPLICIT Cast
Alter EXPLICIT Cast
Drop EXPLICIT Cast
... skipped 'Server(Type: #ppas) is not supported for the Resource Groups
module'
----------------------------------------------------------------------
Ran 1 test in 0.480s
OK (skipped=1)
======================================================================
Test Result Summary
======================================================================
Regression - PG 11:
0 tests passed
0 tests failed
1 test skipped:
ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)
======================================================================
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: RE-SQL tests for Roles & Resource Group nodes
In-Reply-To: <CA+OCxoyEVimkOdA4rsFzjagsCseZMbpHCk3Uub_MEuhk4+mM8A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox