public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][RM#3404] Graphical explain plan do not display text under the node
5+ messages / 3 participants
[nested] [flat]
* [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node
@ 2018-06-06 17:04 Murtuza Zabuawala <[email protected]>
2018-06-06 21:18 ` Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node Victoria Henry <[email protected]>
2018-06-07 09:02 ` Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node Dave Page <[email protected]>
0 siblings, 2 replies; 5+ messages in thread
From: Murtuza Zabuawala @ 2018-06-06 17:04 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
PFA minor patch to fix the regression issue introduced with RM#3271 commit
due to which label is not displaying under the graphical explain node, I've
attached the screenshot in RM for your reference.
Attachments:
[application/octet-stream] RM_3404.diff (815B, 3-RM_3404.diff)
download | inline diff:
diff --git a/web/pgadmin/misc/static/explain/js/explain.js b/web/pgadmin/misc/static/explain/js/explain.js
index 61cf8f9..aad0dd4 100644
--- a/web/pgadmin/misc/static/explain/js/explain.js
+++ b/web/pgadmin/misc/static/explain/js/explain.js
@@ -576,7 +576,7 @@ define('pgadmin.misc.explain', [
// Draw tooltip
var image_data = this.toJSON();
- image.on('mouseover',() => {
+ image.mouseout(() => {
// Empty the tooltip content if it has any and add new data
toolTipContainer.empty();
@@ -618,7 +618,7 @@ define('pgadmin.misc.explain', [
});
// Remove tooltip when mouse is out from node's area
- image.on('mouseout',() => {
+ image.mouseout(() => {
toolTipContainer.empty();
toolTipContainer.css({
'opacity': '0',
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node
2018-06-06 17:04 [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node Murtuza Zabuawala <[email protected]>
@ 2018-06-06 21:18 ` Victoria Henry <[email protected]>
1 sibling, 0 replies; 5+ messages in thread
From: Victoria Henry @ 2018-06-06 21:18 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Hi Murtuza,
LGTM and passes tests:
https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/119
Sincerely,
Victoria
On Wed, Jun 6, 2018 at 1:04 PM Murtuza Zabuawala <
[email protected]> wrote:
> Hi,
>
> PFA minor patch to fix the regression issue introduced with RM#3271 commit
> due to which label is not displaying under the graphical explain node, I've
> attached the screenshot in RM for your reference.
>
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node
2018-06-06 17:04 [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node Murtuza Zabuawala <[email protected]>
@ 2018-06-07 09:02 ` Dave Page <[email protected]>
1 sibling, 0 replies; 5+ messages in thread
From: Dave Page @ 2018-06-07 09:02 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Hi
On Wed, Jun 6, 2018 at 6:04 PM, Murtuza Zabuawala <
[email protected]> wrote:
> Hi,
>
> PFA minor patch to fix the regression issue introduced with RM#3271 commit
> due to which label is not displaying under the graphical explain node, I've
> attached the screenshot in RM for your reference.
>
I see the labels, but the popups are not displaying on mouseover/hover like
they used to. Can you look into that please?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node
@ 2018-06-09 18:01 Murtuza Zabuawala <[email protected]>
2018-06-11 16:03 ` Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node Dave Page <[email protected]>
0 siblings, 1 reply; 5+ messages in thread
From: Murtuza Zabuawala @ 2018-06-09 18:01 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Dave,
Sorry, the previous patch had a typo, Here's an updated patch.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Jun 7, 2018 at 2:32 PM, Dave Page <[email protected]> wrote:
> Hi
>
> On Wed, Jun 6, 2018 at 6:04 PM, Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi,
>>
>> PFA minor patch to fix the regression issue introduced with RM#3271
>> commit due to which label is not displaying under the graphical explain
>> node, I've attached the screenshot in RM for your reference.
>>
>
> I see the labels, but the popups are not displaying on mouseover/hover
> like they used to. Can you look into that please?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachments:
[application/octet-stream] RM_3404_v1.diff (816B, 3-RM_3404_v1.diff)
download | inline diff:
diff --git a/web/pgadmin/misc/static/explain/js/explain.js b/web/pgadmin/misc/static/explain/js/explain.js
index 61cf8f9..e028774 100644
--- a/web/pgadmin/misc/static/explain/js/explain.js
+++ b/web/pgadmin/misc/static/explain/js/explain.js
@@ -576,7 +576,7 @@ define('pgadmin.misc.explain', [
// Draw tooltip
var image_data = this.toJSON();
- image.on('mouseover',() => {
+ image.mouseover(() => {
// Empty the tooltip content if it has any and add new data
toolTipContainer.empty();
@@ -618,7 +618,7 @@ define('pgadmin.misc.explain', [
});
// Remove tooltip when mouse is out from node's area
- image.on('mouseout',() => {
+ image.mouseout(() => {
toolTipContainer.empty();
toolTipContainer.css({
'opacity': '0',
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node
2018-06-09 18:01 Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node Murtuza Zabuawala <[email protected]>
@ 2018-06-11 16:03 ` Dave Page <[email protected]>
0 siblings, 0 replies; 5+ messages in thread
From: Dave Page @ 2018-06-11 16:03 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Sat, Jun 9, 2018 at 7:01 PM, Murtuza Zabuawala <
[email protected]> wrote:
> Hi Dave,
>
> Sorry, the previous patch had a typo, Here's an updated patch.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Thu, Jun 7, 2018 at 2:32 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Wed, Jun 6, 2018 at 6:04 PM, Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> PFA minor patch to fix the regression issue introduced with RM#3271
>>> commit due to which label is not displaying under the graphical explain
>>> node, I've attached the screenshot in RM for your reference.
>>>
>>
>> I see the labels, but the popups are not displaying on mouseover/hover
>> like they used to. Can you look into that please?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2018-06-11 16:03 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-06-06 17:04 [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node Murtuza Zabuawala <[email protected]>
2018-06-06 21:18 ` Victoria Henry <[email protected]>
2018-06-07 09:02 ` Dave Page <[email protected]>
2018-06-09 18:01 Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node Murtuza Zabuawala <[email protected]>
2018-06-11 16:03 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox