public inbox for [email protected]help / color / mirror / Atom feed
pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 11+ messages / 4 participants [nested] [flat]
* pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 @ 2015-10-12 02:33 Ashesh Vashi <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Ashesh Vashi @ 2015-10-12 02:33 UTC (permalink / raw) To: pgadmin-hackers As per commit:600daf650bd5e50e664c4ece2e53e95446390b6d, we now use pg_get_function_result(..) function to identify the return type of the function, hence - we don't need to add SETOF keyword explicitly, when a function returns set of records. Branch ------ master Details ------- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9d7596dc552cf9315d4aa83eafe19db1acf7e... Modified Files -------------- pgadmin/schema/pgFunction.cpp | 2 -- 1 file changed, 2 deletions(-) -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 @ 2016-01-05 11:01 Nikolai Zhubr <[email protected]> parent: Ashesh Vashi <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Nikolai Zhubr @ 2016-01-05 11:01 UTC (permalink / raw) To: pgadmin-hackers Hi all, Running 1.22-rc1 now I observe that this commit has apparently still not solved the issue in at least one place. That is: - "RETURNS SETOF record" is correctly displayed in SQL panel now. - "RETURNS SETOF SETOF record" is still erroneously displayed under SQL tab within the properties window (effectively preventing set-returning function to be changed in any way through the properties window). Thank you, Nikolai 12.10.2015 5:33, Ashesh Vashi: > As per commit:600daf650bd5e50e664c4ece2e53e95446390b6d, we now use > pg_get_function_result(..) function to identify the return type of the > function, hence - we don't need to add SETOF keyword explicitly, when a > function returns set of records. > > Branch > ------ > master > > Details > ------- > http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9d7596dc552cf9315d4aa83eafe19db1acf7e... > > Modified Files > -------------- > pgadmin/schema/pgFunction.cpp | 2 -- > 1 file changed, 2 deletions(-) > > -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 @ 2016-01-05 11:17 Dave Page <[email protected]> parent: Nikolai Zhubr <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Dave Page @ 2016-01-05 11:17 UTC (permalink / raw) To: Nikolai Zhubr <[email protected]>; +Cc: pgadmin-hackers; Neel Patel <[email protected]> Neel, can you look at this please? Thanks. On Tue, Jan 5, 2016 at 11:01 AM, Nikolai Zhubr <[email protected]> wrote: > Hi all, > > Running 1.22-rc1 now I observe that this commit has apparently still not > solved the issue in at least one place. That is: > > - "RETURNS SETOF record" is correctly displayed in SQL panel now. > > - "RETURNS SETOF SETOF record" is still erroneously displayed under SQL tab > within the properties window (effectively preventing set-returning function > to be changed in any way through the properties window). > > > Thank you, > Nikolai > > 12.10.2015 5:33, Ashesh Vashi: >> >> As per commit:600daf650bd5e50e664c4ece2e53e95446390b6d, we now use >> pg_get_function_result(..) function to identify the return type of the >> function, hence - we don't need to add SETOF keyword explicitly, when a >> function returns set of records. >> >> Branch >> ------ >> master >> >> Details >> ------- >> >> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9d7596dc552cf9315d4aa83eafe19db1acf7e... >> >> Modified Files >> -------------- >> pgadmin/schema/pgFunction.cpp | 2 -- >> 1 file changed, 2 deletions(-) >> >> > > > > -- > Sent via pgadmin-hackers mailing list ([email protected]) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 @ 2016-01-05 11:38 Neel Patel <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Neel Patel @ 2016-01-05 11:38 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Nikolai Zhubr <[email protected]>; pgadmin-hackers Hi Dave, Sure, I will look into this issue. Thanks, Neel Patel On Tue, Jan 5, 2016 at 4:47 PM, Dave Page <[email protected]> wrote: > Neel, can you look at this please? > > Thanks. > > On Tue, Jan 5, 2016 at 11:01 AM, Nikolai Zhubr <[email protected]> > wrote: > > Hi all, > > > > Running 1.22-rc1 now I observe that this commit has apparently still not > > solved the issue in at least one place. That is: > > > > - "RETURNS SETOF record" is correctly displayed in SQL panel now. > > > > - "RETURNS SETOF SETOF record" is still erroneously displayed under SQL > tab > > within the properties window (effectively preventing set-returning > function > > to be changed in any way through the properties window). > > > > > > Thank you, > > Nikolai > > > > 12.10.2015 5:33, Ashesh Vashi: > >> > >> As per commit:600daf650bd5e50e664c4ece2e53e95446390b6d, we now use > >> pg_get_function_result(..) function to identify the return type of the > >> function, hence - we don't need to add SETOF keyword explicitly, when a > >> function returns set of records. > >> > >> Branch > >> ------ > >> master > >> > >> Details > >> ------- > >> > >> > http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9d7596dc552cf9315d4aa83eafe19db1acf7e... > >> > >> Modified Files > >> -------------- > >> pgadmin/schema/pgFunction.cpp | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> > > > > > > > > -- > > Sent via pgadmin-hackers mailing list ([email protected]) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 @ 2016-01-05 12:24 Neel Patel <[email protected]> parent: Neel Patel <[email protected]> 0 siblings, 2 replies; 11+ messages in thread From: Neel Patel @ 2016-01-05 12:24 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Nikolai Zhubr <[email protected]>; pgadmin-hackers Hi, Please find attached patch file with below fix. - Return value of the function will be displayed as "SETOF record" instead of "SETOF SETOF record" under SQL tab within properties window. Let me know for any comments. Thanks, Neel Patel On Tue, Jan 5, 2016 at 5:08 PM, Neel Patel <[email protected]> wrote: > Hi Dave, > > Sure, I will look into this issue. > > Thanks, > Neel Patel > > On Tue, Jan 5, 2016 at 4:47 PM, Dave Page <[email protected]> wrote: > >> Neel, can you look at this please? >> >> Thanks. >> >> On Tue, Jan 5, 2016 at 11:01 AM, Nikolai Zhubr <[email protected]> >> wrote: >> > Hi all, >> > >> > Running 1.22-rc1 now I observe that this commit has apparently still not >> > solved the issue in at least one place. That is: >> > >> > - "RETURNS SETOF record" is correctly displayed in SQL panel now. >> > >> > - "RETURNS SETOF SETOF record" is still erroneously displayed under SQL >> tab >> > within the properties window (effectively preventing set-returning >> function >> > to be changed in any way through the properties window). >> > >> > >> > Thank you, >> > Nikolai >> > >> > 12.10.2015 5:33, Ashesh Vashi: >> >> >> >> As per commit:600daf650bd5e50e664c4ece2e53e95446390b6d, we now use >> >> pg_get_function_result(..) function to identify the return type of the >> >> function, hence - we don't need to add SETOF keyword explicitly, when a >> >> function returns set of records. >> >> >> >> Branch >> >> ------ >> >> master >> >> >> >> Details >> >> ------- >> >> >> >> >> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9d7596dc552cf9315d4aa83eafe19db1acf7e... >> >> >> >> Modified Files >> >> -------------- >> >> pgadmin/schema/pgFunction.cpp | 2 -- >> >> 1 file changed, 2 deletions(-) >> >> >> >> >> > >> > >> > >> > -- >> > Sent via pgadmin-hackers mailing list ([email protected]) >> > To make changes to your subscription: >> > http://www.postgresql.org/mailpref/pgadmin-hackers >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers Attachments: [application/octet-stream] function_sql_setof.patch (432B, 3-function_sql_setof.patch) download | inline diff: diff --git a/pgadmin/dlg/dlgFunction.cpp b/pgadmin/dlg/dlgFunction.cpp index 119a92c..a133df7 100644 --- a/pgadmin/dlg/dlgFunction.cpp +++ b/pgadmin/dlg/dlgFunction.cpp @@ -932,9 +932,6 @@ wxString dlgFunction::GetSql() if (!isProcedure) { sql += wxT(" RETURNS "); - if (chkSetof->GetValue() && !cbReturntype->GetValue().StartsWith(wxT("TABLE"))) - sql += wxT("SETOF "); - sql += cbReturntype->GetValue(); } ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 @ 2016-01-06 09:59 Dave Page <[email protected]> parent: Neel Patel <[email protected]> 1 sibling, 0 replies; 11+ messages in thread From: Dave Page @ 2016-01-06 09:59 UTC (permalink / raw) To: Neel Patel <[email protected]>; +Cc: Nikolai Zhubr <[email protected]>; pgadmin-hackers; Ashesh Vashi <[email protected]> Thanks. Ashesh - can you review/commit please? On Tue, Jan 5, 2016 at 12:24 PM, Neel Patel <[email protected]> wrote: > Hi, > > Please find attached patch file with below fix. > - Return value of the function will be displayed as "SETOF record" instead > of "SETOF SETOF record" under SQL tab within properties window. > > Let me know for any comments. > > Thanks, > Neel Patel > > On Tue, Jan 5, 2016 at 5:08 PM, Neel Patel <[email protected]> > wrote: >> >> Hi Dave, >> >> Sure, I will look into this issue. >> >> Thanks, >> Neel Patel >> >> On Tue, Jan 5, 2016 at 4:47 PM, Dave Page <[email protected]> wrote: >>> >>> Neel, can you look at this please? >>> >>> Thanks. >>> >>> On Tue, Jan 5, 2016 at 11:01 AM, Nikolai Zhubr <[email protected]> >>> wrote: >>> > Hi all, >>> > >>> > Running 1.22-rc1 now I observe that this commit has apparently still >>> > not >>> > solved the issue in at least one place. That is: >>> > >>> > - "RETURNS SETOF record" is correctly displayed in SQL panel now. >>> > >>> > - "RETURNS SETOF SETOF record" is still erroneously displayed under SQL >>> > tab >>> > within the properties window (effectively preventing set-returning >>> > function >>> > to be changed in any way through the properties window). >>> > >>> > >>> > Thank you, >>> > Nikolai >>> > >>> > 12.10.2015 5:33, Ashesh Vashi: >>> >> >>> >> As per commit:600daf650bd5e50e664c4ece2e53e95446390b6d, we now use >>> >> pg_get_function_result(..) function to identify the return type of the >>> >> function, hence - we don't need to add SETOF keyword explicitly, when >>> >> a >>> >> function returns set of records. >>> >> >>> >> Branch >>> >> ------ >>> >> master >>> >> >>> >> Details >>> >> ------- >>> >> >>> >> >>> >> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9d7596dc552cf9315d4aa83eafe19db1acf7e... >>> >> >>> >> Modified Files >>> >> -------------- >>> >> pgadmin/schema/pgFunction.cpp | 2 -- >>> >> 1 file changed, 2 deletions(-) >>> >> >>> >> >>> > >>> > >>> > >>> > -- >>> > Sent via pgadmin-hackers mailing list ([email protected]) >>> > To make changes to your subscription: >>> > http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 @ 2016-01-07 12:43 Nikolai Zhubr <[email protected]> parent: Neel Patel <[email protected]> 1 sibling, 1 reply; 11+ messages in thread From: Nikolai Zhubr @ 2016-01-07 12:43 UTC (permalink / raw) To: Neel Patel <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers Hello all, 05.01.2016 15:24, Neel Patel: > Hi, > > Please find attached patch file with below fix. > - Return value of the function will be displayed as "SETOF record" > instead of "SETOF SETOF record" under SQL tab within properties window. > > Let me know for any comments. Confirmed OK. Please commit. Thank you, Nikolai > > Thanks, > Neel Patel -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 @ 2016-01-07 12:54 Ashesh Vashi <[email protected]> parent: Nikolai Zhubr <[email protected]> 0 siblings, 1 reply; 11+ messages in thread From: Ashesh Vashi @ 2016-01-07 12:54 UTC (permalink / raw) To: Nikolai Zhubr <[email protected]>; +Cc: Neel Patel <[email protected]>; Dave Page <[email protected]>; pgadmin-hackers On Thu, Jan 7, 2016 at 6:13 PM, Nikolai Zhubr <[email protected]> wrote: > Hello all, > > 05.01.2016 15:24, Neel Patel: > >> Hi, >> >> Please find attached patch file with below fix. >> - Return value of the function will be displayed as "SETOF record" >> instead of "SETOF SETOF record" under SQL tab within properties window. >> >> Let me know for any comments. >> > > Confirmed OK. > Please commit. > Done. Thanks. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com; *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi; > > > Thank you, > Nikolai > > >> Thanks, >> Neel Patel >> > > > > > -- > Sent via pgadmin-hackers mailing list ([email protected]) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 @ 2016-01-07 13:07 Nikolai Zhubr <[email protected]> parent: Ashesh Vashi <[email protected]> 0 siblings, 2 replies; 11+ messages in thread From: Nikolai Zhubr @ 2016-01-07 13:07 UTC (permalink / raw) To: Ashesh Vashi <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers Hello all, Would it also go to REL-1_22_0_PATCHES (so as to be included in the upcoming release)? Thank you, Nikolai 07.01.2016 15:54, Ashesh Vashi: [...] > - Return value of the function will be displayed as "SETOF > record" > instead of "SETOF SETOF record" under SQL tab within properties > window. > > Let me know for any comments. > > > Confirmed OK. > Please commit. > > Done. > Thanks. > -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 @ 2016-01-07 13:09 Ashesh Vashi <[email protected]> parent: Nikolai Zhubr <[email protected]> 1 sibling, 0 replies; 11+ messages in thread From: Ashesh Vashi @ 2016-01-07 13:09 UTC (permalink / raw) To: Nikolai Zhubr <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers On Thu, Jan 7, 2016 at 6:37 PM, Nikolai Zhubr <[email protected]> wrote: > Hello all, > > Would it also go to REL-1_22_0_PATCHES (so as to be included in the > upcoming release)? > Yes. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com; *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi; > > Thank you, > Nikolai > > 07.01.2016 15:54, Ashesh Vashi: > [...] > > - Return value of the function will be displayed as "SETOF >> record" >> instead of "SETOF SETOF record" under SQL tab within properties >> window. >> >> Let me know for any comments. >> >> >> Confirmed OK. >> Please commit. >> >> Done. >> Thanks. >> >> > ^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 @ 2016-01-07 13:10 Dave Page <[email protected]> parent: Nikolai Zhubr <[email protected]> 1 sibling, 0 replies; 11+ messages in thread From: Dave Page @ 2016-01-07 13:10 UTC (permalink / raw) To: Nikolai Zhubr <[email protected]>; +Cc: Ashesh Vashi <[email protected]>; pgadmin-hackers The upcoming release was cut on Monday, so it definitely won't make that. 1.22.1 will be the next possible release. On Thu, Jan 7, 2016 at 1:07 PM, Nikolai Zhubr <[email protected]> wrote: > Hello all, > > Would it also go to REL-1_22_0_PATCHES (so as to be included in the upcoming > release)? > > > Thank you, > Nikolai > > 07.01.2016 15:54, Ashesh Vashi: > [...] > >> - Return value of the function will be displayed as "SETOF >> record" >> instead of "SETOF SETOF record" under SQL tab within properties >> window. >> >> Let me know for any comments. >> >> >> Confirmed OK. >> Please commit. >> >> Done. >> Thanks. >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers ^ permalink raw reply [nested|flat] 11+ messages in thread
end of thread, other threads:[~2016-01-07 13:10 UTC | newest] Thread overview: 11+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2015-10-12 02:33 pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390 Ashesh Vashi <[email protected]> 2016-01-05 11:01 ` Nikolai Zhubr <[email protected]> 2016-01-05 11:17 ` Dave Page <[email protected]> 2016-01-05 11:38 ` Neel Patel <[email protected]> 2016-01-05 12:24 ` Neel Patel <[email protected]> 2016-01-06 09:59 ` Dave Page <[email protected]> 2016-01-07 12:43 ` Nikolai Zhubr <[email protected]> 2016-01-07 12:54 ` Ashesh Vashi <[email protected]> 2016-01-07 13:07 ` Nikolai Zhubr <[email protected]> 2016-01-07 13:09 ` Ashesh Vashi <[email protected]> 2016-01-07 13:10 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox