public inbox for [email protected]
help / color / mirror / Atom feedpgAdmin 4 commit: Refactor server dialogue validation for better unit t
4+ messages / 3 participants
[nested] [flat]
* pgAdmin 4 commit: Refactor server dialogue validation for better unit t
@ 2018-03-13 18:47 Dave Page <[email protected]>
2018-03-14 14:37 ` Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t Khushboo Vashi <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Dave Page @ 2018-03-13 18:47 UTC (permalink / raw)
To: pgadmin-hackers
Refactor server dialogue validation for better unit testing.
Victoria & Joao @ Pivotal.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b03cb78af607b04c75de44d635bf201babb...
Author: Victoria Henry <[email protected]>
Modified Files
--------------
web/package.json | 3 +-
.../server_groups/servers/static/js/server.js | 113 ++-------------------
web/pgadmin/static/bundle/browser.js | 2 +-
web/pgadmin/static/js/browser/index.js | 10 ++
.../static/js/browser/server_groups/index.js | 10 ++
.../server_groups/servers/databases/index.js | 10 ++
.../js/browser/server_groups/servers/index.js | 11 ++
.../server_groups/servers/model_validation.js | 104 +++++++++++++++++++
.../server_groups/servers/model_validation_spec.js | 101 ++++++++++++++++++
web/yarn.lock | 46 ++++++++-
10 files changed, 299 insertions(+), 111 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t
2018-03-13 18:47 pgAdmin 4 commit: Refactor server dialogue validation for better unit t Dave Page <[email protected]>
@ 2018-03-14 14:37 ` Khushboo Vashi <[email protected]>
2018-03-14 16:10 ` Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t Joao De Almeida Pereira <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Khushboo Vashi @ 2018-03-14 14:37 UTC (permalink / raw)
To: Dave Page <[email protected]>; Joao Pedro De Almeida Pereira <[email protected]>; [email protected]; +Cc: pgadmin-hackers
Hi Joao/Victoria,
I am getting an error while editing the server properties. Please refer the
attached screen-shot for the same.
Thanks,
Khushboo
On Wed, Mar 14, 2018 at 12:17 AM, Dave Page <[email protected]> wrote:
> Refactor server dialogue validation for better unit testing.
>
> Victoria & Joao @ Pivotal.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 6b03cb78af607b04c75de44d635bf201babb4c5a
> Author: Victoria Henry <[email protected]>
>
> Modified Files
> --------------
> web/package.json | 3 +-
> .../server_groups/servers/static/js/server.js | 113
> ++-------------------
> web/pgadmin/static/bundle/browser.js | 2 +-
> web/pgadmin/static/js/browser/index.js | 10 ++
> .../static/js/browser/server_groups/index.js | 10 ++
> .../server_groups/servers/databases/index.js | 10 ++
> .../js/browser/server_groups/servers/index.js | 11 ++
> .../server_groups/servers/model_validation.js | 104
> +++++++++++++++++++
> .../server_groups/servers/model_validation_spec.js | 101
> ++++++++++++++++++
> web/yarn.lock | 46 ++++++++-
> 10 files changed, 299 insertions(+), 111 deletions(-)
>
>
Attachments:
[image/png] Screen Shot 2018-03-14 at 8.01.46 pm.png (474.1K, 3-Screen%20Shot%202018-03-14%20at%208.01.46%20pm.png)
download | view image
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t
2018-03-13 18:47 pgAdmin 4 commit: Refactor server dialogue validation for better unit t Dave Page <[email protected]>
2018-03-14 14:37 ` Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t Khushboo Vashi <[email protected]>
@ 2018-03-14 16:10 ` Joao De Almeida Pereira <[email protected]>
2018-03-14 21:58 ` Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t Dave Page <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Joao De Almeida Pereira @ 2018-03-14 16:10 UTC (permalink / raw)
To: Khushboo Vashi <[email protected]>; +Cc: Dave Page <[email protected]>; [email protected]; pgadmin-hackers
Hi Khushboo,
Good catch, attached you can find the fix for the problem.
Thanks
Victoria & Joao
On Wed, Mar 14, 2018 at 10:37 AM Khushboo Vashi <
[email protected]> wrote:
> Hi Joao/Victoria,
>
> I am getting an error while editing the server properties. Please refer
> the attached screen-shot for the same.
>
> Thanks,
> Khushboo
>
> On Wed, Mar 14, 2018 at 12:17 AM, Dave Page <[email protected]> wrote:
>
>> Refactor server dialogue validation for better unit testing.
>>
>> Victoria & Joao @ Pivotal.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>>
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6b03cb78af607b04c75de44d635bf201babb...
>> Author: Victoria Henry <[email protected]>
>>
>> Modified Files
>> --------------
>> web/package.json | 3 +-
>> .../server_groups/servers/static/js/server.js | 113
>> ++-------------------
>> web/pgadmin/static/bundle/browser.js | 2 +-
>> web/pgadmin/static/js/browser/index.js | 10 ++
>> .../static/js/browser/server_groups/index.js | 10 ++
>> .../server_groups/servers/databases/index.js | 10 ++
>> .../js/browser/server_groups/servers/index.js | 11 ++
>> .../server_groups/servers/model_validation.js | 104
>> +++++++++++++++++++
>> .../server_groups/servers/model_validation_spec.js | 101
>> ++++++++++++++++++
>> web/yarn.lock | 46 ++++++++-
>> 10 files changed, 299 insertions(+), 111 deletions(-)
>>
>>
>
Attachments:
[text/x-patch] fix-trim-function.diff (1.3K, 3-fix-trim-function.diff)
download | inline diff:
diff --git a/web/pgadmin/static/js/browser/server_groups/servers/model_validation.js b/web/pgadmin/static/js/browser/server_groups/servers/model_validation.js
index 7ab129ba..948af3d4 100644
--- a/web/pgadmin/static/js/browser/server_groups/servers/model_validation.js
+++ b/web/pgadmin/static/js/browser/server_groups/servers/model_validation.js
@@ -99,6 +99,6 @@ export class ModelValidation {
}
static isEmptyString(string) {
- return _.isUndefined(string) || _.isNull(string) || string.trim() === '';
+ return _.isUndefined(string) || _.isNull(string) || String(string).trim() === '';
}
}
diff --git a/web/regression/javascript/browser/server_groups/servers/model_validation_spec.js b/web/regression/javascript/browser/server_groups/servers/model_validation_spec.js
index a05cd455..560d8b60 100644
--- a/web/regression/javascript/browser/server_groups/servers/model_validation_spec.js
+++ b/web/regression/javascript/browser/server_groups/servers/model_validation_spec.js
@@ -31,7 +31,7 @@ describe('Server#ModelValidation', () => {
model.isNew.and.returnValue(true);
model.allValues['name'] = 'some name';
model.allValues['username'] = 'some username';
- model.allValues['port'] = 'some port';
+ model.allValues['port'] = 12345;
});
describe('No service id', () => {
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t
2018-03-13 18:47 pgAdmin 4 commit: Refactor server dialogue validation for better unit t Dave Page <[email protected]>
2018-03-14 14:37 ` Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t Khushboo Vashi <[email protected]>
2018-03-14 16:10 ` Re: pgAdmin 4 commit: Refactor server dialogue validation for better unit t Joao De Almeida Pereira <[email protected]>
@ 2018-03-14 21:58 ` Dave Page <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Dave Page @ 2018-03-14 21:58 UTC (permalink / raw)
To: Joao De Almeida Pereira <[email protected]>; +Cc: Khushboo Vashi <[email protected]>; Victoria Henry <[email protected]>; pgadmin-hackers
Thanks, applied.
On Wed, Mar 14, 2018 at 12:10 PM, Joao De Almeida Pereira <
[email protected]> wrote:
> Hi Khushboo,
> Good catch, attached you can find the fix for the problem.
>
> Thanks
> Victoria & Joao
>
> On Wed, Mar 14, 2018 at 10:37 AM Khushboo Vashi <
> [email protected]> wrote:
>
>> Hi Joao/Victoria,
>>
>> I am getting an error while editing the server properties. Please refer
>> the attached screen-shot for the same.
>>
>> Thanks,
>> Khushboo
>>
>> On Wed, Mar 14, 2018 at 12:17 AM, Dave Page <[email protected]> wrote:
>>
>>> Refactor server dialogue validation for better unit testing.
>>>
>>> Victoria & Joao @ Pivotal.
>>>
>>> Branch
>>> ------
>>> master
>>>
>>> Details
>>> -------
>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
>>> 6b03cb78af607b04c75de44d635bf201babb4c5a
>>> Author: Victoria Henry <[email protected]>
>>>
>>> Modified Files
>>> --------------
>>> web/package.json | 3 +-
>>> .../server_groups/servers/static/js/server.js | 113
>>> ++-------------------
>>> web/pgadmin/static/bundle/browser.js | 2 +-
>>> web/pgadmin/static/js/browser/index.js | 10 ++
>>> .../static/js/browser/server_groups/index.js | 10 ++
>>> .../server_groups/servers/databases/index.js | 10 ++
>>> .../js/browser/server_groups/servers/index.js | 11 ++
>>> .../server_groups/servers/model_validation.js | 104
>>> +++++++++++++++++++
>>> .../server_groups/servers/model_validation_spec.js | 101
>>> ++++++++++++++++++
>>> web/yarn.lock | 46 ++++++++-
>>> 10 files changed, 299 insertions(+), 111 deletions(-)
>>>
>>>
>>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2018-03-14 21:58 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-03-13 18:47 pgAdmin 4 commit: Refactor server dialogue validation for better unit t Dave Page <[email protected]>
2018-03-14 14:37 ` Khushboo Vashi <[email protected]>
2018-03-14 16:10 ` Joao De Almeida Pereira <[email protected]>
2018-03-14 21:58 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox