public inbox for [email protected]
help / color / mirror / Atom feedUnable to download macros query results (reference #RM5965)
6+ messages / 2 participants
[nested] [flat]
* Unable to download macros query results (reference #RM5965)
@ 2020-11-26 13:17 Rahul Shirsat <[email protected]>
2020-11-26 13:26 ` Re: Unable to download macros query results (reference #RM5965) Dave Page <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Rahul Shirsat @ 2020-11-26 13:17 UTC (permalink / raw)
To: pgadmin-hackers
Hi Team,
Users are unable to download macros query results.
*Lets look out how download query result button works:*
For pgadmin4, always downloads the latest query result when the user makes
n-number of sql changes in the query tool, no need to execute, download
takes care of it. Does not work with macros as query is needed in the query
tool, which macros does not provide (While feature implementation, it was
decided that macros query won't be added to the query tool, as users may
lose any important queries in it).
In pgadmin3, always the last executed query result gets downloaded even if
the user makes n-number of sql changes in the query tool. Works with
macros. For the latest query change results, the user has to first execute
before every download.
For Macros, with the pgadmin4 approach, even if we implement a download
option, it would be difficult to decide whether to download the already ran
macros or to download the query result present in the query tool.
Please suggest.
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Unable to download macros query results (reference #RM5965)
2020-11-26 13:17 Unable to download macros query results (reference #RM5965) Rahul Shirsat <[email protected]>
@ 2020-11-26 13:26 ` Dave Page <[email protected]>
2020-12-09 14:01 ` Re: Unable to download macros query results (reference #RM5965) Rahul Shirsat <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Dave Page @ 2020-11-26 13:26 UTC (permalink / raw)
To: Rahul Shirsat <[email protected]>; +Cc: pgadmin-hackers
Hi
On Thu, Nov 26, 2020 at 1:18 PM Rahul Shirsat <
[email protected]> wrote:
> Hi Team,
>
> Users are unable to download macros query results.
>
> *Lets look out how download query result button works:*
>
> For pgadmin4, always downloads the latest query result when the user makes
> n-number of sql changes in the query tool, no need to execute, download
> takes care of it. Does not work with macros as query is needed in the query
> tool, which macros does not provide (While feature implementation, it was
> decided that macros query won't be added to the query tool, as users may
> lose any important queries in it).
>
> In pgadmin3, always the last executed query result gets downloaded even if
> the user makes n-number of sql changes in the query tool. Works with
> macros. For the latest query change results, the user has to first execute
> before every download.
>
> For Macros, with the pgadmin4 approach, even if we implement a download
> option, it would be difficult to decide whether to download the already ran
> macros or to download the query result present in the query tool.
>
> Please suggest.
>
I've not been happy with that for a while. The button is marked as a
download button, however, it's really "Execute and save results". That's
quite different, and could result (as at least some users have found), the
file containing different data from what's shown in the grid from a normal
execution of the query.
I think we should make it a "Save results to file" button, and clarify the
behaviour (through docs, and only enabling button when there are results to
save). It should *not* execute a query, but simply save what is currently
in the grid. The only caveat I would note is that if the grid isn't fully
populated, it should do so first (the same as we do if you select all rows).
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Unable to download macros query results (reference #RM5965)
2020-11-26 13:17 Unable to download macros query results (reference #RM5965) Rahul Shirsat <[email protected]>
2020-11-26 13:26 ` Re: Unable to download macros query results (reference #RM5965) Dave Page <[email protected]>
@ 2020-12-09 14:01 ` Rahul Shirsat <[email protected]>
2020-12-09 14:11 ` Re: Unable to download macros query results (reference #RM5965) Rahul Shirsat <[email protected]>
2020-12-10 09:30 ` Re: Unable to download macros query results (reference #RM5965) Dave Page <[email protected]>
0 siblings, 2 replies; 6+ messages in thread
From: Rahul Shirsat @ 2020-12-09 14:01 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Team/Dave,
I have changed the docs for "Download as CSV/TXT" to "Save results to file
as CSV/TXT" *(could also be just "Save results to file")*
[image: Screen Shot 2020-12-09 at 7.16.23 PM.png]
*Save results to*
*file as CSV/TXT*
Click the *Save results to file as CSV/TXT* icon to save the result set of
the current query as a *.csv* or as a *.txt* file. if *CSV field seperator* set
to comma(,) else as a *.txt* file. This button will only be enabled when
the executed query is not erroneous & returns valid results. You can
specify the CSV/TXT settings through *Preferences -> SQL Editor -> CSV/TXT
output* dialogue.
F8
And similar one liner changes in docs Developer tool -> Query tool -> The
Data Output Panel as well.
Let me know if anyone has suggestions regarding wordings.
On Thu, Nov 26, 2020 at 6:56 PM Dave Page <[email protected]> wrote:
> Hi
>
> On Thu, Nov 26, 2020 at 1:18 PM Rahul Shirsat <
> [email protected]> wrote:
>
>> Hi Team,
>>
>> Users are unable to download macros query results.
>>
>> *Lets look out how download query result button works:*
>>
>> For pgadmin4, always downloads the latest query result when the user
>> makes n-number of sql changes in the query tool, no need to execute,
>> download takes care of it. Does not work with macros as query is needed in
>> the query tool, which macros does not provide (While feature
>> implementation, it was decided that macros query won't be added to the
>> query tool, as users may lose any important queries in it).
>>
>> In pgadmin3, always the last executed query result gets downloaded even
>> if the user makes n-number of sql changes in the query tool. Works with
>> macros. For the latest query change results, the user has to first execute
>> before every download.
>>
>> For Macros, with the pgadmin4 approach, even if we implement a download
>> option, it would be difficult to decide whether to download the already ran
>> macros or to download the query result present in the query tool.
>>
>> Please suggest.
>>
>
> I've not been happy with that for a while. The button is marked as a
> download button, however, it's really "Execute and save results". That's
> quite different, and could result (as at least some users have found), the
> file containing different data from what's shown in the grid from a normal
> execution of the query.
>
> I think we should make it a "Save results to file" button, and clarify the
> behaviour (through docs, and only enabling button when there are results to
> save). It should *not* execute a query, but simply save what is currently
> in the grid. The only caveat I would note is that if the grid isn't fully
> populated, it should do so first (the same as we do if you select all rows).
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: http://www.enterprisedb.com
>
>
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
Attachments:
[image/png] Screen Shot 2020-12-09 at 7.16.23 PM.png (117.9K, 3-Screen%20Shot%202020-12-09%20at%207.16.23%20PM.png)
download | view image
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Unable to download macros query results (reference #RM5965)
2020-11-26 13:17 Unable to download macros query results (reference #RM5965) Rahul Shirsat <[email protected]>
2020-11-26 13:26 ` Re: Unable to download macros query results (reference #RM5965) Dave Page <[email protected]>
2020-12-09 14:01 ` Re: Unable to download macros query results (reference #RM5965) Rahul Shirsat <[email protected]>
@ 2020-12-09 14:11 ` Rahul Shirsat <[email protected]>
2020-12-10 09:31 ` Re: Unable to download macros query results (reference #RM5965) Dave Page <[email protected]>
1 sibling, 1 reply; 6+ messages in thread
From: Rahul Shirsat @ 2020-12-09 14:11 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Shall we consider to change the below observations as well?
[image: image.png]
What about Download CSV.. text?
[image: image.png]
On Wed, Dec 9, 2020 at 7:31 PM Rahul Shirsat <[email protected]>
wrote:
> Hi Team/Dave,
>
> I have changed the docs for "Download as CSV/TXT" to "Save results to file
> as CSV/TXT" *(could also be just "Save results to file")*
>
> [image: Screen Shot 2020-12-09 at 7.16.23 PM.png]
>
>
> *Save results to*
>
> *file as CSV/TXT*
>
>
> Click the *Save results to file as CSV/TXT* icon to save the result set
> of the current query as a *.csv* or as a *.txt* file. if *CSV field
> seperator* set to comma(,) else as a *.txt* file. This button will only
> be enabled when the executed query is not erroneous & returns valid
> results. You can specify the CSV/TXT settings through *Preferences -> SQL
> Editor -> CSV/TXT output* dialogue.
>
> F8
>
> And similar one liner changes in docs Developer tool -> Query tool -> The
> Data Output Panel as well.
>
> Let me know if anyone has suggestions regarding wordings.
>
> On Thu, Nov 26, 2020 at 6:56 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Thu, Nov 26, 2020 at 1:18 PM Rahul Shirsat <
>> [email protected]> wrote:
>>
>>> Hi Team,
>>>
>>> Users are unable to download macros query results.
>>>
>>> *Lets look out how download query result button works:*
>>>
>>> For pgadmin4, always downloads the latest query result when the user
>>> makes n-number of sql changes in the query tool, no need to execute,
>>> download takes care of it. Does not work with macros as query is needed in
>>> the query tool, which macros does not provide (While feature
>>> implementation, it was decided that macros query won't be added to the
>>> query tool, as users may lose any important queries in it).
>>>
>>> In pgadmin3, always the last executed query result gets downloaded even
>>> if the user makes n-number of sql changes in the query tool. Works with
>>> macros. For the latest query change results, the user has to first execute
>>> before every download.
>>>
>>> For Macros, with the pgadmin4 approach, even if we implement a download
>>> option, it would be difficult to decide whether to download the already ran
>>> macros or to download the query result present in the query tool.
>>>
>>> Please suggest.
>>>
>>
>> I've not been happy with that for a while. The button is marked as a
>> download button, however, it's really "Execute and save results". That's
>> quite different, and could result (as at least some users have found), the
>> file containing different data from what's shown in the grid from a normal
>> execution of the query.
>>
>> I think we should make it a "Save results to file" button, and clarify
>> the behaviour (through docs, and only enabling button when there are
>> results to save). It should *not* execute a query, but simply save what is
>> currently in the grid. The only caveat I would note is that if the grid
>> isn't fully populated, it should do so first (the same as we do if you
>> select all rows).
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
Attachments:
[image/png] Screen Shot 2020-12-09 at 7.16.23 PM.png (117.9K, 3-Screen%20Shot%202020-12-09%20at%207.16.23%20PM.png)
download | view image
[image/png] image.png (211.4K, 4-image.png)
download | view image
[image/png] image.png (131.6K, 5-image.png)
download | view image
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Unable to download macros query results (reference #RM5965)
2020-11-26 13:17 Unable to download macros query results (reference #RM5965) Rahul Shirsat <[email protected]>
2020-11-26 13:26 ` Re: Unable to download macros query results (reference #RM5965) Dave Page <[email protected]>
2020-12-09 14:01 ` Re: Unable to download macros query results (reference #RM5965) Rahul Shirsat <[email protected]>
2020-12-09 14:11 ` Re: Unable to download macros query results (reference #RM5965) Rahul Shirsat <[email protected]>
@ 2020-12-10 09:31 ` Dave Page <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Dave Page @ 2020-12-10 09:31 UTC (permalink / raw)
To: Rahul Shirsat <[email protected]>; +Cc: pgadmin-hackers
Hmm, yeah. We should at least change those to "CSV/TXT". Maybe even stop
saying CSV/TXT at all, and change everywhere (including the help I just
edited) to use phrasing like "Download Results" (preferences) and
"Downloading Results..." (busy indicator).
On Wed, Dec 9, 2020 at 2:12 PM Rahul Shirsat <[email protected]>
wrote:
> Shall we consider to change the below observations as well?
>
> [image: image.png]
>
> What about Download CSV.. text?
>
> [image: image.png]
>
> On Wed, Dec 9, 2020 at 7:31 PM Rahul Shirsat <
> [email protected]> wrote:
>
>> Hi Team/Dave,
>>
>> I have changed the docs for "Download as CSV/TXT" to "Save results to
>> file as CSV/TXT" *(could also be just "Save results to file")*
>>
>> [image: Screen Shot 2020-12-09 at 7.16.23 PM.png]
>>
>>
>> *Save results to*
>>
>> *file as CSV/TXT*
>>
>>
>> Click the *Save results to file as CSV/TXT* icon to save the result set
>> of the current query as a *.csv* or as a *.txt* file. if *CSV field
>> seperator* set to comma(,) else as a *.txt* file. This button will only
>> be enabled when the executed query is not erroneous & returns valid
>> results. You can specify the CSV/TXT settings through *Preferences ->
>> SQL Editor -> CSV/TXT output* dialogue.
>>
>> F8
>>
>> And similar one liner changes in docs Developer tool -> Query tool -> The
>> Data Output Panel as well.
>>
>> Let me know if anyone has suggestions regarding wordings.
>>
>> On Thu, Nov 26, 2020 at 6:56 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Thu, Nov 26, 2020 at 1:18 PM Rahul Shirsat <
>>> [email protected]> wrote:
>>>
>>>> Hi Team,
>>>>
>>>> Users are unable to download macros query results.
>>>>
>>>> *Lets look out how download query result button works:*
>>>>
>>>> For pgadmin4, always downloads the latest query result when the user
>>>> makes n-number of sql changes in the query tool, no need to execute,
>>>> download takes care of it. Does not work with macros as query is needed in
>>>> the query tool, which macros does not provide (While feature
>>>> implementation, it was decided that macros query won't be added to the
>>>> query tool, as users may lose any important queries in it).
>>>>
>>>> In pgadmin3, always the last executed query result gets downloaded even
>>>> if the user makes n-number of sql changes in the query tool. Works with
>>>> macros. For the latest query change results, the user has to first execute
>>>> before every download.
>>>>
>>>> For Macros, with the pgadmin4 approach, even if we implement a download
>>>> option, it would be difficult to decide whether to download the already ran
>>>> macros or to download the query result present in the query tool.
>>>>
>>>> Please suggest.
>>>>
>>>
>>> I've not been happy with that for a while. The button is marked as a
>>> download button, however, it's really "Execute and save results". That's
>>> quite different, and could result (as at least some users have found), the
>>> file containing different data from what's shown in the grid from a normal
>>> execution of the query.
>>>
>>> I think we should make it a "Save results to file" button, and clarify
>>> the behaviour (through docs, and only enabling button when there are
>>> results to save). It should *not* execute a query, but simply save what is
>>> currently in the grid. The only caveat I would note is that if the grid
>>> isn't fully populated, it should do so first (the same as we do if you
>>> select all rows).
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EDB: http://www.enterprisedb.com
>>>
>>>
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
Attachments:
[image/png] Screen Shot 2020-12-09 at 7.16.23 PM.png (117.9K, 3-Screen%20Shot%202020-12-09%20at%207.16.23%20PM.png)
download | view image
[image/png] image.png (211.4K, 4-image.png)
download | view image
[image/png] image.png (131.6K, 5-image.png)
download | view image
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Unable to download macros query results (reference #RM5965)
2020-11-26 13:17 Unable to download macros query results (reference #RM5965) Rahul Shirsat <[email protected]>
2020-11-26 13:26 ` Re: Unable to download macros query results (reference #RM5965) Dave Page <[email protected]>
2020-12-09 14:01 ` Re: Unable to download macros query results (reference #RM5965) Rahul Shirsat <[email protected]>
@ 2020-12-10 09:30 ` Dave Page <[email protected]>
1 sibling, 0 replies; 6+ messages in thread
From: Dave Page @ 2020-12-10 09:30 UTC (permalink / raw)
To: Rahul Shirsat <[email protected]>; +Cc: pgadmin-hackers
Hi
Here's some updated text:
Click the *Save results to file as CSV/TXT* icon to save the result set of
the current query as a delimited text file (CSV, if the field separator is
set to a comma). This button will only be enabled when a query has been
executed and there are results in the data grid. You can specify the
CSV/TXT settings in the Preference Dialogue under* SQL Editor -> CSV/TXT
output*.
On Wed, Dec 9, 2020 at 2:02 PM Rahul Shirsat <[email protected]>
wrote:
> Hi Team/Dave,
>
> I have changed the docs for "Download as CSV/TXT" to "Save results to file
> as CSV/TXT" *(could also be just "Save results to file")*
>
> [image: Screen Shot 2020-12-09 at 7.16.23 PM.png]
>
>
> *Save results to*
>
> *file as CSV/TXT*
>
>
> Click the *Save results to file as CSV/TXT* icon to save the result set
> of the current query as a *.csv* or as a *.txt* file. if *CSV field
> seperator* set to comma(,) else as a *.txt* file. This button will only
> be enabled when the executed query is not erroneous & returns valid
> results. You can specify the CSV/TXT settings through *Preferences -> SQL
> Editor -> CSV/TXT output* dialogue.
>
> F8
>
> And similar one liner changes in docs Developer tool -> Query tool -> The
> Data Output Panel as well.
>
> Let me know if anyone has suggestions regarding wordings.
>
> On Thu, Nov 26, 2020 at 6:56 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Thu, Nov 26, 2020 at 1:18 PM Rahul Shirsat <
>> [email protected]> wrote:
>>
>>> Hi Team,
>>>
>>> Users are unable to download macros query results.
>>>
>>> *Lets look out how download query result button works:*
>>>
>>> For pgadmin4, always downloads the latest query result when the user
>>> makes n-number of sql changes in the query tool, no need to execute,
>>> download takes care of it. Does not work with macros as query is needed in
>>> the query tool, which macros does not provide (While feature
>>> implementation, it was decided that macros query won't be added to the
>>> query tool, as users may lose any important queries in it).
>>>
>>> In pgadmin3, always the last executed query result gets downloaded even
>>> if the user makes n-number of sql changes in the query tool. Works with
>>> macros. For the latest query change results, the user has to first execute
>>> before every download.
>>>
>>> For Macros, with the pgadmin4 approach, even if we implement a download
>>> option, it would be difficult to decide whether to download the already ran
>>> macros or to download the query result present in the query tool.
>>>
>>> Please suggest.
>>>
>>
>> I've not been happy with that for a while. The button is marked as a
>> download button, however, it's really "Execute and save results". That's
>> quite different, and could result (as at least some users have found), the
>> file containing different data from what's shown in the grid from a normal
>> execution of the query.
>>
>> I think we should make it a "Save results to file" button, and clarify
>> the behaviour (through docs, and only enabling button when there are
>> results to save). It should *not* execute a query, but simply save what is
>> currently in the grid. The only caveat I would note is that if the grid
>> isn't fully populated, it should do so first (the same as we do if you
>> select all rows).
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EDB: http://www.enterprisedb.com
Attachments:
[image/png] Screen Shot 2020-12-09 at 7.16.23 PM.png (117.9K, 3-Screen%20Shot%202020-12-09%20at%207.16.23%20PM.png)
download | view image
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2020-12-10 09:31 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-11-26 13:17 Unable to download macros query results (reference #RM5965) Rahul Shirsat <[email protected]>
2020-11-26 13:26 ` Dave Page <[email protected]>
2020-12-09 14:01 ` Rahul Shirsat <[email protected]>
2020-12-09 14:11 ` Rahul Shirsat <[email protected]>
2020-12-10 09:31 ` Dave Page <[email protected]>
2020-12-10 09:30 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox