public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nagesh Dhope <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5292] Alertify header buttons focus color issue
Date: Thu, 26 Mar 2020 10:59:47 +0530
Message-ID: <CAA3zdZomS+itkbYcqs7pLocKyyipWAOVfC+ZQXE45+iLDoHw7A@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_k2LJh7Cf2ycX+mOdn0kutea0Yy8EBLryza7HyepXkiZA@mail.gmail.com>
References: <CAA3zdZo1V2-wNwQ6ghOmKrVT_sV-=hiiKiKFAnMMhuxnp3SXkg@mail.gmail.com>
<CAM9w-_k2LJh7Cf2ycX+mOdn0kutea0Yy8EBLryza7HyepXkiZA@mail.gmail.com>
Please find an updated patch, which fixes review comments.
On Thu, Mar 26, 2020 at 10:24 AM Aditya Toshniwal <
[email protected]> wrote:
> Hi Nagesh,
>
> I cannot see any change related to $active-border variable apart from
> !default. Plus, $active-border should not be allowed to edit. It is a
> structural variable and not a variable which affects theme change.
> Please revert the $active-border change and send the patch.
>
> On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Please find a patch which includes
>>
>> 1. Use *btn-secondary* styles for all buttons in alertify dialog
>> header.
>> 2. Added *!default *for $active-border variable, so that it can be
>> overridden if required.
>> 3. Added entry for *.scss *in .editorconfig
>>
>> --
>> Thanks,
>> Nagesh
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
Thanks,
Nagesh
Attachments:
[application/octet-stream] RM5292_v2.patch (817B, 3-RM5292_v2.patch)
download | inline diff:
diff --git a/web/.editorconfig b/web/.editorconfig
index f7e28ea..fb3c027 100644
--- a/web/.editorconfig
+++ b/web/.editorconfig
@@ -22,6 +22,9 @@ indent_size = 2
[*.css]
indent_size = 2
+[*.scss]
+indent_size = 2
+
# Matches the exact file package.json
[{package.json}]
indent_size = 2
diff --git a/web/pgadmin/static/scss/_alertify.overrides.scss b/web/pgadmin/static/scss/_alertify.overrides.scss
index 09cca7b..b20b5ca 100644
--- a/web/pgadmin/static/scss/_alertify.overrides.scss
+++ b/web/pgadmin/static/scss/_alertify.overrides.scss
@@ -281,8 +281,18 @@
}
-.ajs-maximize {
+.ajs-commands {
+ button {
@extend .btn-secondary;
outline: none !important;
+ }
}
+.wizard-header {
+ .ml-auto {
+ button {
+ @extend .btn-secondary;
+ outline: none !important;
+ }
+ }
+}
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM5292] Alertify header buttons focus color issue
In-Reply-To: <CAA3zdZomS+itkbYcqs7pLocKyyipWAOVfC+ZQXE45+iLDoHw7A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox