public inbox for [email protected]
help / color / mirror / Atom feedFrom: Neel Patel <[email protected]>
To: Dave Page <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab
Date: Wed, 10 May 2017 12:54:22 +0530
Message-ID: <CACCA4P12zj1Ofv8PFy+E3Yx5z9RA_3P=NrfFqXZMCkL3g2GDXQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CACCA4P3zyGfc7nFLCCiq8O4OU=ErTkmvR=mYMOQOao2-T_RJ_A@mail.gmail.com>
<CA+OCxozAs+3T-Z_rJeZd0TLDr4gbWZdhPi4pYq8UUbM0nqLzVA@mail.gmail.com>
<CANxoLDcQV7socMUmvXxL0V-E=W9LUoYzmgoMRb-s1FyYtOzrXw@mail.gmail.com>
<CA+OCxoz6QVHNEph0ENhJhttVMm6vw=b5DmoJ7HY_05M7EF-qGQ@mail.gmail.com>
<CANxoLDfXWm2482su98nXVVOvuRQMSPCn5OfX+MU_G0LE0hZpUQ@mail.gmail.com>
<CA+OCxozBE2PLLytr+8EmzMLwF_ax6xUTKcKpsN6+MYc6HWOHiQ@mail.gmail.com>
<CACCA4P0GHHgwugezQr6pVjDSmwTtNosGsmWqfMg_1wE5pRb5Rw@mail.gmail.com>
<CA+OCxowhnWSzkz64oNuGfxU-pujnNssZ5Wvu9-fT1rdfX04z5A@mail.gmail.com>
<CACCA4P0eYUkFBz5ZwC1d5gM=LYwDRAcXRGRr4gfag_9SUmhPjg@mail.gmail.com>
<CA+OCxox8pMiRyh1hX7p=1yYwzAyDuSkFLrBDOiyA2dwkVXMFPw@mail.gmail.com>
<CACCA4P1ka2ZkVPm43ZmxhCBuByuKv81LNDLt6CnHk_Ng6yFfZw@mail.gmail.com>
<CACCA4P0kRAatXGyqOQ2Kt7OpXAvCOE+=-KTNMURrvTm=aXbJ-Q@mail.gmail.com>
<[email protected]>
<CACCA4P1Zxg=YOQ9VHJYPowxfxSDWp299k=J4hwyp=Y5O+DKzvQ@mail.gmail.com>
<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Should I ask Akshay to review and commit ?
On Wed, May 10, 2017 at 12:34 PM, Dave Page <[email protected]> wrote:
> Cool :-)
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK:http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On 10 May 2017, at 08:01, Neel Patel <[email protected]> wrote:
>
> It does not give any error with standard QtWebkit.
>
> On Wed, May 10, 2017 at 12:25 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> What happens on a standard QtWebKit if we try to trigger
>> QWebPage::ToggleVideoFullscreen + 1? Does it error, or get silently
>> ignored?
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK:http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On 10 May 2017, at 07:30, Neel Patel <[email protected]> wrote:
>>
>> Hi,
>>
>> Please find attached patch file with the fix of compilation issues with
>> Qt4. Tested with both the version of Qt4 and Qt5 webkit and it is working
>> now.
>>
>> As triggerAction code will not be applicable for Qt4 so we made
>> conditional macro for Qt5 version check and for backward compatibility
>> webkit version with Qt5, as in new webkit new enum is added so we have
>> incremented with one to previous enum value which will solve the problem
>> with both old and new webkit.
>>
>> Do review it and let me know for any issue.
>>
>> Thanks,
>> Neel Patel
>>
>> On Tue, May 9, 2017 at 3:18 PM, Neel Patel <[email protected]>
>> wrote:
>>
>>> Hi Dave,
>>>
>>> On Tue, May 9, 2017 at 3:08 PM, Dave Page <[email protected]>
>>> wrote:
>>>
>>>> Hi
>>>>
>>>> On Tue, May 9, 2017 at 10:28 AM, Neel Patel <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar'
>>>>> related compilation error in Qt4. BUT
>>>>>
>>>>> Below compilation error is coming because we have not applied the
>>>>> latest patch of webkit which was fixed in annulen/webkit repo which was
>>>>> raised at below path.
>>>>>
>>>>> https://github.com/annulen/webkit/issues/519
>>>>>
>>>>> BrowserWindow.cpp:842:59: error: ‘RequestClose’ is not a member of
>>>>> ‘QWebPage’
>>>>> webviewPtr->page()->triggerAc
>>>>> tion(QWebPage::RequestClose);
>>>>>
>>>>> To fix the above compilation error currently we have two solution.
>>>>>
>>>>> - Apply the given patch in webkit ( qwebpage.cpp & qwebpage.h file
>>>>> ) .
>>>>> - Comment the below line temporary for compilation until we get
>>>>> the releases from annulen/webkit.
>>>>>
>>>>> webviewPtr->page()->triggerAc
>>>>> tion(QWebPage::RequestClose);
>>>>>
>>>>> Other compilation issues, (Me and Akshay) will fix and commit it but
>>>>> need your input on above issue.
>>>>>
>>>>
>>>> For various reasons we need to retain compatibility with the previous
>>>> versions of qtwebkit. Can we detect at build time what version we have, and
>>>> enable/disable that code as appropriate?
>>>>
>>>
>>> Make sense. We will check if we are getting any webkit version in
>>> application or not and update you.
>>>
>>>
>>>>
>>>>>
>>>>> Thanks,
>>>>> Neel Patel
>>>>>
>>>>> On Tue, May 9, 2017 at 2:02 PM, Dave Page <[email protected]>
>>>>> wrote:
>>>>>
>>>>>> It's running CentOS 7.3, with packages from EPEL:
>>>>>>
>>>>>> [dpage@jenkins ~]$ rpm -qa |grep qt
>>>>>> qt5-qtbase-common-5.6.1-10.el7.noarch
>>>>>> qt5-qtbase-devel-5.6.1-10.el7.x86_64
>>>>>> qt-4.8.5-13.el7.x86_64
>>>>>> qt5-qtbase-5.6.1-10.el7.x86_64
>>>>>> qt5-qtxmlpatterns-5.6.1-10.el7.x86_64
>>>>>> qt5-qtwebchannel-5.6.1-10.el7.x86_64
>>>>>> qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64
>>>>>> qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64
>>>>>> qt-devel-4.8.5-13.el7.x86_64
>>>>>> qt-settings-19-23.5.el7.centos.noarch
>>>>>> qt5-qtbase-gui-5.6.1-10.el7.x86_64
>>>>>> qt5-qtlocation-5.6.1-10.el7.x86_64
>>>>>> qt5-qtwebsockets-5.6.1-10.el7.x86_64
>>>>>> qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64
>>>>>> qtwebkit-2.3.4-6.el7.x86_64
>>>>>> qt3-3.3.8b-51.el7.x86_64
>>>>>> qt5-qtdeclarative-5.6.1-10.el7.x86_64
>>>>>> qt5-rpm-macros-5.6.1-10.el7.noarch
>>>>>> qtwebkit-devel-2.3.4-6.el7.x86_64
>>>>>> qt-x11-4.8.5-13.el7.x86_64
>>>>>> qt5-qtsensors-5.6.1-10.el7.x86_64
>>>>>>
>>>>>> On Tue, May 9, 2017 at 9:28 AM, Neel Patel <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> Yes, It looks like compilation fails on Qt4. We will fix this issue
>>>>>>> but which version of Qt4 we are using in Jenkins ?
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Neel Patel
>>>>>>>
>>>>>>> On Tue, May 9, 2017 at 1:56 PM, Dave Page <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>>
>>>>>>>>> On Tue, May 9, 2017 at 1:42 PM, Dave Page <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> This appears to have made Jenkins get all angry and red :-(
>>>>>>>>>>
>>>>>>>>>> https://jenkins.pgadmin.org/
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> We(Neel and I) have tested it and working fine.
>>>>>>>>>
>>>>>>>>
>>>>>>>> It clearly doesn't compile on QT4. Please review the Jenkins logs.
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>> Thanks patch applied.
>>>>>>>>>>>
>>>>>>>>>>> On Mon, May 8, 2017 at 3:21 PM, Dave Page <[email protected]>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Akshay, could you review this please?
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks.
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, May 5, 2017 at 11:53 AM, Neel Patel <
>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Please find attached patch file with the fix of RM #2328 -
>>>>>>>>>>>>> [Runtime]: Unable to launch query tool and debugger in new browser tab.
>>>>>>>>>>>>>
>>>>>>>>>>>>> I have used Qt 5.8 with webkit mentioned in below URL.
>>>>>>>>>>>>>
>>>>>>>>>>>>> https://github.com/annulen/webkit/releases
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> As there was a bug in QWebKit regarding "unload" event. We
>>>>>>>>>>>>> have raised and also they have provided patch file to fix this issue. I
>>>>>>>>>>>>> have applied the patch in linux and compile the webkit and tested the
>>>>>>>>>>>>> attached patch with compiled webkit which is now working fine.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Below is the link for reference regarding unload issue. They
>>>>>>>>>>>>> have provided test webkit release for Mac in below URL but for other
>>>>>>>>>>>>> platform we need to apply the patch and compile the webkit until they
>>>>>>>>>>>>> provide webkit-releases for all platforms.
>>>>>>>>>>>>>
>>>>>>>>>>>>> https://github.com/annulen/webkit/issues/519
>>>>>>>>>>>>>
>>>>>>>>>>>>> Do review it and let me know in case of any issue.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>> Neel Patel
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>>> Sent via pgadmin-hackers mailing list (
>>>>>>>>>>>>> [email protected])
>>>>>>>>>>>>> To make changes to your subscription:
>>>>>>>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Dave Page
>>>>>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>>>>>> Twitter: @pgsnake
>>>>>>>>>>>>
>>>>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> *Akshay Joshi*
>>>>>>>>>>> *Principal Software Engineer *
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>>>>>>>>>> 976-788-8246 <+91%2097678%2088246>*
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Dave Page
>>>>>>>>>> VP, Chief Architect, Tools & Installers
>>>>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>>>
>>>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>>>> Twitter: @pgsnake
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> *Akshay Joshi*
>>>>>>>>> *Principal Software Engineer *
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91
>>>>>>>>> 976-788-8246 <+91%2097678%2088246>*
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Page
>>>>>>>> VP, Chief Architect, Tools & Installers
>>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>> Twitter: @pgsnake
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> VP, Chief Architect, Tools & Installers
>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> VP, Chief Architect, Tools & Installers
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>
>>>
>> <webkit_compile_issue.patch>
>>
>>
>
view thread (17+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin4][runtime]: RM #2328 - Unable to launch query tool and debugger in new browser tab
In-Reply-To: <CACCA4P12zj1Ofv8PFy+E3Yx5z9RA_3P=NrfFqXZMCkL3g2GDXQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox