public inbox for [email protected]  

help / color / mirror / Atom feed

[pgAdmin4][runtime][patch]: Runtime not working in all platform
2+ messages / 2 participants
[nested] [flat]

* [pgAdmin4][runtime][patch]: Runtime not working in all platform
@ 2016-08-08 13:11 Neel Patel <[email protected]>
  2016-08-08 13:42 ` Re: [pgAdmin4][runtime][patch]: Runtime not working in all platform Dave Page <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Neel Patel @ 2016-08-08 13:11 UTC (permalink / raw)
  To: pgadmin-hackers

Hi,

Please find attached patch file to fix the below issue.

*Issue:-*
Runtime was not working in all platform due to syntax error in javascript.
This issue was introduced due to below commit.

Prevent the user attempting to run external commands if the bin path is not
configured. Fixes #1177

f78024808e80fef67de1aef5c97d1756c6771c0e

It is working in browser but Qt's web engine is not able to handle the
error and goes into infinite loop of paint event which may crash the
pgAdmin4 application.

Can you please review and commit this patch ?

Thanks,
Neel Patel


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] runtime_issue.patch (668B, 3-runtime_issue.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/templates/browser/js/browser.js b/web/pgadmin/browser/templates/browser/js/browser.js
index 95528b0..8910240 100644
--- a/web/pgadmin/browser/templates/browser/js/browser.js
+++ b/web/pgadmin/browser/templates/browser/js/browser.js
@@ -694,8 +694,8 @@ function(require, $, _, S, Bootstrap, pgAdmin, alertify, CodeMirror) {
       }
     },
 
-    get_preference(module, preference_name) {
-      preference = null;
+    get_preference: function (module, preference_name) {
+      var preference = null;
       $.ajax({
         async: false,
         url: "{{ url_for('preferences.preferences') }}" +"/"+ module +"/"+ preference_name,


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [pgAdmin4][runtime][patch]: Runtime not working in all platform
  2016-08-08 13:11 [pgAdmin4][runtime][patch]: Runtime not working in all platform Neel Patel <[email protected]>
@ 2016-08-08 13:42 ` Dave Page <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Dave Page @ 2016-08-08 13:42 UTC (permalink / raw)
  To: Neel Patel <[email protected]>; +Cc: pgadmin-hackers

Thanks, applied.

On Mon, Aug 8, 2016 at 2:11 PM, Neel Patel <[email protected]> wrote:
> Hi,
>
> Please find attached patch file to fix the below issue.
>
> Issue:-
> Runtime was not working in all platform due to syntax error in javascript.
> This issue was introduced due to below commit.
>
> Prevent the user attempting to run external commands if the bin path is not
> configured. Fixes #1177
>
> f78024808e80fef67de1aef5c97d1756c6771c0e
>
>
> It is working in browser but Qt's web engine is not able to handle the error
> and goes into infinite loop of paint event which may crash the pgAdmin4
> application.
>
> Can you please review and commit this patch ?
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2016-08-08 13:42 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-08-08 13:11 [pgAdmin4][runtime][patch]: Runtime not working in all platform Neel Patel <[email protected]>
2016-08-08 13:42 ` Dave Page <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox