public inbox for [email protected]  
help / color / mirror / Atom feed
[pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted
5+ messages / 2 participants
[nested] [flat]

* [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted
@ 2018-06-14 05:39 Khushboo Vashi <[email protected]>
  2018-06-14 07:50 ` Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted Dave Page <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Khushboo Vashi @ 2018-06-14 05:39 UTC (permalink / raw)
  To: pgadmin-hackers

Hi,

Please find the fix for #3411 - pgAdmin 4, Mac. The application server
could not be contacted

The issue is with french translation which has been taken care in the
attached patch.

Thanks,
Khushboo


Attachments:

  [text/x-patch] RM_3411.patch (872B, 3-RM_3411.patch)
  download | inline diff:
diff --git a/web/pgadmin/translations/fr/LC_MESSAGES/messages.po b/web/pgadmin/translations/fr/LC_MESSAGES/messages.po
index 54c04b9..0363c0f 100644
--- a/web/pgadmin/translations/fr/LC_MESSAGES/messages.po
+++ b/web/pgadmin/translations/fr/LC_MESSAGES/messages.po
@@ -10540,8 +10540,8 @@ msgid ""
 msgstr ""
 "Taille des caractères à utiliser dans les boites de code SQL. La valeur "
 "indiquée utilise l'unité \"em\", pour laquelle 1 est la valeur relative "
-"par défaut. Par exemple, pour augmenter la taille de 20% il faut indiquer"
-" 1.2, pour la réduire de 20% indiquer 0.8. Le minimum est 0.1, le maximum"
+"par défaut. Par exemple, pour augmenter la taille de 20 pour cent il faut indiquer"
+" 1.2, pour la réduire de 20 pour cent indiquer 0.8. Le minimum est 0.1, le maximum"
 " est 10."
 
 #: pgadmin/tools/sqleditor/utils/query_tool_preferences.py:94


^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted
  2018-06-14 05:39 [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted Khushboo Vashi <[email protected]>
@ 2018-06-14 07:50 ` Dave Page <[email protected]>
  2018-06-14 10:11   ` Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted Khushboo Vashi <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Dave Page @ 2018-06-14 07:50 UTC (permalink / raw)
  To: Khushboo Vashi <[email protected]>; +Cc: pgadmin-hackers

Hi

On Thu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi <
[email protected]> wrote:

> Hi,
>
> Please find the fix for #3411 - pgAdmin 4, Mac. The application server
> could not be contacted
>
> The issue is with french translation which has been taken care in the
> attached patch.
>

We've seen similar issues with translations before. How can we write a test
(or tests) to validate them?

One idea that springs to mind is to generate a new template against the
app, then iterate through all the translation catalogs and attempt to
translate each string that we find in the template we generated.

Alternatively, just iterate the catalogs, and grab each of the source
strings from them and attempt to translate using the same catalog.

The former method would ensure that the current state of the application
can be translated, but that of course might miss some strings in the
catalogs. The latter would validate each catalog against itself, but might
miss some strings that are in the application but haven't been merged yet
(though, that doesn't seem like it would cause a problem).

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted
  2018-06-14 05:39 [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted Khushboo Vashi <[email protected]>
  2018-06-14 07:50 ` Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted Dave Page <[email protected]>
@ 2018-06-14 10:11   ` Khushboo Vashi <[email protected]>
  2018-06-14 10:18     ` Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted Dave Page <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Khushboo Vashi @ 2018-06-14 10:11 UTC (permalink / raw)
  To: Dave Page <[email protected]>; +Cc: pgadmin-hackers

On Thu, Jun 14, 2018 at 1:20 PM, Dave Page <[email protected]> wrote:

> Hi
>
> On Thu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi <
> [email protected]> wrote:
>
>> Hi,
>>
>> Please find the fix for #3411 - pgAdmin 4, Mac. The application server
>> could not be contacted
>>
>> The issue is with french translation which has been taken care in the
>> attached patch.
>>
>
> We've seen similar issues with translations before. How can we write a
> test (or tests) to validate them?
>
> One idea that springs to mind is to generate a new template against the
> app, then iterate through all the translation catalogs and attempt to
> translate each string that we find in the template we generated.
>
> We can also use our messages.pot file as a template and attempt to
translate each string that we find in it against all the translation
catalogs.

> Alternatively, just iterate the catalogs, and grab each of the source
> strings from them and attempt to translate using the same catalog.
>
> The former method would ensure that the current state of the application
> can be translated, but that of course might miss some strings in the
> catalogs. The latter would validate each catalog against itself, but might
> miss some strings that are in the application but haven't been merged yet
> (though, that doesn't seem like it would cause a problem).
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted
  2018-06-14 05:39 [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted Khushboo Vashi <[email protected]>
  2018-06-14 07:50 ` Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted Dave Page <[email protected]>
  2018-06-14 10:11   ` Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted Khushboo Vashi <[email protected]>
@ 2018-06-14 10:18     ` Dave Page <[email protected]>
  2018-06-14 10:20       ` Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted Khushboo Vashi <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Dave Page @ 2018-06-14 10:18 UTC (permalink / raw)
  To: Khushboo Vashi <[email protected]>; +Cc: pgadmin-hackers

On Thu, Jun 14, 2018 at 11:11 AM, Khushboo Vashi <
[email protected]> wrote:

>
>
> On Thu, Jun 14, 2018 at 1:20 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Thu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> Please find the fix for #3411 - pgAdmin 4, Mac. The application server
>>> could not be contacted
>>>
>>> The issue is with french translation which has been taken care in the
>>> attached patch.
>>>
>>
>> We've seen similar issues with translations before. How can we write a
>> test (or tests) to validate them?
>>
>> One idea that springs to mind is to generate a new template against the
>> app, then iterate through all the translation catalogs and attempt to
>> translate each string that we find in the template we generated.
>>
>> We can also use our messages.pot file as a template and attempt to
> translate each string that we find in it against all the translation
> catalogs.
>

I suggested generating a new template for the test as we only occasionally
update messages.pot (typically prior to releases), so it may be out of date.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted
  2018-06-14 05:39 [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted Khushboo Vashi <[email protected]>
  2018-06-14 07:50 ` Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted Dave Page <[email protected]>
  2018-06-14 10:11   ` Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted Khushboo Vashi <[email protected]>
  2018-06-14 10:18     ` Re: [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted Dave Page <[email protected]>
@ 2018-06-14 10:20       ` Khushboo Vashi <[email protected]>
  0 siblings, 0 replies; 5+ messages in thread

From: Khushboo Vashi @ 2018-06-14 10:20 UTC (permalink / raw)
  To: Dave Page <[email protected]>; +Cc: pgadmin-hackers

On Thu, Jun 14, 2018 at 3:48 PM, Dave Page <[email protected]> wrote:

>
>
> On Thu, Jun 14, 2018 at 11:11 AM, Khushboo Vashi <
> [email protected]> wrote:
>
>>
>>
>> On Thu, Jun 14, 2018 at 1:20 PM, Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Thu, Jun 14, 2018 at 6:39 AM, Khushboo Vashi <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the fix for #3411 - pgAdmin 4, Mac. The application server
>>>> could not be contacted
>>>>
>>>> The issue is with french translation which has been taken care in the
>>>> attached patch.
>>>>
>>>
>>> We've seen similar issues with translations before. How can we write a
>>> test (or tests) to validate them?
>>>
>>> One idea that springs to mind is to generate a new template against the
>>> app, then iterate through all the translation catalogs and attempt to
>>> translate each string that we find in the template we generated.
>>>
>>> We can also use our messages.pot file as a template and attempt to
>> translate each string that we find in it against all the translation
>> catalogs.
>>
>
> I suggested generating a new template for the test as we only occasionally
> update messages.pot (typically prior to releases), so it may be out of date.
>
> Okay, we can implement this way.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2018-06-14 10:20 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-06-14 05:39 [pgAdmin4][Patch]: RM #3411 - pgAdmin 4, Mac. The application server could not be contacted Khushboo Vashi <[email protected]>
2018-06-14 07:50 ` Dave Page <[email protected]>
2018-06-14 10:11   ` Khushboo Vashi <[email protected]>
2018-06-14 10:18     ` Dave Page <[email protected]>
2018-06-14 10:20       ` Khushboo Vashi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox