public inbox for [email protected]  
help / color / mirror / Atom feed
From: Khushboo Vashi <[email protected]>
To: Sahil Harpal <[email protected]>
Cc: Aditya Toshniwal <[email protected]>
Cc: [email protected]
Cc: Ashesh Vashi <[email protected]>
Cc: Dave Page <[email protected]>
Cc: Akshay Joshi <[email protected]>
Subject: Re: Pgadmin4 System Stats Extension Design
Date: Wed, 16 Aug 2023 09:48:21 +0530
Message-ID: <CAFOhELf_c5Uz3Q2+oqGqPsnOgE9S4SSchdG2MdOoe4yyWTMpZg@mail.gmail.com> (raw)
In-Reply-To: <CAKi=nndLpXnk8i+4XX=8UV_0Fc+VBCLtYbcE9QKsfOs+0ix-VA@mail.gmail.com>
References: <CAKi=nneJvdbFyeDKnuQTVEnhNK0Zjdx5TWSwGUUSZO9YTC5E7Q@mail.gmail.com>
	<CANxoLDfO4BE0xvGLA3EBYyAzt3hCmuRcMY_pR3Zci9nPbL7P1Q@mail.gmail.com>
	<CAKi=nndnvAwgXVC=i=x3sSxNS9UCfks+EQWEjx8n5=u9CCP8og@mail.gmail.com>
	<CANxoLDeNzZkxYEnLdkFMkugvk7_k+BDSt6AoH83aaMkP+VZirQ@mail.gmail.com>
	<CAM9w-_mC2JKvxKKRwF7xCzoggoo0_XqBgUyqWDxXqSRQs_a0eg@mail.gmail.com>
	<CAKi=nncQ+OqkJ2PfvNNs40h5PfkO57YKTMEXdYeOpxUXhTzj5A@mail.gmail.com>
	<CA+OCxowriuEED8BC7DRZKwCM3dOfNaDWhf+vhJsH2PWq88yc7w@mail.gmail.com>
	<CAKi=nncY7wdMyqT2tKRAVWDaFSsgUS_qnOz0aifd-BorScUNSw@mail.gmail.com>
	<CA+OCxoyog3cqhZcEQ1xenmHUFMLM+VS8j91GM_RnU3VK8bGjaQ@mail.gmail.com>
	<CAKi=nncGiLTK36jQWnGL-0DToo4qTqojf+iLbDvRTfk2z_48Uw@mail.gmail.com>
	<CA+OCxowEmnWJHRa=QnuZpn42Cn594XZVduMPJuOg5MbdeQx0aw@mail.gmail.com>
	<CAKi=nnfMHZSGP3G+gS9JSLNp2C=BHF2ztsz6W0mpBREc4y=hiQ@mail.gmail.com>
	<CA+OCxowt2XSCEOxZ+Mz1CzMGQv5MCNV+GZO2b3E5PtZj1YgYOA@mail.gmail.com>
	<CAKi=nndoS4g8MmOBD6wZKCtGotpmxDa17rq8-obv3B9MaSbYjg@mail.gmail.com>
	<CA+OCxozjkCkVOFabHbMP+1sZ+hKftXA6Z8q00c+A2=mYHKbcuQ@mail.gmail.com>
	<CAKi=nncko8TQVyGtEn_89DtZoztdhOA_e2-wSe8wROjZADgbXg@mail.gmail.com>
	<CAKi=nnfj2OcTBkUoWwMZ5YifExgrxs9Pbt42-2W1+n32LEmgvQ@mail.gmail.com>
	<CAG7mmow-bPFycSZeY_-=JbhmdH7qHud2GHiiZTfcNPhnsruQaA@mail.gmail.com>
	<CAKi=nnfeEf6dQYcDyUExJK+1Xo5NgCHrpgfZPjS56B2rrUmd=w@mail.gmail.com>
	<CAM9w-_=-jmhjh9Mp98pvwBxp_DDoeMexnR2Y23+=-wR+tsDOiQ@mail.gmail.com>
	<CAKi=nneNLFiOUPQ16ZzO1RM8K8V=qoqa=AtmewkRzLjnjJhyUA@mail.gmail.com>
	<CAFOhELe-EAiVN6YjmAo1VjW-b+Bw3yPC6Ghxy=X6P-y4EF_EgA@mail.gmail.com>
	<CAKi=nndAi2iBN1P5y+XWdTa9EnL5b_FzhK4AG_9duUKxZE5=fw@mail.gmail.com>
	<CAKi=nndU8oESoER=MF7yaaUKiNd1fV7GDECGgLv_jumxs8EmTQ@mail.gmail.com>
	<CAFOhELdpnz1o-CYCmH=3x2u6XMWDXd6gbiWejL3dMq+LSu8QDQ@mail.gmail.com>
	<CAFOhELdT30L7OYj3MbQtkaHLHaRuMP3inV4t_wHkiJBOiJ=8TA@mail.gmail.com>
	<CAKi=nncg3M=ZE9JTzVYb-ox83quNO8i_=C3_34AhX1wckk0mbA@mail.gmail.com>
	<CAM9w-_=5Dnu4Dn9tg77GtAtaV7=vgyeSqkq0uLkt_c_K1Om2rg@mail.gmail.com>
	<CAKi=nncNHn9D8L-R3HmBPGN+zcBsbg_ceXE3O-XoASwMq-pzKg@mail.gmail.com>
	<CAM9w-_=KM9+onud=Co54voWNZXymOzzCkmMxfCjkU_-sNOOViQ@mail.gmail.com>
	<CAKi=nncRPLHwHZ+53vFuF7sB87tTLYXEbD4FPVnAbt8qhLonug@mail.gmail.com>
	<CAM9w-_nJWCnnQvXozGgrXVwhJwQ3hfeFZfKe+mKJHM5nox2AhA@mail.gmail.com>
	<CAKi=nndLpXnk8i+4XX=8UV_0Fc+VBCLtYbcE9QKsfOs+0ix-VA@mail.gmail.com>

Can you please rebase the patch and send it again?

On Thu, Aug 10, 2023 at 12:37 AM Sahil Harpal <[email protected]>
wrote:

> Hi all,
>
> I have attached the updated patch with recent changes.
>
> New changes:
>
>    1. Displayed the appropriate message If the System Stat extension does
>    not exist.
>    2. Provided option to configure refresh rates for the API calls
>    (Preferences settings > Dashboards > Refresh rates).
>    3. Added I/O analysis of block devices under the storage tab.
>    4. Fixed PEP-8 errors.
>    5. Fixed the linter errors.
>    6. Moved all the system stats related .jsx files under a
>    seperate folder "dashboard/static/js/SystemStats".
>    7. Added formatter to convert disk sizes (in bytes) to human readable
>    format.
>
> Pending Work:
>
>    1. Process information -
>       - Issue: The pg_sys_process_info() query takes much longer (more
>       than 2 mins) to execute and prevents the updation of other graphs and
>       tables.
>    2. Disk information -
>       - Issue: The pg_sys_disk_info() query returns NULL value for some
>       of the drive letters.
>    3. StreamingChart -
>       - Issue: Graph shifting glitch. For the first time, graphs start
>       from the opposite side, and after the following API call or a few seconds
>       later, those get adjusted.
>
> I need suggestions for labels for different tables and charts. Also, could
> you please clarify the use of the counterData variable, which is used for
> some of the charts (tps_stats, ti_stats, to_stats, and bio_stats)?
>
> Thank you,
> Sahil
>
>


view thread (106+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Pgadmin4 System Stats Extension Design
  In-Reply-To: <CAFOhELf_c5Uz3Q2+oqGqPsnOgE9S4SSchdG2MdOoe4yyWTMpZg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox