public inbox for [email protected]  

help / color / mirror / Atom feed

From: Matthew Kleiman <[email protected]>
To: Dave Page <[email protected]>
Cc: Joao Pedro De Almeida Pereira <[email protected]>
Cc: Murtuza Zabuawala <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React
Date: Wed, 24 May 2017 09:36:20 -0400
Message-ID: <CAFS4TJaZA0U_BtiUBdx1jT6Z5bQzMQbjhwrjimDLgfkTb=gWJg@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoxkM--KjFWt7FkJm+mrL5sA9jdZ59YN7=n=2ZMrkH8iSg@mail.gmail.com>
References: <CAFS4TJYDRi6fs+wrhkj89gFe3xaFOkoApCK+AU2O4DfU2XfXog@mail.gmail.com>
	<CAKKotZQSTtJVkBKMeFi9vTrPugBEbEE38dhbbn-hr+hpd0Qzbw@mail.gmail.com>
	<CA+OCxowChMtZzaSwrG5Sganh4LiMQcgL7BpoqhTxZga30DqDXw@mail.gmail.com>
	<CAKKotZRmvbScMdUtjMgUJdRe-EXaqDoDbYBxrMZrkbVDVR_iUg@mail.gmail.com>
	<CA+OCxow3e=q9w_e=Kkw1ebZJ82EM8RyFmiTaXihdqhX6HbzZhw@mail.gmail.com>
	<CAFS4TJapVubRP_BK01GwYjfN7zpaTbCMX+CROC4mV93aL08DOg@mail.gmail.com>
	<CA+OCxozPDpP_5zdLjOSQhiGHgzE-QDsFv8-WyC8-XTxf5+uSJg@mail.gmail.com>
	<CAE+jjakzXbzvtai0Z2q0bXfecMhDzZwtn+p8mQwV7kfRGPON_Q@mail.gmail.com>
	<CA+OCxoxkM--KjFWt7FkJm+mrL5sA9jdZ59YN7=n=2ZMrkH8iSg@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi Dave,

This one is our bad! We didn't create a grunt task to run the tests only
once, as you would in CI. grunt tests currently runs the tests and
continues to watch for changes, running the tests again each time the
source code is modified. We will create a task that is suitable to run in
CI.

In the meantime, if you have any free time during the day today and would
like to schedule a sync call with us, that would help us to tighten the
feedback loop.

Thanks,
Joao & Matt

On Tue, May 23, 2017 at 4:44 PM, Dave Page <[email protected]> wrote:

> On Tue, May 23, 2017 at 12:12 PM, Joao Pedro De Almeida Pereira
> <[email protected]> wrote:
> > Okay
> >
> > Can you try removing web/node_modules and web/yarn.lock, and running
> > $ yarn install
> > $ grunt tests
> >
> > We think this might be due to a bad version of phantomjs-prebuilt.
> >
> > If that still fails, can you try running grunt as "yarn run grunt tests"?
>
> I'm on a different machine now, and here grunt just seems to never
> exit when it's doing anything. For example, I ran this a few minutes
> ago, it finished in seconds and has been sitting here ever since:
>
> (pgadmin4)snake:web dpage$ grunt tests
> Running "eslint:target" (eslint) task
>
> Running "karma:unit" (karma) task
>
> webpack: Compiled successfully.
> webpack: Compiling...
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> webpack: wait until bundle finished:
> (node:4902) DeprecationWarning: loaderUtils.parseQuery() received a
> non-string value which can be problematic, see
> https://github.com/webpack/loader-utils/issues/56
> parseQuery() will be replaced with getOptions() in the next major
> version of loader-utils.
> 23 05 2017 16:41:54.549:WARN [karma]: No captured browser, open
> http://localhost:9876/
>
> webpack: Compiled successfully.
> PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 87 of 88 (skipped 1)
> SUCCESS (1.353 secs / 1.328 secs)
>
> I'm quite unimpressed with it so far :-(
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

view thread (45+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React
  In-Reply-To: <CAFS4TJaZA0U_BtiUBdx1jT6Z5bQzMQbjhwrjimDLgfkTb=gWJg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox