public inbox for [email protected]
help / color / mirror / Atom feedFrom: Pradip Parkale <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.
Date: Tue, 6 Jul 2021 15:00:47 +0530
Message-ID: <CAJ9T6Su5FFVhrfc66tPRd2wBZQRKOFhrsmP2dibeA_d9UKfzFA@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDfVQFCZxhDGP22gpRNj6euYO+MZaZRujaxQJi+bWL97mQ@mail.gmail.com>
References: <CAJ9T6St7o5QTO1R2KSsvZAviCw0jK0u6MWsgUAtRzpkDQQpA+A@mail.gmail.com>
<CANxoLDe9U1a6oOxJ+xy6cBHyghmCKgMpv6X7fqj9knSUU4FjBw@mail.gmail.com>
<CAJ9T6SsW9VB+J8UAbMXtpapuA_Dx8qX25BOdTLrkq=O+zCbVqw@mail.gmail.com>
<CANxoLDe0Wq9cNE5qMEJQXoTHuVW_fPS-78PJhGRNyoV8xQujtg@mail.gmail.com>
<CAJ9T6Sv5CrVWBSm=BSJmH5rD5n0VG3Yr4n_vyg4KOWqzV_cadQ@mail.gmail.com>
<CANxoLDfVQFCZxhDGP22gpRNj6euYO+MZaZRujaxQJi+bWL97mQ@mail.gmail.com>
Hi Akshay,
Please find the updated patch.
On Fri, Jun 25, 2021 at 11:40 AM Akshay Joshi <[email protected]>
wrote:
> Thanks, the patch applied.
>
> On Thu, Jun 24, 2021 at 9:16 PM Pradip Parkale <
> [email protected]> wrote:
>
>> Hi Akshay,
>> Please find the updated patch. I have moved the function into the utility
>> file now.
>>
>> On Thu, Jun 24, 2021 at 7:56 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Pradip
>>>
>>> I have seen that we have duplicated code for resize_the_queryTool,
>>> resize_the_erdtool, resize_the_psql, and in debugger_ui.js file. I
>>> would suggest making a common function somewhere in the utils and call that
>>> function. In the future, if we need to change the code we will have to
>>> change it in four different places.
>>>
>>> Please resend the patch after fixing the above issue.
>>>
>>> On Thu, Jun 24, 2021 at 7:00 PM Pradip Parkale <
>>> [email protected]> wrote:
>>>
>>>> Hi Akshay,
>>>>
>>>> Please find attached for debugger and ERD tool which was missing in
>>>> my previous patch.
>>>>
>>>> On Wed, Jun 23, 2021 at 11:50 AM Akshay Joshi <
>>>> [email protected]> wrote:
>>>>
>>>>> Thanks, the patch applied.
>>>>>
>>>>> On Wed, Jun 16, 2021 at 11:29 PM Pradip Parkale <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Please find the attached patch for #6398.Detaching query editor panel
>>>>>> gives a blank white panel.
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Thanks & Regards,
>>>>>> Pradip Parkale
>>>>>> Software Engineer | EnterpriseDB Corporation
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards*
>>>>> *Akshay Joshi*
>>>>> *pgAdmin Hacker | Principal Software Architect*
>>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>>
>>>>> *Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks & Regards,
>>>> Pradip Parkale
>>>> Software Engineer | EnterpriseDB Corporation
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> Software Engineer | EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachments:
[application/octet-stream] RM6398_v4.patch (1.9K, 3-RM6398_v4.patch)
download | inline diff:
diff --git a/web/pgadmin/tools/debugger/static/js/debugger.js b/web/pgadmin/tools/debugger/static/js/debugger.js
index 13ff1f3af..6632b83c1 100644
--- a/web/pgadmin/tools/debugger/static/js/debugger.js
+++ b/web/pgadmin/tools/debugger/static/js/debugger.js
@@ -614,6 +614,7 @@ define([
'frm_debugger', wcDocker.DOCK.STACKED, dashboardPanel[0]
),
db_label = newTreeInfo.database.label;
+ pgadminUtils.registerDetachEvent(panel);
if(data && data.data_obj && data.data_obj.db_name != newTreeInfo.database.label) {
db_label = data.data_obj.db_name;
diff --git a/web/pgadmin/tools/schema_diff/static/js/schema_diff.js b/web/pgadmin/tools/schema_diff/static/js/schema_diff.js
index 4f132c069..2c257c87f 100644
--- a/web/pgadmin/tools/schema_diff/static/js/schema_diff.js
+++ b/web/pgadmin/tools/schema_diff/static/js/schema_diff.js
@@ -9,9 +9,9 @@
define('pgadmin.schemadiff', [
'sources/gettext', 'sources/url_for', 'jquery', 'underscore',
- 'sources/pgadmin', 'sources/csrf', 'pgadmin.alertifyjs', 'pgadmin.browser.node',
+ 'sources/pgadmin', 'sources/csrf', 'pgadmin.alertifyjs', 'sources/utils', 'pgadmin.browser.node',
], function(
- gettext, url_for, $, _, pgAdmin, csrfToken, Alertify,
+ gettext, url_for, $, _, pgAdmin, csrfToken, Alertify, commonUtils,
) {
var wcDocker = window.wcDocker,
@@ -119,6 +119,8 @@ define('pgadmin.schemadiff', [
var propertiesPanel = pgBrowser.docker.findPanels('properties'),
schemaDiffPanel = pgBrowser.docker.addPanel('frm_schemadiff', wcDocker.DOCK.STACKED, propertiesPanel[0]);
+ commonUtils.registerDetachEvent(schemaDiffPanel);
+
// Rename schema diff tab
schemaDiffPanel.on(wcDocker.EVENT.RENAME, function(panel_data) {
Alertify.prompt('', panel_data.$titleText[0].textContent,
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.
In-Reply-To: <CAJ9T6Su5FFVhrfc66tPRd2wBZQRKOFhrsmP2dibeA_d9UKfzFA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox