public inbox for [email protected]
help / color / mirror / Atom feedpgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317
3+ messages / 2 participants
[nested] [flat]
* pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317
@ 2018-03-15 07:57 Akshay Joshi <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Akshay Joshi @ 2018-03-15 07:57 UTC (permalink / raw)
To: pgadmin-hackers
Sporadically crashes on Windows when exit. Fixes #3177
1) Shutdown the python server properly.
2) Disabled "Shutdown server" menu till server is not successfully started.
Initial patch sent by Maxim, modified by Akshay Joshi.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=54b1a79cb6f90ac9b26db57e616dc750fb2c...
Author: Maxim Zakharov <[email protected]>
Modified Files
--------------
runtime/Server.cpp | 11 +++++++++++
runtime/Server.h | 3 +++
runtime/TrayIcon.cpp | 11 +++++++++++
runtime/TrayIcon.h | 4 ++++
runtime/pgAdmin4.cpp | 46 ++++++++++++++++++++++++++++++++++++++++++++
runtime/pgAdmin4.h | 1 +
web/pgadmin/misc/__init__.py | 16 ++++++++++++++-
7 files changed, 91 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317
@ 2018-03-15 10:33 Murtuza Zabuawala <[email protected]>
parent: Akshay Joshi <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Murtuza Zabuawala @ 2018-03-15 10:33 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers
Hi Akshay,
Given commit introduce PEP8 issue, PFA minor patch to fix the issue.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Mar 15, 2018 at 1:27 PM, Akshay Joshi <[email protected]
> wrote:
> Sporadically crashes on Windows when exit. Fixes #3177
> 1) Shutdown the python server properly.
> 2) Disabled "Shutdown server" menu till server is not successfully
> started.
>
> Initial patch sent by Maxim, modified by Akshay Joshi.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 54b1a79cb6f90ac9b26db57e616dc750fb2c6b54
> Author: Maxim Zakharov <[email protected]>
>
> Modified Files
> --------------
> runtime/Server.cpp | 11 +++++++++++
> runtime/Server.h | 3 +++
> runtime/TrayIcon.cpp | 11 +++++++++++
> runtime/TrayIcon.h | 4 ++++
> runtime/pgAdmin4.cpp | 46 ++++++++++++++++++++++++++++++
> ++++++++++++++
> runtime/pgAdmin4.h | 1 +
> web/pgadmin/misc/__init__.py | 16 ++++++++++++++-
> 7 files changed, 91 insertions(+), 1 deletion(-)
>
>
Attachments:
[application/octet-stream] fix_PEP8.diff (462B, 3-fix_PEP8.diff)
download | inline diff:
diff --git a/web/pgadmin/misc/__init__.py b/web/pgadmin/misc/__init__.py
index 848e6ee..19e1828 100644
--- a/web/pgadmin/misc/__init__.py
+++ b/web/pgadmin/misc/__init__.py
@@ -117,6 +117,7 @@ def explain_js():
mimetype="application/javascript"
)
+
##########################################################################
# A special URL used to shutdown the server
##########################################################################
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317
@ 2018-03-15 10:44 Akshay Joshi <[email protected]>
parent: Murtuza Zabuawala <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Akshay Joshi @ 2018-03-15 10:44 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Thanks patch applied
On Thu, Mar 15, 2018 at 4:03 PM, Murtuza Zabuawala <
[email protected]> wrote:
> Hi Akshay,
>
> Given commit introduce PEP8 issue, PFA minor patch to fix the issue.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Thu, Mar 15, 2018 at 1:27 PM, Akshay Joshi <
> [email protected]> wrote:
>
>> Sporadically crashes on Windows when exit. Fixes #3177
>> 1) Shutdown the python server properly.
>> 2) Disabled "Shutdown server" menu till server is not successfully
>> started.
>>
>> Initial patch sent by Maxim, modified by Akshay Joshi.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>> f;h=54b1a79cb6f90ac9b26db57e616dc750fb2c6b54
>> Author: Maxim Zakharov <[email protected]>
>>
>> Modified Files
>> --------------
>> runtime/Server.cpp | 11 +++++++++++
>> runtime/Server.h | 3 +++
>> runtime/TrayIcon.cpp | 11 +++++++++++
>> runtime/TrayIcon.h | 4 ++++
>> runtime/pgAdmin4.cpp | 46 ++++++++++++++++++++++++++++++
>> ++++++++++++++
>> runtime/pgAdmin4.h | 1 +
>> web/pgadmin/misc/__init__.py | 16 ++++++++++++++-
>> 7 files changed, 91 insertions(+), 1 deletion(-)
>>
>>
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2018-03-15 10:44 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-03-15 07:57 pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317 Akshay Joshi <[email protected]>
2018-03-15 10:33 ` Murtuza Zabuawala <[email protected]>
2018-03-15 10:44 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox