public inbox for [email protected]
help / color / mirror / Atom feedPATCH: Fixed typo in Server node
2+ messages / 2 participants
[nested] [flat]
* PATCH: Fixed typo in Server node
@ 2016-05-06 10:14 Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Murtuza Zabuawala @ 2016-05-06 10:14 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
Looks like below given commit has left a typo in the code, I’m getting
error while updating any Server node,
*Commit:*
0628ee04 web/pgadmin/browser/server_groups/servers/__init__.py (Dave Page
2016-05-05 16:42:16 +0100 377)
node=self.blueprint.generate_browser_node(
*Error:*
* return method(*args, **kwargs)*
* File
"/Users/murtuza/Desktop/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py",
line 385, in update*
* server_type='pg' # default server type*
*TypeError: make_json_response() got an unexpected keyword argument ‘node'*
PFA patch to fix the issue.
Regards,
Murtuza
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/octet-stream] fixed_typo.patch (659B, 3-fixed_typo.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/pgadmin/browser/server_groups/servers/__init__.py
index ac1d32f..3bc0717 100644
--- a/web/pgadmin/browser/server_groups/servers/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/__init__.py
@@ -374,7 +374,7 @@ class ServerNode(PGChildNodeView):
return make_json_response(
success=1,
- node=self.blueprint.generate_browser_node(
+ data=self.blueprint.generate_browser_node(
"%d" % (server.id), server.servergroup_id,
server.name,
"icon-server-not-connected" if not connected else
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: PATCH: Fixed typo in Server node
@ 2016-05-06 12:58 Dave Page <[email protected]>
parent: Murtuza Zabuawala <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Dave Page @ 2016-05-06 12:58 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Thanks - applied.
On Fri, May 6, 2016 at 11:14 AM, Murtuza Zabuawala
<[email protected]> wrote:
> Hi,
>
> Looks like below given commit has left a typo in the code, I’m getting error
> while updating any Server node,
>
> Commit:
> 0628ee04 web/pgadmin/browser/server_groups/servers/__init__.py (Dave Page
> 2016-05-05 16:42:16 +0100 377)
> node=self.blueprint.generate_browser_node(
>
> Error:
> return method(*args, **kwargs)
> File
> "/Users/murtuza/Desktop/pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py",
> line 385, in update
> server_type='pg' # default server type
> TypeError: make_json_response() got an unexpected keyword argument ‘node'
>
>
>
> PFA patch to fix the issue.
>
>
>
> Regards,
> Murtuza
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2016-05-06 12:58 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-05-06 10:14 PATCH: Fixed typo in Server node Murtuza Zabuawala <[email protected]>
2016-05-06 12:58 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox