Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

public inbox for [email protected]  
help / color / mirror / Atom feed

From: Murtuza Zabuawala <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
Date: Tue, 27 Feb 2018 20:39:39 +0530
Message-ID: <CAKKotZRnze=prpL7ohQJPsZkoKE8C8+eGvWAVNQ1CQqUTxS7iA@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxowhpCOc8puFNRzxPArGyHg5ZB01C-Cpb0xVGy3h-WWWpQ@mail.gmail.com>
References: <CAKKotZR-a320X7Jq30Nf+wWNk13z_TV-DLPsZNdaZHw9wj5oiQ@mail.gmail.com>
	<CA+OCxoy7sOE1xUZWtdyi2UJjJucQCTjcJy=ep21KqsbXEi-Bsw@mail.gmail.com>
	<CAKKotZQ_QLJ+pgz0Q8Tjg3-oOezG7OTUXDSgg_SYXm2pX4itgQ@mail.gmail.com>
	<CA+OCxox8yPw33SHwvTmbtDJcgCjYx2nMZf3dFFk6hk0A6=HX3w@mail.gmail.com>
	<CAKKotZSbDqjKKNaprnXM7eEW3wR1ffbDbmmh2B-xqtybUVv_Bw@mail.gmail.com>
	<CA+OCxoxWZUZX1KAXr+_xyagF8Zai21C7YAC_Sfb5ZJwm-ywMLA@mail.gmail.com>
	<CAKKotZTA_zDhuarKGhqYVaGf0u7bb72uvaJoWkOdRPWKmDqPyg@mail.gmail.com>
	<CA+OCxowhpCOc8puFNRzxPArGyHg5ZB01C-Cpb0xVGy3h-WWWpQ@mail.gmail.com>

Thanks Dave, I'll look into it.



On Tue, Feb 27, 2018 at 8:37 PM, Dave Page <[email protected]> wrote:

> Hi
>
> On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> I'm not able to re-produce the issue, Could you hard refresh and try
>> again?
>>
>
> I still see it.
>
>
>>
>> If possible could you please provide exact steps?
>>
>
> Attached is a dump of my test pgagent schema.
>
> 1) Load the schema dump into the maintenance database
> 2) Connect pgAdmin
> 3) Browse to pgAgent Jobs
> 4) Right-click Properties, and select the Schedules tab
> 5) Open the subnode for sched1
>
>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Tue, Feb 27, 2018 at 5:30 PM, Dave Page <[email protected]> wrote:
>>
>>> Sorry - here it is.
>>>
>>> On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala <
>>> [email protected]> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> Could you please send screenshot?
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> Still not quite right - see the attached screenshot which is the
>>>>> result of simply viewing the properties of an existing job. Note that the
>>>>> start time is shown in the grid but not the subnode control.
>>>>>
>>>>> Thanks.
>>>>>
>>>>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> As validation related patch was committed with RM#3148 [ Sorry about
>>>>>> that I forgot to checkout :) ]
>>>>>> PFA patch to fix the issues you mentioned, I have also removed extra
>>>>>> error message from sub node collection control and made it optional via
>>>>>> flag.
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Murtuza Zabuawala
>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>>
>>>>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page <[email protected]>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi
>>>>>>>
>>>>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> PFA patch to fix the issue where user was not able to create
>>>>>>>> pgAgent job from UI without entering End date in schedule section.
>>>>>>>>
>>>>>>>
>>>>>>>  Whilst this does resolve the validation issue, there are still a
>>>>>>> couple of other related problems, as can be seen in the attached
>>>>>>> screenshots:
>>>>>>>
>>>>>>> - The Start date/time in the subnode control doesn't seem to be
>>>>>>> properly synchronised with the value in the grid.
>>>>>>>
>>>>>>> - If you leave the End date/time blank (but maybe click into it
>>>>>>> first), the grid will show "Invalid date".
>>>>>>>
>>>>>>> It's possible there are other oddities as well - please check
>>>>>>> carefully for anything else.
>>>>>>>
>>>>>>> Thanks.
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>> Twitter: @pgsnake
>>>>>>>
>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
  In-Reply-To: <CAKKotZRnze=prpL7ohQJPsZkoKE8C8+eGvWAVNQ1CQqUTxS7iA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox