public inbox for [email protected]  
help / color / mirror / Atom feed
From: Sahil Harpal <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: [email protected]
Subject: Re: Pgadmin4 System Stats Extension Design
Date: Wed, 16 Aug 2023 15:25:26 +0530
Message-ID: <CAKi=nne+h-g5nGqjgTYcnsRTK3H=LJg=HwwWq9zGanuVPEpTQw@mail.gmail.com> (raw)
In-Reply-To: <CAKi=nndANyD4HYYCi_W42bgUGUaA0aCr+xQHbx-djU2uMQOtng@mail.gmail.com>
References: <CAKi=nneJvdbFyeDKnuQTVEnhNK0Zjdx5TWSwGUUSZO9YTC5E7Q@mail.gmail.com>
	<CANxoLDfO4BE0xvGLA3EBYyAzt3hCmuRcMY_pR3Zci9nPbL7P1Q@mail.gmail.com>
	<CAKi=nndnvAwgXVC=i=x3sSxNS9UCfks+EQWEjx8n5=u9CCP8og@mail.gmail.com>
	<CANxoLDeNzZkxYEnLdkFMkugvk7_k+BDSt6AoH83aaMkP+VZirQ@mail.gmail.com>
	<CAM9w-_mC2JKvxKKRwF7xCzoggoo0_XqBgUyqWDxXqSRQs_a0eg@mail.gmail.com>
	<CAKi=nncQ+OqkJ2PfvNNs40h5PfkO57YKTMEXdYeOpxUXhTzj5A@mail.gmail.com>
	<CA+OCxowriuEED8BC7DRZKwCM3dOfNaDWhf+vhJsH2PWq88yc7w@mail.gmail.com>
	<CAKi=nncY7wdMyqT2tKRAVWDaFSsgUS_qnOz0aifd-BorScUNSw@mail.gmail.com>
	<CA+OCxoyog3cqhZcEQ1xenmHUFMLM+VS8j91GM_RnU3VK8bGjaQ@mail.gmail.com>
	<CAKi=nncGiLTK36jQWnGL-0DToo4qTqojf+iLbDvRTfk2z_48Uw@mail.gmail.com>
	<CA+OCxowEmnWJHRa=QnuZpn42Cn594XZVduMPJuOg5MbdeQx0aw@mail.gmail.com>
	<CAKi=nnfMHZSGP3G+gS9JSLNp2C=BHF2ztsz6W0mpBREc4y=hiQ@mail.gmail.com>
	<CA+OCxowt2XSCEOxZ+Mz1CzMGQv5MCNV+GZO2b3E5PtZj1YgYOA@mail.gmail.com>
	<CAKi=nndoS4g8MmOBD6wZKCtGotpmxDa17rq8-obv3B9MaSbYjg@mail.gmail.com>
	<CA+OCxozjkCkVOFabHbMP+1sZ+hKftXA6Z8q00c+A2=mYHKbcuQ@mail.gmail.com>
	<CAKi=nncko8TQVyGtEn_89DtZoztdhOA_e2-wSe8wROjZADgbXg@mail.gmail.com>
	<CAKi=nnfj2OcTBkUoWwMZ5YifExgrxs9Pbt42-2W1+n32LEmgvQ@mail.gmail.com>
	<CAG7mmow-bPFycSZeY_-=JbhmdH7qHud2GHiiZTfcNPhnsruQaA@mail.gmail.com>
	<CAKi=nnfeEf6dQYcDyUExJK+1Xo5NgCHrpgfZPjS56B2rrUmd=w@mail.gmail.com>
	<CAM9w-_=-jmhjh9Mp98pvwBxp_DDoeMexnR2Y23+=-wR+tsDOiQ@mail.gmail.com>
	<CAKi=nneNLFiOUPQ16ZzO1RM8K8V=qoqa=AtmewkRzLjnjJhyUA@mail.gmail.com>
	<CAFOhELe-EAiVN6YjmAo1VjW-b+Bw3yPC6Ghxy=X6P-y4EF_EgA@mail.gmail.com>
	<CAKi=nndAi2iBN1P5y+XWdTa9EnL5b_FzhK4AG_9duUKxZE5=fw@mail.gmail.com>
	<CAKi=nndU8oESoER=MF7yaaUKiNd1fV7GDECGgLv_jumxs8EmTQ@mail.gmail.com>
	<CAFOhELdpnz1o-CYCmH=3x2u6XMWDXd6gbiWejL3dMq+LSu8QDQ@mail.gmail.com>
	<CAFOhELdT30L7OYj3MbQtkaHLHaRuMP3inV4t_wHkiJBOiJ=8TA@mail.gmail.com>
	<CAKi=nncg3M=ZE9JTzVYb-ox83quNO8i_=C3_34AhX1wckk0mbA@mail.gmail.com>
	<CAM9w-_=5Dnu4Dn9tg77GtAtaV7=vgyeSqkq0uLkt_c_K1Om2rg@mail.gmail.com>
	<CAKi=nncNHn9D8L-R3HmBPGN+zcBsbg_ceXE3O-XoASwMq-pzKg@mail.gmail.com>
	<CAM9w-_=KM9+onud=Co54voWNZXymOzzCkmMxfCjkU_-sNOOViQ@mail.gmail.com>
	<CAKi=nncRPLHwHZ+53vFuF7sB87tTLYXEbD4FPVnAbt8qhLonug@mail.gmail.com>
	<CAM9w-_nJWCnnQvXozGgrXVwhJwQ3hfeFZfKe+mKJHM5nox2AhA@mail.gmail.com>
	<CAKi=nndLpXnk8i+4XX=8UV_0Fc+VBCLtYbcE9QKsfOs+0ix-VA@mail.gmail.com>
	<CAFOhELf_c5Uz3Q2+oqGqPsnOgE9S4SSchdG2MdOoe4yyWTMpZg@mail.gmail.com>
	<CAKi=nnfk6Na=kV+41xssMEp2vMoHB8f4rRiKwKwKcgN4KDodJQ@mail.gmail.com>
	<CAKi=nndANyD4HYYCi_W42bgUGUaA0aCr+xQHbx-djU2uMQOtng@mail.gmail.com>

I have pushed the recent changes to my GitHub repository.
If you are still unable to apply the patch, you can pull it from here. In
the meantime, I'll check what might be wrong with this patch file.
link - https://github.com/Sahil1479/pgadmin4/tree/system_stats

On Wed, 16 Aug 2023 at 11:51, Sahil Harpal <[email protected]>
wrote:

> I've noticed something here. I cleared all the errors using 'yarn run
> bundle:dev,' except for the unused 'counterData' variable, which I'll
> correct soon. But when I attempted to apply this patch on a freshly cloned
> repository, it displayed the following warnings. However, it didn't fail,
> and all the files and folders were created successfully.
> [image: image.png]
> I removed all the whitespaces before creating the patch, and I have also
> checked all these lines where it is showing the trailing whitespace, but
> there are no trailing whitespaces. The 'yarn run bundle:dev' command also
> does not give any prompt for this. Could you please suggest what to do?
>
>
> On Wed, 16 Aug 2023 at 11:08, Sahil Harpal <[email protected]>
> wrote:
>
>> Could you please try this attached patch.
>>
>


Attachments:

  [image/png] image.png (24.4K, 3-image.png)
  download | view image

view thread (106+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Pgadmin4 System Stats Extension Design
  In-Reply-To: <CAKi=nne+h-g5nGqjgTYcnsRTK3H=LJg=HwwWq9zGanuVPEpTQw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox