public inbox for [email protected]help / color / mirror / Atom feed
[pgAdmin4][Patch]: Ensure errorModel unset property properly in Server 5+ messages / 2 participants [nested] [flat]
* [pgAdmin4][Patch]: Ensure errorModel unset property properly in Server @ 2016-09-30 12:53 Surinder Kumar <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Surinder Kumar @ 2016-09-30 12:53 UTC (permalink / raw) To: pgadmin-hackers Hi When we add new server and enter an invalid port, it validates and display error message, but sometimes it doesn't unset errorModel when a valid value is entered. Please find attached patch and review. Thanks, Surinder Kumar -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers Attachments: [application/octet-stream] ensure_errormodel_unset_properly.patch (973B, 3-ensure_errormodel_unset_properly.patch) download | inline diff: diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js index fa68818..1d96de0 100644 --- a/web/pgadmin/static/js/backform.pgadmin.js +++ b/web/pgadmin/static/js/backform.pgadmin.js @@ -1573,6 +1573,7 @@ // After validation we need to set that value into model (only if all flags are true) if (isValid) { this.stopListening(this.model, "change:" + name, this.render); + this.model.errorModel.unset(name); this.model.set(name, value); this.listenTo(this.model, "change:" + name, this.render); } else { @@ -1666,6 +1667,7 @@ // After validation we need to set that value into model (only if all flags are true) if (isValid) { this.stopListening(this.model, "change:" + name, this.render); + this.model.errorModel.unset(name); this.model.set(name, value); this.listenTo(this.model, "change:" + name, this.render); } else { ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [pgAdmin4][Patch]: Ensure errorModel unset property properly in Server @ 2016-09-30 13:02 Dave Page <[email protected]> parent: Surinder Kumar <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Dave Page @ 2016-09-30 13:02 UTC (permalink / raw) To: Surinder Kumar <[email protected]>; +Cc: pgadmin-hackers Is there an RM for this? If not, can you create one please? I want to be sure we capture all notable changes in Redmine. Thanks! On Fri, Sep 30, 2016 at 1:53 PM, Surinder Kumar <[email protected]> wrote: > Hi > > When we add new server and enter an invalid port, it validates and display > error message, but sometimes it doesn't unset errorModel when a valid value > is entered. > > Please find attached patch and review. > > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list ([email protected]) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [pgAdmin4][Patch]: Ensure errorModel unset property properly in Server @ 2016-09-30 13:08 Surinder Kumar <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Surinder Kumar @ 2016-09-30 13:08 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers Dave, I have created RM #1786 <https://redmine.postgresql.org/issues/1786; On Fri, Sep 30, 2016 at 6:32 PM, Dave Page <[email protected]> wrote: > Is there an RM for this? If not, can you create one please? I want to > be sure we capture all notable changes in Redmine. > > Thanks! > > On Fri, Sep 30, 2016 at 1:53 PM, Surinder Kumar > <[email protected]> wrote: > > Hi > > > > When we add new server and enter an invalid port, it validates and > display > > error message, but sometimes it doesn't unset errorModel when a valid > value > > is entered. > > > > Please find attached patch and review. > > > > > > Thanks, > > Surinder Kumar > > > > > > -- > > Sent via pgadmin-hackers mailing list ([email protected]) > > To make changes to your subscription: > > http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [pgAdmin4][Patch]: Ensure errorModel unset property properly in Server @ 2016-09-30 13:24 Dave Page <[email protected]> parent: Surinder Kumar <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Dave Page @ 2016-09-30 13:24 UTC (permalink / raw) To: Surinder Kumar <[email protected]>; +Cc: pgadmin-hackers Thanks. On Fri, Sep 30, 2016 at 2:08 PM, Surinder Kumar <[email protected]> wrote: > Dave, I have created RM #1786 > > On Fri, Sep 30, 2016 at 6:32 PM, Dave Page <[email protected]> wrote: >> >> Is there an RM for this? If not, can you create one please? I want to >> be sure we capture all notable changes in Redmine. >> >> Thanks! >> >> On Fri, Sep 30, 2016 at 1:53 PM, Surinder Kumar >> <[email protected]> wrote: >> > Hi >> > >> > When we add new server and enter an invalid port, it validates and >> > display >> > error message, but sometimes it doesn't unset errorModel when a valid >> > value >> > is entered. >> > >> > Please find attached patch and review. >> > >> > >> > Thanks, >> > Surinder Kumar >> > >> > >> > -- >> > Sent via pgadmin-hackers mailing list ([email protected]) >> > To make changes to your subscription: >> > http://www.postgresql.org/mailpref/pgadmin-hackers >> > >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [pgAdmin4][Patch]: Ensure errorModel unset property properly in Server @ 2016-10-03 12:51 Dave Page <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Dave Page @ 2016-10-03 12:51 UTC (permalink / raw) To: Surinder Kumar <[email protected]>; +Cc: pgadmin-hackers Thanks, committed. On Fri, Sep 30, 2016 at 2:24 PM, Dave Page <[email protected]> wrote: > Thanks. > > On Fri, Sep 30, 2016 at 2:08 PM, Surinder Kumar > <[email protected]> wrote: >> Dave, I have created RM #1786 >> >> On Fri, Sep 30, 2016 at 6:32 PM, Dave Page <[email protected]> wrote: >>> >>> Is there an RM for this? If not, can you create one please? I want to >>> be sure we capture all notable changes in Redmine. >>> >>> Thanks! >>> >>> On Fri, Sep 30, 2016 at 1:53 PM, Surinder Kumar >>> <[email protected]> wrote: >>> > Hi >>> > >>> > When we add new server and enter an invalid port, it validates and >>> > display >>> > error message, but sometimes it doesn't unset errorModel when a valid >>> > value >>> > is entered. >>> > >>> > Please find attached patch and review. >>> > >>> > >>> > Thanks, >>> > Surinder Kumar >>> > >>> > >>> > -- >>> > Sent via pgadmin-hackers mailing list ([email protected]) >>> > To make changes to your subscription: >>> > http://www.postgresql.org/mailpref/pgadmin-hackers >>> > >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >> >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2016-10-03 12:51 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2016-09-30 12:53 [pgAdmin4][Patch]: Ensure errorModel unset property properly in Server Surinder Kumar <[email protected]> 2016-09-30 13:02 ` Dave Page <[email protected]> 2016-09-30 13:08 ` Surinder Kumar <[email protected]> 2016-09-30 13:24 ` Dave Page <[email protected]> 2016-10-03 12:51 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox