public inbox for [email protected]help / color / mirror / Atom feed
[pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output 4+ messages / 3 participants [nested] [flat]
* [pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output @ 2019-01-29 09:35 Akshay Joshi <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Akshay Joshi @ 2019-01-29 09:35 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, Attached is the patch to fix RM 3697 Detached Data Output Tab (Windows) does not show Select output. Please review it. -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* Attachments: [application/octet-stream] RM_3697.patch (627B, 3-RM_3697.patch) download | inline diff: diff --git a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js index 885d02b..97a8e18 100644 --- a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js +++ b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js @@ -801,7 +801,7 @@ define('tools.querytool', [ autoEdit: false, }; - var $data_grid = self.$el.find('#datagrid'); + var $data_grid = $('#datagrid'); // Calculate height based on panel size at runtime & set it var grid_height = $($('#editor-panel').find('.wcFrame')[1]).height() - 35; $data_grid.height(grid_height); ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output @ 2019-01-29 11:24 Dave Page <[email protected]> parent: Akshay Joshi <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Dave Page @ 2019-01-29 11:24 UTC (permalink / raw) To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers Aditya, can you review this please? Once you're happy, Akshay can commit. On Tue, Jan 29, 2019 at 9:35 AM Akshay Joshi <[email protected]> wrote: > Hi Hackers, > > Attached is the patch to fix RM 3697 Detached Data Output Tab (Windows) > does not show Select output. Please review it. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output @ 2019-01-29 12:57 Aditya Toshniwal <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Aditya Toshniwal @ 2019-01-29 12:57 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Akshay Joshi <[email protected]>; pgadmin-hackers Hi Akshay, The patch looks good to me. On Tue, Jan 29, 2019 at 4:54 PM Dave Page <[email protected]> wrote: > Aditya, can you review this please? Once you're happy, Akshay can commit. > > On Tue, Jan 29, 2019 at 9:35 AM Akshay Joshi < > [email protected]> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix RM 3697 Detached Data Output Tab (Windows) >> does not show Select output. Please review it. >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output @ 2019-01-29 13:20 Akshay Joshi <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Akshay Joshi @ 2019-01-29 13:20 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers On Tue, Jan 29, 2019 at 6:27 PM Aditya Toshniwal < [email protected]> wrote: > Hi Akshay, > > The patch looks good to me. > Thanks patch applied. > > On Tue, Jan 29, 2019 at 4:54 PM Dave Page <[email protected]> wrote: > >> Aditya, can you review this please? Once you're happy, Akshay can commit. >> >> On Tue, Jan 29, 2019 at 9:35 AM Akshay Joshi < >> [email protected]> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch to fix RM 3697 Detached Data Output Tab (Windows) >>> does not show Select output. Please review it. >>> >>> -- >>> *Akshay Joshi* >>> >>> *Sr. Software Architect * >>> >>> >>> >>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2019-01-29 13:20 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-01-29 09:35 [pgAdmin4][Patch]: RM 3697 Detached Data Output Tab (Windows) does not show Select output Akshay Joshi <[email protected]> 2019-01-29 11:24 ` Dave Page <[email protected]> 2019-01-29 12:57 ` Aditya Toshniwal <[email protected]> 2019-01-29 13:20 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox