public inbox for [email protected]help / color / mirror / Atom feed
Regarding non-ascii characters in the path for Windows installer 4+ messages / 2 participants [nested] [flat]
* Regarding non-ascii characters in the path for Windows installer @ 2025-01-16 11:22 Akshay Joshi <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Akshay Joshi @ 2025-01-16 11:22 UTC (permalink / raw) To: pgadmin-hackers Hi Dave/Hackers I am looking into issue 5204 <https://github.com/pgadmin-org/pgadmin4/issues/5204; where the pgAdmin 4 Windows installer throws an error of "Please provide a valid path," when the user name contains non-ASCII characters. We have added a function IsPathValid to validate the path in the " installer.iss.in" file, because of this function Windows installer throws an error. [image: Code.png] Can we remove this logic? Thoughts/Suggestions? Akshay Joshi Principle Software Architect enterprisedb.com * Blog*: https://www.enterprisedb.com/akshay-joshi * GitHub*: https://github.com/akshay-joshi * LinkedIn*: https://www.linkedin.com/in/akshay-joshi-086497216 Attachments: [image/png] Code.png (121.9K, 3-Code.png) download | view image ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Regarding non-ascii characters in the path for Windows installer @ 2025-01-17 12:01 Dave Page <[email protected]> parent: Akshay Joshi <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Dave Page @ 2025-01-17 12:01 UTC (permalink / raw) To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers Hi On Thu, 16 Jan 2025 at 11:23, Akshay Joshi <[email protected]> wrote: > Hi Dave/Hackers > > I am looking into issue 5204 > <https://github.com/pgadmin-org/pgadmin4/issues/5204; where the pgAdmin 4 > Windows installer throws an error of "Please provide a valid path," when > the user name contains non-ASCII characters. > > We have added a function IsPathValid to validate the path in the " > installer.iss.in" file, because of this function Windows installer throws > an error. > > [image: Code.png] > Can we remove this logic? Thoughts/Suggestions? > I don't think we can just remove it - if memory serves, we added it because we ran into issues in some cases. Obviously we can't do an exhaustive test, but can we confirm that pgAdmin will work with at least some non-ASCII characters in the path, e.g. some accented characters, Kanji, Cyrillic etc? -- Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org pgEdge: https://www.pgedge.com Attachments: [image/png] Code.png (121.9K, 3-Code.png) download | view image ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Regarding non-ascii characters in the path for Windows installer @ 2025-01-20 08:26 Akshay Joshi <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Akshay Joshi @ 2025-01-20 08:26 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers On Fri, Jan 17, 2025 at 5:32 PM Dave Page <[email protected]> wrote: > Hi > > On Thu, 16 Jan 2025 at 11:23, Akshay Joshi <[email protected]> > wrote: > >> Hi Dave/Hackers >> >> I am looking into issue 5204 >> <https://github.com/pgadmin-org/pgadmin4/issues/5204; where the pgAdmin >> 4 Windows installer throws an error of "Please provide a valid path," when >> the user name contains non-ASCII characters. >> >> We have added a function IsPathValid to validate the path in the " >> installer.iss.in" file, because of this function Windows installer >> throws an error. >> >> [image: Code.png] >> Can we remove this logic? Thoughts/Suggestions? >> > > I don't think we can just remove it - if memory serves, we added it > because we ran into issues in some cases. Obviously we can't do an > exhaustive test, but can we confirm that pgAdmin will work with at > least some non-ASCII characters in the path, e.g. some accented characters, > Kanji, Cyrillic etc? > We added this function in 2017 to address issue #1365 <https://redmine.postgresql.org/issues/1365;. The issue reported that pgAdmin would not launch after installation. At that time, we were using QT (Mingw), which is no longer used. For testing purposes, I removed the function call from the installer.iss.in file and conducted tests using the following username: [image: Screenshot 2025-01-20 at 1.30.44 PM.png] The user names mentioned above include accented characters, Kanji, and Cyrillic scripts. pgAdmin 4 was installed and ran successfully without any issues. Let's remove that function. Thoughts/Suggestions? > -- > Dave Page > pgAdmin: https://www.pgadmin.org > PostgreSQL: https://www.postgresql.org > pgEdge: https://www.pgedge.com > > Attachments: [image/png] Code.png (121.9K, 3-Code.png) download | view image [image/png] Screenshot 2025-01-20 at 1.30.44 PM.png (451.7K, 4-Screenshot%202025-01-20%20at%201.30.44%E2%80%AFPM.png) download | view image ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Regarding non-ascii characters in the path for Windows installer @ 2025-01-20 09:04 Dave Page <[email protected]> parent: Akshay Joshi <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Dave Page @ 2025-01-20 09:04 UTC (permalink / raw) To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers On Mon, 20 Jan 2025 at 08:26, Akshay Joshi <[email protected]> wrote: > > > On Fri, Jan 17, 2025 at 5:32 PM Dave Page <[email protected]> wrote: > >> Hi >> >> On Thu, 16 Jan 2025 at 11:23, Akshay Joshi <[email protected]> >> wrote: >> >>> Hi Dave/Hackers >>> >>> I am looking into issue 5204 >>> <https://github.com/pgadmin-org/pgadmin4/issues/5204; where the pgAdmin >>> 4 Windows installer throws an error of "Please provide a valid path," when >>> the user name contains non-ASCII characters. >>> >>> We have added a function IsPathValid to validate the path in the " >>> installer.iss.in" file, because of this function Windows installer >>> throws an error. >>> >>> [image: Code.png] >>> Can we remove this logic? Thoughts/Suggestions? >>> >> >> I don't think we can just remove it - if memory serves, we added it >> because we ran into issues in some cases. Obviously we can't do an >> exhaustive test, but can we confirm that pgAdmin will work with at >> least some non-ASCII characters in the path, e.g. some accented characters, >> Kanji, Cyrillic etc? >> > > We added this function in 2017 to address issue #1365 > <https://redmine.postgresql.org/issues/1365;. The issue reported that > pgAdmin would not launch after installation. At that time, we were using QT > (Mingw), which is no longer used. > For testing purposes, I removed the function call from the > installer.iss.in file and conducted tests using the following username: > > [image: Screenshot 2025-01-20 at > 1.30.44 PM.png] > > The user names mentioned above include accented characters, Kanji, and > Cyrillic scripts. pgAdmin 4 was installed and ran successfully without any > issues. > Let's remove that function. Thoughts/Suggestions? > Seems reasonable to me, given the original motivation and your testing. Thank you! -- Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org pgEdge: https://www.pgedge.com Attachments: [image/png] Code.png (121.9K, 3-Code.png) download | view image [image/png] Screenshot 2025-01-20 at 1.30.44 PM.png (451.7K, 4-Screenshot%202025-01-20%20at%201.30.44%E2%80%AFPM.png) download | view image ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-01-20 09:04 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-01-16 11:22 Regarding non-ascii characters in the path for Windows installer Akshay Joshi <[email protected]> 2025-01-17 12:01 ` Dave Page <[email protected]> 2025-01-20 08:26 ` Akshay Joshi <[email protected]> 2025-01-20 09:04 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox