public inbox for [email protected]help / color / mirror / Atom feed
pgAdmin4 v4.10 candidate builds 7+ messages / 3 participants [nested] [flat]
* pgAdmin4 v4.10 candidate builds @ 2019-06-28 15:21 Akshay Joshi <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Akshay Joshi @ 2019-06-28 15:21 UTC (permalink / raw) To: pgadmin-hackers; Fahar Abbas <[email protected]> Hi All, Due to an showstopper issue found in pgAdmin v4.9, we will have to release pgAdmin4 v4.10 early. Candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-06-28-1/ Fahar, can you please verify it for release on Tuesday (2nd July). -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgAdmin4 v4.10 candidate builds @ 2019-07-02 05:25 Fahar Abbas <[email protected]> parent: Akshay Joshi <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Fahar Abbas @ 2019-07-02 05:25 UTC (permalink / raw) To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers Hi, Here is the showstopper issue for pgadmin4 4.10: https://redmine.postgresql.org/issues/4421 Kind Regards, On Fri, Jun 28, 2019 at 8:21 PM Akshay Joshi <[email protected]> wrote: > Hi All, > > Due to an showstopper issue found in pgAdmin v4.9, we will have to release > pgAdmin4 v4.10 early. Candidate builds and source can be found at > https://developer.pgadmin.org/builds/2019-06-28-1/ > > Fahar, can you please verify it for release on Tuesday (2nd July). > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Fahar Abbas QMG EnterpriseDB Corporation Phone Office: +92-51-835-8874 Phone Direct: +92-51-8466803 Mobile: +92-333-5409707 Skype ID: *live:fahar.abbas* Website: www.enterprisedb.com ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgAdmin4 v4.10 candidate builds @ 2019-07-02 11:08 Akshay Joshi <[email protected]> parent: Fahar Abbas <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Akshay Joshi @ 2019-07-02 11:08 UTC (permalink / raw) To: Fahar Abbas <[email protected]>; +Cc: pgadmin-hackers Hi Fahar We have fixed RM #4421. Candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-07-02-1/ . There is some problem with the wheel packages, will check that. Meanwhile can you please test the builds for upgrade issue. On Tue, Jul 2, 2019 at 10:55 AM Fahar Abbas <[email protected]> wrote: > Hi, > > Here is the showstopper issue for pgadmin4 4.10: > > https://redmine.postgresql.org/issues/4421 > > Kind Regards, > > On Fri, Jun 28, 2019 at 8:21 PM Akshay Joshi < > [email protected]> wrote: > >> Hi All, >> >> Due to an showstopper issue found in pgAdmin v4.9, we will have to >> release pgAdmin4 v4.10 early. Candidate builds and source can be found >> at https://developer.pgadmin.org/builds/2019-06-28-1/ >> >> Fahar, can you please verify it for release on Tuesday (2nd July). >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Fahar Abbas > QMG > EnterpriseDB Corporation > Phone Office: +92-51-835-8874 > Phone Direct: +92-51-8466803 > Mobile: +92-333-5409707 > Skype ID: *live:fahar.abbas* > Website: www.enterprisedb.com > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgAdmin4 v4.10 candidate builds @ 2019-07-02 12:01 Aditya Toshniwal <[email protected]> parent: Akshay Joshi <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Aditya Toshniwal @ 2019-07-02 12:01 UTC (permalink / raw) To: Akshay Joshi <[email protected]>; +Cc: Fahar Abbas <[email protected]>; pgadmin-hackers Hi, The issue still persists. I have checked the code and found that CompareVersions(Version, '{#MyAppFullVersion}') = -1, this should be 1 and not -1. Attached is the patch. Sorry for trouble to build again. :/ On Tue, Jul 2, 2019 at 4:39 PM Akshay Joshi <[email protected]> wrote: > Hi Fahar > > We have fixed RM #4421. Candidate builds and source can be found at > https://developer.pgadmin.org/builds/2019-07-02-1/ . > There is some problem with the wheel packages, will check that. Meanwhile > can you please test the builds for upgrade issue. > > On Tue, Jul 2, 2019 at 10:55 AM Fahar Abbas <[email protected]> > wrote: > >> Hi, >> >> Here is the showstopper issue for pgadmin4 4.10: >> >> https://redmine.postgresql.org/issues/4421 >> >> Kind Regards, >> >> On Fri, Jun 28, 2019 at 8:21 PM Akshay Joshi < >> [email protected]> wrote: >> >>> Hi All, >>> >>> Due to an showstopper issue found in pgAdmin v4.9, we will have to >>> release pgAdmin4 v4.10 early. Candidate builds and source can be found >>> at https://developer.pgadmin.org/builds/2019-06-28-1/ >>> >>> Fahar, can you please verify it for release on Tuesday (2nd July). >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Fahar Abbas >> QMG >> EnterpriseDB Corporation >> Phone Office: +92-51-835-8874 >> Phone Direct: +92-51-8466803 >> Mobile: +92-333-5409707 >> Skype ID: *live:fahar.abbas* >> Website: www.enterprisedb.com >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" Attachments: [application/octet-stream] win.ver_compare_v3.patch (622B, 3-win.ver_compare_v3.patch) download | inline diff: diff --git a/pkg/win32/installer.iss.in b/pkg/win32/installer.iss.in index 7fda5b0d..7deb925f 100644 --- a/pkg/win32/installer.iss.in +++ b/pkg/win32/installer.iss.in @@ -179,7 +179,7 @@ begin begin UpgradeMode := True; RegQueryStringValue(HKEY_LOCAL_MACHINE,'Software\{#MyAppName}\{#MyAppVersion}', 'Version', Version); - if CompareVersions(Version, '{#MyAppFullVersion}') = -1 then + if CompareVersions(Version, '{#MyAppFullVersion}') = 1 then begin MsgBox(ExpandConstant('{cm:NewerVersionExists}' + '(v' + Version + ') is already installed' ), mbInformation, MB_OK); Result := False; ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgAdmin4 v4.10 candidate builds @ 2019-07-02 14:43 Akshay Joshi <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Akshay Joshi @ 2019-07-02 14:43 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: Fahar Abbas <[email protected]>; pgadmin-hackers Thanks patch applied. On Tue, Jul 2, 2019 at 5:31 PM Aditya Toshniwal < [email protected]> wrote: > Hi, > > The issue still persists. I have checked the code and found that > CompareVersions(Version, '{#MyAppFullVersion}') = -1, this should be 1 > and not -1. > Attached is the patch. > > Sorry for trouble to build again. :/ > > > On Tue, Jul 2, 2019 at 4:39 PM Akshay Joshi <[email protected]> > wrote: > >> Hi Fahar >> >> We have fixed RM #4421. Candidate builds and source can be found at >> https://developer.pgadmin.org/builds/2019-07-02-1/ . >> There is some problem with the wheel packages, will check that. Meanwhile >> can you please test the builds for upgrade issue. >> >> On Tue, Jul 2, 2019 at 10:55 AM Fahar Abbas <[email protected]> >> wrote: >> >>> Hi, >>> >>> Here is the showstopper issue for pgadmin4 4.10: >>> >>> https://redmine.postgresql.org/issues/4421 >>> >>> Kind Regards, >>> >>> On Fri, Jun 28, 2019 at 8:21 PM Akshay Joshi < >>> [email protected]> wrote: >>> >>>> Hi All, >>>> >>>> Due to an showstopper issue found in pgAdmin v4.9, we will have to >>>> release pgAdmin4 v4.10 early. Candidate builds and source can be found >>>> at https://developer.pgadmin.org/builds/2019-06-28-1/ >>>> >>>> Fahar, can you please verify it for release on Tuesday (2nd July). >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect* >>>> *EnterpriseDB Software India Private Limited* >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Fahar Abbas >>> QMG >>> EnterpriseDB Corporation >>> Phone Office: +92-51-835-8874 >>> Phone Direct: +92-51-8466803 >>> Mobile: +92-333-5409707 >>> Skype ID: *live:fahar.abbas* >>> Website: www.enterprisedb.com >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgAdmin4 v4.10 candidate builds @ 2019-07-02 16:27 Akshay Joshi <[email protected]> parent: Akshay Joshi <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Akshay Joshi @ 2019-07-02 16:27 UTC (permalink / raw) To: Fahar Abbas <[email protected]>; pgadmin-hackers Hi Fahar, Candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-07-02-3/ Please verify the upgrade scenario and rest of the testing for the release on Thursday 4th July. On Tue, Jul 2, 2019 at 8:13 PM Akshay Joshi <[email protected]> wrote: > Thanks patch applied. > > On Tue, Jul 2, 2019 at 5:31 PM Aditya Toshniwal < > [email protected]> wrote: > >> Hi, >> >> The issue still persists. I have checked the code and found that >> CompareVersions(Version, '{#MyAppFullVersion}') = -1, this should be 1 >> and not -1. >> Attached is the patch. >> >> Sorry for trouble to build again. :/ >> >> >> On Tue, Jul 2, 2019 at 4:39 PM Akshay Joshi < >> [email protected]> wrote: >> >>> Hi Fahar >>> >>> We have fixed RM #4421. Candidate builds and source can be found at >>> https://developer.pgadmin.org/builds/2019-07-02-1/ . >>> There is some problem with the wheel packages, will check that. >>> Meanwhile can you please test the builds for upgrade issue. >>> >>> On Tue, Jul 2, 2019 at 10:55 AM Fahar Abbas < >>> [email protected]> wrote: >>> >>>> Hi, >>>> >>>> Here is the showstopper issue for pgadmin4 4.10: >>>> >>>> https://redmine.postgresql.org/issues/4421 >>>> >>>> Kind Regards, >>>> >>>> On Fri, Jun 28, 2019 at 8:21 PM Akshay Joshi < >>>> [email protected]> wrote: >>>> >>>>> Hi All, >>>>> >>>>> Due to an showstopper issue found in pgAdmin v4.9, we will have to >>>>> release pgAdmin4 v4.10 early. Candidate builds and source can be >>>>> found at https://developer.pgadmin.org/builds/2019-06-28-1/ >>>>> >>>>> Fahar, can you please verify it for release on Tuesday (2nd July). >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> >>>>> *Sr. Software Architect* >>>>> *EnterpriseDB Software India Private Limited* >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>>> -- >>>> Fahar Abbas >>>> QMG >>>> EnterpriseDB Corporation >>>> Phone Office: +92-51-835-8874 >>>> Phone Direct: +92-51-8466803 >>>> Mobile: +92-333-5409707 >>>> Skype ID: *live:fahar.abbas* >>>> Website: www.enterprisedb.com >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> >>> *Sr. Software Architect* >>> *EnterpriseDB Software India Private Limited* >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgAdmin4 v4.10 candidate builds @ 2019-07-04 11:58 Fahar Abbas <[email protected]> parent: Akshay Joshi <[email protected]> 0 siblings, 0 replies; 7+ messages in thread From: Fahar Abbas @ 2019-07-04 11:58 UTC (permalink / raw) To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers One Round of testing has been completed for pgadmin4 4.10 and we can release it. On Tue, Jul 2, 2019 at 9:27 PM Akshay Joshi <[email protected]> wrote: > Hi Fahar, > > Candidate builds and source can be found at > https://developer.pgadmin.org/builds/2019-07-02-3/ > Please verify the upgrade scenario and rest of the testing for the release > on Thursday 4th July. > > On Tue, Jul 2, 2019 at 8:13 PM Akshay Joshi <[email protected]> > wrote: > >> Thanks patch applied. >> >> On Tue, Jul 2, 2019 at 5:31 PM Aditya Toshniwal < >> [email protected]> wrote: >> >>> Hi, >>> >>> The issue still persists. I have checked the code and found that >>> CompareVersions(Version, '{#MyAppFullVersion}') = -1, this should be 1 >>> and not -1. >>> Attached is the patch. >>> >>> Sorry for trouble to build again. :/ >>> >>> >>> On Tue, Jul 2, 2019 at 4:39 PM Akshay Joshi < >>> [email protected]> wrote: >>> >>>> Hi Fahar >>>> >>>> We have fixed RM #4421. Candidate builds and source can be found at >>>> https://developer.pgadmin.org/builds/2019-07-02-1/ . >>>> There is some problem with the wheel packages, will check that. >>>> Meanwhile can you please test the builds for upgrade issue. >>>> >>>> On Tue, Jul 2, 2019 at 10:55 AM Fahar Abbas < >>>> [email protected]> wrote: >>>> >>>>> Hi, >>>>> >>>>> Here is the showstopper issue for pgadmin4 4.10: >>>>> >>>>> https://redmine.postgresql.org/issues/4421 >>>>> >>>>> Kind Regards, >>>>> >>>>> On Fri, Jun 28, 2019 at 8:21 PM Akshay Joshi < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi All, >>>>>> >>>>>> Due to an showstopper issue found in pgAdmin v4.9, we will have to >>>>>> release pgAdmin4 v4.10 early. Candidate builds and source can be >>>>>> found at https://developer.pgadmin.org/builds/2019-06-28-1/ >>>>>> >>>>>> Fahar, can you please verify it for release on Tuesday (2nd July). >>>>>> -- >>>>>> *Thanks & Regards* >>>>>> *Akshay Joshi* >>>>>> >>>>>> *Sr. Software Architect* >>>>>> *EnterpriseDB Software India Private Limited* >>>>>> *Mobile: +91 976-788-8246* >>>>>> >>>>> >>>>> >>>>> -- >>>>> Fahar Abbas >>>>> QMG >>>>> EnterpriseDB Corporation >>>>> Phone Office: +92-51-835-8874 >>>>> Phone Direct: +92-51-8466803 >>>>> Mobile: +92-333-5409707 >>>>> Skype ID: *live:fahar.abbas* >>>>> Website: www.enterprisedb.com >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect* >>>> *EnterpriseDB Software India Private Limited* >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Fahar Abbas QMG EnterpriseDB Corporation Phone Office: +92-51-835-8874 Phone Direct: +92-51-8466803 Mobile: +92-333-5409707 Skype ID: *live:fahar.abbas* Website: www.enterprisedb.com ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2019-07-04 11:58 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-06-28 15:21 pgAdmin4 v4.10 candidate builds Akshay Joshi <[email protected]> 2019-07-02 05:25 ` Fahar Abbas <[email protected]> 2019-07-02 11:08 ` Akshay Joshi <[email protected]> 2019-07-02 12:01 ` Aditya Toshniwal <[email protected]> 2019-07-02 14:43 ` Akshay Joshi <[email protected]> 2019-07-02 16:27 ` Akshay Joshi <[email protected]> 2019-07-04 11:58 ` Fahar Abbas <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox