public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Pradip Parkale <[email protected]>
Cc: Aditya Toshniwal <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5154] [Accessibility] : Alertify
Date: Tue, 25 Feb 2020 18:26:00 +0530
Message-ID: <CANxoLDfG8-OzFDAqumdTrk4KdONTCicw_5Ma-x1nqhRJf+_M0Q@mail.gmail.com> (raw)
In-Reply-To: <CAJ9T6SuA5a0pYGMduuvpZnqXfvKmaOC45v9jc-mZm1DQ8bH=sA@mail.gmail.com>
References: <CAJ9T6SsEuKBVz35pA0X+G7u6Z0JcV8ZAHB46kRD1PiovmJrhpg@mail.gmail.com>
<CAG7mmoy5TCYNYPcD31FG=-jHzRJG7pdiNrFVXsFnVNKY+Qp8VQ@mail.gmail.com>
<CAJ9T6Su8cJBL4khVrE1h4U8d0EAyiadLyseFaoKEtJ6-tJ_rgA@mail.gmail.com>
<CANxoLDeefWqrFZHSyTE4Ugh2Dity0cUwoHNaMZemtRnqt-pfEA@mail.gmail.com>
<CAM9w-_n9oO0Dz5sVb+wHkqbmzsS8gZdG-DJ7h9DELgoa9kk42A@mail.gmail.com>
<CAJ9T6SuA5a0pYGMduuvpZnqXfvKmaOC45v9jc-mZm1DQ8bH=sA@mail.gmail.com>
Thanks, patch applied.
On Tue, Feb 25, 2020 at 3:32 PM Pradip Parkale <
[email protected]> wrote:
> Hi Akshay/Aditya,
>
> Please find the updated patch. I have accommodated all the changes.
>
>
> On Mon, Feb 24, 2020 at 2:34 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Pradip,
>>
>> -
>> commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.tab-content
>> div.active'));
>> +
>> $(alertifyDialog.elements.dialog).find('[tabindex]:not([tabindex="-1"]').first().focus();
>>
>> Use the same common function with
>> commonUtils.findAndSetFocus(alertifyDialog.elements.dialog)). It will
>> handle the focus.
>>
> Fixed.
>
>> Also, make the required changes mentioned on the pull request -
>> https://github.com/EnterpriseDB/AlertifyJS/pull/1
>>
> Fixed.
>
>>
>>
>> On Fri, Feb 21, 2020 at 11:19 AM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Aditya
>>>
>>> Can you please review this patch.
>>>
>>> On Wed, Feb 19, 2020 at 5:04 PM Pradip Parkale <
>>> [email protected]> wrote:
>>>
>>>> Please find the attached patch.
>>>>
>>>> On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi <
>>>> [email protected]> wrote:
>>>>
>>>>> Forgot to attach the patch?
>>>>>
>>>>> On Wed, 19 Feb 2020 at 16:58, Pradip Parkale <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Attached is a patch for accessibility issue related Alertifyjs.
>>>>>>
>>>>>> 1. Added hidden label to satisfy accessibility.
>>>>>> 2. Added label with sr-only class.
>>>>>> 3. Added tabindex to move the mouse control to the maximize
>>>>>> button using the tab key.
>>>>>>
>>>>>>
>>>>>> Please note that this patch also includes the fix for the
>>>>>> RM-5143 Accessibility issue to maximize the panel for backup and restore
>>>>>> windows and all other places.
>>>>>> --
>>>>>> Thanks & Regards,
>>>>>> Pradip Parkale
>>>>>> QMG, EnterpriseDB Corporation
>>>>>>
>>>>> --
>>>>>
>>>>> --
>>>>>
>>>>> Thanks & Regards,
>>>>>
>>>>> Ashesh Vashi
>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>> <http://www.enterprisedb.com;
>>>>>
>>>>>
>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks & Regards,
>>>> Pradip Parkale
>>>> QMG, EnterpriseDB Corporation
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> QMG, EnterpriseDB Corporation
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
view thread (9+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin][RM5154] [Accessibility] : Alertify
In-Reply-To: <CANxoLDfG8-OzFDAqumdTrk4KdONTCicw_5Ma-x1nqhRJf+_M0Q@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox