public inbox for [email protected]
help / color / mirror / Atom feedpgAdmin 4 commit: Fix unicode handling in the external process tools an
3+ messages / 2 participants
[nested] [flat]
* pgAdmin 4 commit: Fix unicode handling in the external process tools an
@ 2018-03-13 20:45 Dave Page <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Dave Page @ 2018-03-13 20:45 UTC (permalink / raw)
To: pgadmin-hackers
Fix unicode handling in the external process tools and show the complete command in the process viewer. Fixes #2963. Fixes #3157.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=802269910c37a52aa57479bbcc1d8d078f6a...
Author: Khushboo Vashi <[email protected]>
Modified Files
--------------
web/pgadmin/misc/bgprocess/processes.py | 36 +++++++++++++++++++++--
web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 6 ++--
web/pgadmin/tools/backup/__init__.py | 5 ++--
3 files changed, 38 insertions(+), 9 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgAdmin 4 commit: Fix unicode handling in the external process tools an
@ 2018-03-13 20:54 Joao De Almeida Pereira <[email protected]>
parent: Dave Page <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Joao De Almeida Pereira @ 2018-03-13 20:54 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Dave, Khushboo
Looks like there is a linting issue with this commit:
Successfully installed pycodestyle-2.3.1
<https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
/tmp/build/4a5630c2/pgadmin-master/web /tmp/build/4a5630c2
<https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
./pgadmin/misc/bgprocess/processes.py:186: [E225] missing whitespace
around operator
<https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
./pgadmin/tools/backup/__init__.py:113: [E303] too many blank lines (2)
<https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
1 E225 missing whitespace around operator
<https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
1 E303 too many blank lines (2)
<https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
2
Best Regards,
Victoria & Joao
On Tue, Mar 13, 2018 at 4:45 PM Dave Page <[email protected]> wrote:
> Fix unicode handling in the external process tools and show the complete
> command in the process viewer. Fixes #2963. Fixes #3157.
>
> Branch
> ------
> master
>
> Details
> -------
>
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=802269910c37a52aa57479bbcc1d8d078f6a...
> Author: Khushboo Vashi <[email protected]>
>
> Modified Files
> --------------
> web/pgadmin/misc/bgprocess/processes.py | 36
> +++++++++++++++++++++--
> web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 6 ++--
> web/pgadmin/tools/backup/__init__.py | 5 ++--
> 3 files changed, 38 insertions(+), 9 deletions(-)
>
>
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgAdmin 4 commit: Fix unicode handling in the external process tools an
@ 2018-03-13 21:30 Dave Page <[email protected]>
parent: Joao De Almeida Pereira <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Dave Page @ 2018-03-13 21:30 UTC (permalink / raw)
To: Joao De Almeida Pereira <[email protected]>; +Cc: pgadmin-hackers
Thanks - fixed. That begs the question of why Jenkins didn't catch it
though :-/
On Tue, Mar 13, 2018 at 4:54 PM, Joao De Almeida Pereira <
[email protected]> wrote:
> Hi Dave, Khushboo
>
> Looks like there is a linting issue with this commit:
>
> Successfully installed pycodestyle-2.3.1
> <https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
> /tmp/build/4a5630c2/pgadmin-master/web /tmp/build/4a5630c2
> <https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
> ./pgadmin/misc/bgprocess/processes.py:186: [E225] missing whitespace around operator
> <https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
> ./pgadmin/tools/backup/__init__.py:113: [E303] too many blank lines (2)
> <https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
> 1 E225 missing whitespace around operator
> <https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
> 1 E303 too many blank lines (2)
> <https://gpdb-dev.data.pivotal.ci/teams/main/pipelines/pgadmin-feature-branches/jobs/pgadmin-master-p...;
> 2
>
>
> Best Regards,
> Victoria & Joao
>
> On Tue, Mar 13, 2018 at 4:45 PM Dave Page <[email protected]> wrote:
>
>> Fix unicode handling in the external process tools and show the complete
>> command in the process viewer. Fixes #2963. Fixes #3157.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
>> 802269910c37a52aa57479bbcc1d8d078f6a88e1
>> Author: Khushboo Vashi <[email protected]>
>>
>> Modified Files
>> --------------
>> web/pgadmin/misc/bgprocess/processes.py | 36
>> +++++++++++++++++++++--
>> web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 6 ++--
>> web/pgadmin/tools/backup/__init__.py | 5 ++--
>> 3 files changed, 38 insertions(+), 9 deletions(-)
>>
>>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2018-03-13 21:30 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-03-13 20:45 pgAdmin 4 commit: Fix unicode handling in the external process tools an Dave Page <[email protected]>
2018-03-13 20:54 ` Joao De Almeida Pereira <[email protected]>
2018-03-13 21:30 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox