pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  

help / color / mirror / Atom feed

[pgjdbc/pgjdbc] PR #3493: chore: add ErrorProne verification to catch bugs ealier
6+ messages / 2 participants
[nested] [flat]

* [pgjdbc/pgjdbc] PR #3493: chore: add ErrorProne verification to catch bugs ealier
@ 2025-01-22 10:03 "vlsi (@vlsi)" <[email protected]>
  0 siblings, 0 replies; 6+ messages in thread

From: vlsi (@vlsi) @ 2025-01-22 10:03 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

This adds verifications from error-prone so we could catch errors earlier.
I suggest we fail the build on javac warnings as well.

However, we could probably live with warnings in the test code. Otherwise there will be a lot of warnings when testing deprecated classes. As we deprecate method, the test code should better be intact so it ensures the behavior is kept.

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3493: chore: add ErrorProne verification to catch bugs ealier
@ 2025-01-22 13:52 ` "davecramer (@davecramer)" <[email protected]>
  4 siblings, 0 replies; 6+ messages in thread

From: davecramer (@davecramer) @ 2025-01-22 13:52 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

cool, great idea

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3493: chore: add ErrorProne verification to catch bugs ealier
@ 2025-01-24 13:37 ` "vlsi (@vlsi)" <[email protected]>
  4 siblings, 0 replies; 6+ messages in thread

From: vlsi (@vlsi) @ 2025-01-24 13:37 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

It looks like this is finalized.

In practice, errorprone does not significantly increase the build time, so it might be worth running it on every build. WDYT?

Currently, I configured it so it executes errorpone only when explicitly asked (e.g. `./gradlew -PenableErrorprone classes` or `./gradlew style`)

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3493: chore: add ErrorProne verification to catch bugs ealier
@ 2025-01-24 14:02 ` "davecramer (@davecramer)" <[email protected]>
  4 siblings, 0 replies; 6+ messages in thread

From: davecramer (@davecramer) @ 2025-01-24 14:02 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

Thanks, this looks like it will clean up a lot of things.

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3493: chore: add ErrorProne verification to catch bugs ealier
@ 2025-01-24 14:53 ` "vlsi (@vlsi)" <[email protected]>
  4 siblings, 0 replies; 6+ messages in thread

From: vlsi (@vlsi) @ 2025-01-24 14:53 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

> it will clean up a lot of things.

Just for the reference, ErrorProne does not fix issues. It only reports them and suggests fixes.

For example:

```
> Task :postgresql:compileJava
pgjdbc/pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java:1741: Note: [MethodCanBeStatic] A private method that does not reference the enclosing instance can be static
  private void checkPermission(SQLPermission sqlPermissionNetworkTimeout) {
  ^
    (see https://errorprone.info/bugpattern/MethodCanBeStatic)
  Did you mean 'private static void checkPermission(SQLPermission sqlPermissionNetworkTimeout) {'?
```

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: [pgjdbc/pgjdbc] PR #3493: chore: add ErrorProne verification to catch bugs ealier
@ 2025-01-25 12:05 ` "davecramer (@davecramer)" <[email protected]>
  4 siblings, 0 replies; 6+ messages in thread

From: davecramer (@davecramer) @ 2025-01-25 12:05 UTC (permalink / raw)
  To: pgjdbc/pgjdbc <[email protected]>

That's a lot of work! Thanks

^ permalink  raw  reply  [nested|flat] 6+ messages in thread

end of thread, other threads:[~2025-01-25 12:05 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-01-22 10:03 [pgjdbc/pgjdbc] PR #3493: chore: add ErrorProne verification to catch bugs ealier "vlsi (@vlsi)" <[email protected]>
2025-01-22 13:52 ` "davecramer (@davecramer)" <[email protected]>
2025-01-24 13:37 ` "vlsi (@vlsi)" <[email protected]>
2025-01-24 14:02 ` "davecramer (@davecramer)" <[email protected]>
2025-01-24 14:53 ` "vlsi (@vlsi)" <[email protected]>
2025-01-25 12:05 ` "davecramer (@davecramer)" <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox