pg.ddx.io pgsql-admin@postgresql.org mailing list archive help / color / mirror / Atom feed From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@heroku.com>
To: Andres Freund <andres@anarazel.de>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0
Date: Fri, 08 May 2015 15:13:04 -0400
Message-ID: <18911.1431112384@sss.pgh.pa.us> (raw )
In-Reply-To: <18691.1431112058@sss.pgh.pa.us >
References: <CAM3SWZTGE0z5_E8wRi9wt3qgOiMpSwtwr5uDcZDGhRZ1_pz6vg@mail.gmail.com >
<20150508150340.GJ12950@alap3.anarazel.de >
<9096.1431102730@sss.pgh.pa.us >
<20150508165246.GO12950@alap3.anarazel.de >
<10633.1431105922@sss.pgh.pa.us >
<554CF44B.3080808@iki.fi >
<20150508180636.GR12950@alap3.anarazel.de >
<CAM3SWZQsh=uDmyRW4NzYqU_kv8qAsvCYpJuuYSuikfuJbLANQQ@mail.gmail.com >
<20150508181445.GS12950@alap3.anarazel.de >
<17473.1431109846@sss.pgh.pa.us >
<20150508183504.GU12950@alap3.anarazel.de >
<18313.1431111562@sss.pgh.pa.us >
<CAM3SWZSqDaRG9c12XewsKqFLkNAak1kxie3UZ6+Wi9cC2UKT8g@mail.gmail.com >
<18691.1431112058@sss.pgh.pa.us >
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
I wrote:
> Peter Geoghegan <pg@heroku.com> writes:
>> On Fri, May 8, 2015 at 11:59 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Ooops. But shouldn't that have failed 100% of the time in a CCA build?
>>> Or is the candidates list fairly noncritical?
>> The candidates list is absolutely critical.
> Oh, I was confusing CCA with RELCACHE_FORCE_RELEASE, which does something
> a bit different.
Actually, looking closer, the quoted code is simply not broken without
RELCACHE_FORCE_RELEASE: without that, neither heap_close nor index_close
will do anything that could cause a cache flush. So while it's certainly
good pratice to move that lappend_oid call up, it does not explain the
observed symptoms. We still need some more investigation here.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
view thread (77+ messages) latest in thread
Message-ID: <18911.1431112384@sss.pgh.pa.us>
Permalink: ../18911.1431112384@sss.pgh.pa.us/
Also on: postgresql.org/message-id/18911.1431112384@sss.pgh.pa.us
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-admin@postgresql.org
Cc: tgl@sss.pgh.pa.us, pg@heroku.com, andres@anarazel.de, hlinnaka@iki.fi, jeff.janes@gmail.com, sfrost@snowman.net, dean.a.rasheed@gmail.com, bruce@momjian.us, pgsql-hackers@postgresql.org
Subject: Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0
In-Reply-To: <18911.1431112384@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox