From: Alvaro Herrera <alvherre@commandprompt.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: dx k9 <bitsandbytes88@hotmail.com>
Cc: pgsql-admin@postgresql.org
Cc: pgsql-hackers@postgresql.org
Subject: Re: reindexdb hangs
Date: Mon, 10 Sep 2007 18:07:00 -0400
Message-ID: <20070910220700.GC3060@alvh.no-ip.org> (raw)
In-Reply-To: <7460.1188500061@sss.pgh.pa.us>
References: <BAY116-F2261C1BEF758D30196729DD1420@phx.gbl>
<22018.1178144703@sss.pgh.pa.us>
<20070825222150.GU31461@alvh.no-ip.org>
<4909.1188082313@sss.pgh.pa.us>
<20070829222341.GX7911@alvh.no-ip.org>
<12577.1188428726@sss.pgh.pa.us>
<20070830164151.GS5872@alvh.no-ip.org>
<7460.1188500061@sss.pgh.pa.us>
Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > I'm not sure I follow. Are you suggesting adding a new function,
> > similar to pg_class_ownercheck, which additionally checks for temp-ness?
>
> No, I was just suggesting adding the check for temp-ness in cluster()
> and cluster_rel() where we do pg_class_ownercheck. We already have the
> rel open there and so it's cheap to do the temp-ness check.
I applied a patch along these lines to HEAD and 8.2.
I am unsure if I should backpatch to 8.1: the code in cluster.c has
changed, and while it is relatively easy to modify the patch, this is a
rare bug and nobody has reported it in CLUSTER (not many people clusters
temp tables, it seems). Should I patch only REINDEX? How far back?
--
Alvaro Herrera http://www.amazon.com/gp/registry/5ZYLFMCVHXC
"The eagle never lost so much time, as
when he submitted to learn of the crow." (William Blake)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-admin@postgresql.org
Cc: alvherre@commandprompt.com, tgl@sss.pgh.pa.us, bitsandbytes88@hotmail.com, pgsql-hackers@postgresql.org
Subject: Re: reindexdb hangs
In-Reply-To: <20070910220700.GC3060@alvh.no-ip.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox