pg.ddx.io  pgsql-admin@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Frost <jeff@frostconsultingllc.com>
Cc: pgsql-admin@postgresql.org
Subject: Re: pg_dumpall 8.1.4 large objects error
Date: Fri, 09 Jun 2006 16:08:24 -0400
Message-ID: <24379.1149883704@sss.pgh.pa.us> (raw)
In-Reply-To: <Pine.LNX.4.64.0606090949000.27250@glacier.frostconsultingllc.com>
References: <Pine.LNX.4.64.0606061826420.23923@discord.home.frostconsultingllc.com>
	<25292.1149650216@sss.pgh.pa.us>
	<Pine.LNX.4.64.0606070950040.27250@glacier.frostconsultingllc.com>
	<Pine.LNX.4.64.0606090918550.27250@glacier.frostconsultingllc.com>
	<12965.1149871382@sss.pgh.pa.us>
	<Pine.LNX.4.64.0606090949000.27250@glacier.frostconsultingllc.com>

I wrote:
>> This is computing obj_description() redundantly for each pg_largeobject
>> chunk.  Perhaps there is a memory leak in obj_description() in 7.3.2?

Actually, obj_description() is a SQL-language function, and we had
horrendous problems with end-of-function-call memory leakage in SQL
functions in every version before 7.4.  So this is undoubtedly the
source of Jeff's problem.

Jeff Frost <jeff@frostconsultingllc.com> writes:
> I'll alter pg_dump and recompile, then give a test.  Does pg_dumpall just call 
> pg_dump or do I need to change it there too?

pg_dumpall calls pg_dump, so only one place to fix.  I've already
committed the fix in CVS, if you'd prefer to use a tested patch.
http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c.diff?r1=1.422.2.3;r2=1.42...

			regards, tom lane



view thread (11+ messages)  latest in thread

Message-ID: <24379.1149883704@sss.pgh.pa.us>
Permalink:  ../24379.1149883704@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/24379.1149883704@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-admin@postgresql.org
  Cc: tgl@sss.pgh.pa.us, jeff@frostconsultingllc.com
  Subject: Re: pg_dumpall 8.1.4 large objects error
  In-Reply-To: <24379.1149883704@sss.pgh.pa.us>
  References: <Pine.LNX.4.64.0606061826420.23923@discord.home.frostconsultingllc.com> <25292.1149650216@sss.pgh.pa.us> <Pine.LNX.4.64.0606070950040.27250@glacier.frostconsultingllc.com> <Pine.LNX.4.64.0606090918550.27250@glacier.frostconsultingllc.com> <12965.1149871382@sss.pgh.pa.us> <Pine.LNX.4.64.0606090949000.27250@glacier.frostconsultingllc.com> <24379.1149883704@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox