From: Tom Lane <tgl@sss.pgh.pa.us>
To: Changqing Li <changqing.li@windriver.com>
Cc: pgsql-bugs@lists.postgresql.org, Changqing Li <changqing.li@eng.windriver.com>
Subject: Re: A build failure since only include header "postgresql/server/port.h"
Date: Wed, 06 Mar 2024 10:18:26 -0500
Message-ID: <136934.1709738306@sss.pgh.pa.us> (raw)
In-Reply-To: <ab31fa66-face-4866-8e2f-b947f4ba42a6@windriver.com>
References: <ab31fa66-face-4866-8e2f-b947f4ba42a6@windriver.com>
Changqing Li <changqing.li@windriver.com> writes:
> SIGNAL_ARGS is used in port.h, it is defined in c.h, But port.h don't
> include c.h, and cause above error. Should we include c.h in port.h?
No, absolutely not. The expectation in all PG header files is that
the .c file included one of postgres.h, postgres_fe.h, or c.h to
begin with (mainly to establish whether this file is backend code,
frontend code, or intended to work as both). This is your error
not port.h's.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, changqing.li@windriver.com, changqing.li@eng.windriver.com
Subject: Re: A build failure since only include header "postgresql/server/port.h"
In-Reply-To: <136934.1709738306@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox