From: Changqing Li <changqing.li@windriver.com>
To: pgsql-bugs@lists.postgresql.org
Cc: Changqing Li <changqing.li@eng.windriver.com>
Subject: A build failure since only include header "postgresql/server/port.h"
Date: Wed, 6 Mar 2024 16:51:41 +0800
Message-ID: <ab31fa66-face-4866-8e2f-b947f4ba42a6@windriver.com> (raw)
Hi,
I am building pgpool2, and there is a snprintf.c, which use
PG_STRERROR_R_BUFLEN, so I include header "postgresql/server/port.h".
It works well before. but after I upgrade postgresql from 15.5 to
16.2, I will met following error:
usr/include/postgresql/server/port.h:488:28: error: a parameter list without types is only allowed in a function definition
488 | typedef void (*pqsigfunc) (SIGNAL_ARGS);
| ^
Since commit
https://github.com/postgres/postgres/commit/b66fbd8afe6eb80e3e48495e002fda9aa92df583#diff-c6b9d5a7f7...,
SIGNAL_ARGS is used in port.h, it is defined in c.h, But port.h don't
include c.h, and cause above error. Should we include c.h in port.h?
I also tried include c.h in port.h, but met another error when
building pgpool2. I also reported this to pgpool2 community:
https://www.pgpool.net/mantisbt/view.php?id=830
Could you help to give an suggestion about how to fix this issue?
Thanks
Changqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: changqing.li@windriver.com, pgsql-bugs@lists.postgresql.org, changqing.li@eng.windriver.com
Subject: Re: A build failure since only include header "postgresql/server/port.h"
In-Reply-To: <ab31fa66-face-4866-8e2f-b947f4ba42a6@windriver.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox